finish fix.

Author: dlyr

.github/workflows/build-matrix.yml

@@ -235,7 +235,7 @@ jobs:
       - name: Run unit tests
         if: ${{ inputs.coverage == 'false' }}
         run: |
-          cmake --build "${{ steps.paths.outputs.radium_build_dir }}" --parallel --config ${{ matrix.build-type }} --target check_verbose
+          cmake --build "${{ steps.paths.outputs.radium_build_dir }}" --parallel --config ${{ matrix.build-type }} --target check
           cmake --build "${{ steps.paths.outputs.radium_build_dir }}" --parallel --config ${{ matrix.build-type }} --target Install_CoreExample
           "${{ steps.paths.outputs.radium_install_dir }}/bin/CoreExample"
 

src/Core/CoreMacros.hpp

@@ -13,7 +13,6 @@
 // clang-format off
 #pragma once
 
-#include <Eigen/Core>
 #include <cassert>
 #include <cstdio>
 #include <iostream>
@@ -401,5 +400,4 @@ MACRO_END
 #ifndef eigen_assert
 #define eigen_assert(XXX) CORE_ASSERT(XXX, "Eigen Assert");
 #endif
-
 // clang-format on

src/Core/Geometry/TriangleMesh.hpp

@@ -444,10 +444,6 @@ inline void AttribArrayGeometry::initDefaultAttribs() {
     m_normalsHandle = m_vertexAttribs.addAttrib<NormalAttribHandle::value_type>(
         getAttribName( MeshAttrib::VERTEX_NORMAL ) );
     invalidateAabb();
-
-    std::cerr << "debug init default " << getAttribName( VERTEX_POSITION ) << "\n";
-    vertexAttribs().for_each_attrib(
-        []( const Utils::AttribBase* a ) { std::cerr << "attrib " << a->getName() << "\n"; } );
 }
 
 template <typename T>

tests/unittest/Core/indexview.cpp

@@ -103,9 +103,6 @@ TEST_CASE( "Core/Geometry/IndexedGeometry/Attributes",
     MultiIndexedGeometry mesh( Ra::Core::Geometry::makeBox() );
 
     // base attributes are automatically added
-    std::cerr << getAttribName( VERTEX_POSITION ) << "\n";
-    mesh.vertexAttribs().for_each_attrib(
-        []( const AttribBase* a ) { std::cerr << "attrib " << a->getName() << "\n"; } );
     auto h_pos = mesh.getAttribHandle<Vector3>( getAttribName( VERTEX_POSITION ) );
     REQUIRE( mesh.isValid( h_pos ) );
     auto h_nor = mesh.getAttribHandle<Vector3>( getAttribName( VERTEX_NORMAL ) );

tests/unittest/Dataflow/graph.cpp

@@ -345,12 +345,13 @@ TEST_CASE( "Dataflow/Core/Graph/Inspection of a graph", "[unittests][Dataflow][C
     using namespace Ra::Dataflow::Core;
 
     // add some nodes to factory
-    using ScalarFilterSource    = Sources::FunctionSourceNode<Scalar, const Scalar&>;
-    using ScalarFunctionSource  = Sources::FunctionSourceNode<Scalar, const Scalar&, const Scalar&>;
-    using ScalarPredicateSource = Sources::FunctionSourceNode<bool, const Scalar&, const Scalar&>;
-    using ReduceNode            = Functionals::ReduceNode<Ra::Core::VectorArray<Scalar>>;
-    using TransformNode         = Functionals::TransformNode<Ra::Core::VectorArray<Scalar>>;
-    using ScalarVectorSource    = Sources::SingleDataSourceNode<Ra::Core::VectorArray<Scalar>>;
+    //    using ScalarFilterSource    = Sources::FunctionSourceNode<Scalar, const Scalar&>;
+    //    using ScalarFunctionSource  = Sources::FunctionSourceNode<Scalar, const Scalar&, const
+    //    Scalar&>; using ScalarPredicateSource = Sources::FunctionSourceNode<bool, const Scalar&,
+    //    const Scalar&>; using ReduceNode            =
+    //    Functionals::ReduceNode<Ra::Core::VectorArray<Scalar>>; using TransformNode         =
+    //    Functionals::TransformNode<Ra::Core::VectorArray<Scalar>>; using ScalarVectorSource    =
+    //    Sources::SingleDataSourceNode<Ra::Core::VectorArray<Scalar>>;
 
     std::cout << "Loading graph data/Dataflow/ExampleGraph.json\n";