fix(env): stop or kill docker containers on cleanup#869
Open
dannyward630 wants to merge 1 commit into
Open
Conversation
dannyward630
marked this pull request as ready for review
June 18, 2026 23:03
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #797.
DockerEnvironment.cleanup()currently falls back fromdocker stoptodocker rm -f. That makes cleanup force removal whenstopfails, even though removal is already controlled by the configuredrun_args(--rmby default) and users may intentionally omit--rmto keep stopped containers for debugging.This changes the fallback to
docker kill, so cleanup attempts to terminate the container while leaving removal policy to Docker's--rmbehavior or the user'srun_argsoverride.Validation
.venv/bin/python -m pytest tests/environments/test_docker.py -k 'config_defaults or cleanup_stops_or_kills'1 passed, 2 skipped, 20 deselectedon this machine because Docker/Podman are not available.venv/bin/ruff check src/minisweagent/environments/docker.py tests/environments/test_docker.pygit diff --check