Enhance Inventory App: Add Support to Manage and Assign Global SNMP Settings#53
Merged
PaulWinterstein merged 4 commits intoJul 2, 2025
Conversation
…operations), SNMP config Pydantic Model, uuid validation and test
… global SNMP model, and getter/setter in InventoryDevice for global SNMP config
JonasScholl
approved these changes
Jul 2, 2025
JonasScholl
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 Even with some tests, nice :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #52
Summary
Adds support for managing global SNMP configurations in the Inventory App, including:
This enables assigning reusable SNMP configurations to devices in a lightweight and consistent way.
Example: Assign SNMP config to a device by label
Assuming a global SNMP configuration named "SNMP Config for eMerge" has already been created via the Inventory App GUI:
Optional: store the reference only (without activating it yet):
To verify assigned config: