fix: recover profile and avatar loading (#566)

### Description

Fixes profile and avatar loading regressions introduced around the
MSC4440 bio compatibility work.

This PR addresses two related problems:

- Own profile data could disappear when `useUserProfile` encountered
`gay.fomx.biography` in an unexpected shape or when the field was
missing entirely.
- Avatar components could get stuck in fallback mode after a transient
image load failure, causing the account avatar and other avatars to
disappear until a full reload.

The fix does three things:

- parses `gay.fomx.biography` defensively with optional access instead
of assuming `m.text[0].body` always exists
- retries profile fetches when the cache was previously poisoned into an
`_fetched`-only state after normalization failed
- resets avatar error state when the image `src` changes so transient
media/auth failures can recover on later renders

This was verified against the broken Account settings / account switcher
behavior where avatar, banner, bio, status, and pronouns could appear
missing.

Fixup of #559

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (GitHub Copilot)

`useUserProfile.ts`: Hardened MSC4440 bio parsing so missing or
malformed `gay.fomx.biography` data does not throw during normalization,
and allowed refetching when the profile cache only contains `_fetched:
true` from a prior failed normalization.

`UserAvatar.tsx` and `RoomAvatar.tsx`: Reset local image error state
when `src` changes so a temporary image load failure does not
permanently lock the component into fallback rendering.

Author: 7w1

src/app/components/room-avatar/RoomAvatar.tsx

@@ -1,6 +1,6 @@
 import { JoinRule } from '$types/matrix-sdk';
 import { AvatarFallback, Icon, Icons, color } from 'folds';
-import { ComponentProps, ReactNode, forwardRef, useState } from 'react';
+import { ComponentProps, ReactNode, forwardRef, useEffect, useState } from 'react';
 import { getRoomIconSrc } from '$utils/room';
 import colorMXID from '$utils/colorMXID';
 import * as css from './RoomAvatar.css';
@@ -17,6 +17,10 @@ type RoomAvatarProps = {
 export function RoomAvatar({ roomId, src, alt, renderFallback, uniformIcons }: RoomAvatarProps) {
   const [error, setError] = useState(false);
 
+  useEffect(() => {
+    setError(false);
+  }, [src]);
+
   if (!src || error) {
     return (
       <AvatarFallback

src/app/components/user-avatar/UserAvatar.tsx

@@ -1,5 +1,5 @@
 import { AvatarFallback, AvatarImage, color } from 'folds';
-import { ReactEventHandler, ReactNode, useState } from 'react';
+import { ReactEventHandler, ReactNode, useEffect, useState } from 'react';
 import classNames from 'classnames';
 import colorMXID from '$utils/colorMXID';
 import * as css from './UserAvatar.css';
@@ -14,6 +14,10 @@ type UserAvatarProps = {
 export function UserAvatar({ className, userId, src, alt, renderFallback }: UserAvatarProps) {
   const [error, setError] = useState(false);
 
+  useEffect(() => {
+    setError(false);
+  }, [src]);
+
   const handleLoad: ReactEventHandler<HTMLImageElement> = (evt) => {
     evt.currentTarget.setAttribute('data-image-loaded', 'true');
   };

src/app/hooks/useUserProfile.ts

@@ -32,6 +32,7 @@ export type UserProfile = {
 };
 
 const normalizeInfo = (info: any): UserProfile => {
+  const msc4440Bio = info['gay.fomx.biography'] as MSC4440Bio | undefined;
   const knownKeys = new Set([
     'avatar_url',
     'displayname',
@@ -61,7 +62,7 @@ const normalizeInfo = (info: any): UserProfile => {
     pronouns: info['io.fsky.nyx.pronouns'],
     timezone: info['us.cloke.msc4175.tz'] || info['m.tz'],
     bio:
-      (info['gay.fomx.biography'] satisfies MSC4440Bio)['m.text'][0].body ||
+      msc4440Bio?.['m.text']?.[0]?.body ||
       info['moe.sable.app.bio'] ||
       info['chat.commet.profile_bio'],
     status: info['chat.commet.profile_status'],
@@ -103,7 +104,10 @@ export const useUserProfile = (
   const cached = useAtomValue(userSelector);
   const setGlobalProfiles = useSetAtom(profilesCacheAtom);
 
-  const needsFetch = !!userId && userId !== 'undefined' && !cached?._fetched;
+  const hasOnlyFetchedMarker =
+    cached?._fetched === true && Object.keys(cached ?? {}).every((key) => key === '_fetched');
+  const needsFetch =
+    !!userId && userId !== 'undefined' && (!cached?._fetched || hasOnlyFetchedMarker);
 
   useEffect(() => {
     if (!needsFetch) return undefined;