Add partial MSC4459 support and refactor related code (#730)

### Description

partial implementation of
[MSC4459](matrix-org/matrix-spec-proposals#4459)

Currently only sending the data and not rendering anything

Partially #729

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

No AI used

Author: 7w1

.changeset/initial_msc4459_support.md

@@ -0,0 +1,5 @@
+---
+default: minor
+---
+
+# add initial support for sending discoverable emojis and sticker

src/app/components/create-room/AdditionalCreatorInput.tsx

@@ -17,9 +17,10 @@ import {
 } from 'folds';
 import { isKeyHotkey } from 'is-hotkey';
 import FocusTrap from 'focus-trap-react';
+import { getMxIdServer } from '$utils/mxIdHelper';
 import type { ChangeEventHandler, KeyboardEventHandler, MouseEventHandler } from 'react';
 import { useMemo, useState } from 'react';
-import { getMxIdLocalPart, getMxIdServer, isUserId } from '$utils/matrix';
+import { getMxIdLocalPart, isUserId } from '$utils/matrix';
 import { useDirectUsers } from '$hooks/useDirectUsers';
 import { useMatrixClient } from '$hooks/useMatrixClient';
 import { stopPropagation } from '$utils/keyboard';

src/app/components/create-room/CreateRoomAliasInput.tsx

@@ -3,12 +3,12 @@ import { useCallback, useEffect, useRef, useState } from 'react';
 import { MatrixError } from '$types/matrix-sdk';
 import { Box, color, Icon, Icons, Input, Spinner, Text, toRem } from 'folds';
 import { isKeyHotkey } from 'is-hotkey';
-import { getMxIdServer } from '$utils/matrix';
 import { useMatrixClient } from '$hooks/useMatrixClient';
 import { replaceSpaceWithDash } from '$utils/common';
 import type { AsyncState } from '$hooks/useAsyncCallback';
 import { AsyncStatus, useAsync } from '$hooks/useAsyncCallback';
 import { useDebounce } from '$hooks/useDebounce';
+import { getMxIdServer } from '$utils/mxIdHelper';
 
 export function CreateRoomAliasInput({ disabled }: { disabled?: boolean }) {
   const mx = useMatrixClient();

src/app/components/create-room/utils.ts

@@ -9,7 +9,7 @@ import { JoinRule, RestrictedAllowType, EventType, RoomType } from '$types/matri
 
 import type { StateEvents } from '$types/matrix-sdk';
 import { getViaServers } from '$plugins/via-servers';
-import { getMxIdServer } from '$utils/matrix';
+import { getMxIdServer } from '$utils/mxIdHelper';
 import { CreateRoomAccess } from './types';
 
 export const createRoomCreationContent = (

src/app/components/editor/autocomplete/RoomMentionAutocomplete.tsx

@@ -9,9 +9,9 @@ import { useAtomValue } from 'jotai';
 
 import { getDirectRoomAvatarUrl } from '$utils/room';
 import { useMatrixClient } from '$hooks/useMatrixClient';
-import { getMxIdServer, isRoomAlias } from '$utils/matrix';
-import type { UseAsyncSearchOptions } from '$hooks/useAsyncSearch';
+import { isRoomAlias } from '$utils/matrix';
 import { useAsyncSearch } from '$hooks/useAsyncSearch';
+import type { UseAsyncSearchOptions } from '$hooks/useAsyncSearch';
 import { onTabPress } from '$utils/keyboard';
 import { useKeyDown } from '$hooks/useKeyDown';
 import { mDirectAtom } from '$state/mDirectList';
@@ -20,6 +20,7 @@ import { factoryRoomIdByActivity } from '$utils/sort';
 import { RoomAvatar, RoomIcon } from '$components/room-avatar';
 import { getViaServers } from '$plugins/via-servers';
 import { createMentionElement, moveCursor, replaceWithElement } from '$components/editor/utils';
+import { getMxIdServer } from '$utils/mxIdHelper';
 import { AutocompleteMenu } from './AutocompleteMenu';
 import type { AutocompleteQuery } from './autocompleteQuery';
 

src/app/components/editor/autocomplete/UserMentionAutocomplete.tsx

@@ -11,14 +11,15 @@ import type { SearchItemStrGetter, UseAsyncSearchOptions } from '$hooks/useAsync
 import { useAsyncSearch } from '$hooks/useAsyncSearch';
 import { onTabPress } from '$utils/keyboard';
 import { useKeyDown } from '$hooks/useKeyDown';
-import { getMxIdLocalPart, getMxIdServer, isUserId } from '$utils/matrix';
+import { getMxIdLocalPart, isUserId } from '$utils/matrix';
 import { getMemberDisplayName, getMemberSearchStr } from '$utils/room';
 import { UserAvatar } from '$components/user-avatar';
 import { useMediaAuthentication } from '$hooks/useMediaAuthentication';
 
 import { useAtomValue } from 'jotai';
 import { nicknamesAtom } from '$state/nicknames';
 import { createMentionElement, moveCursor, replaceWithElement } from '$components/editor/utils';
+import { getMxIdServer } from '$utils/mxIdHelper';
 import { AutocompleteMenu } from './AutocompleteMenu';
 import type { AutocompleteQuery } from './autocompleteQuery';
 import { KnownMembership } from '$types/matrix-sdk';

src/app/components/invite-user-prompt/InviteUserPrompt.tsx

@@ -27,15 +27,15 @@ import { isKeyHotkey } from 'is-hotkey';
 import FocusTrap from 'focus-trap-react';
 import { stopPropagation } from '$utils/keyboard';
 import { useDirectUsers } from '$hooks/useDirectUsers';
-import { getMxIdLocalPart, getMxIdServer, isUserId } from '$utils/matrix';
-
+import { getMxIdLocalPart, isUserId } from '$utils/matrix';
 import type { UseAsyncSearchOptions } from '$hooks/useAsyncSearch';
 import { useAsyncSearch } from '$hooks/useAsyncSearch';
 import { highlightText, makeHighlightRegex } from '$plugins/react-custom-html-parser';
 import { AsyncStatus, useAsyncCallback } from '$hooks/useAsyncCallback';
 import { useMatrixClient } from '$hooks/useMatrixClient';
 import { BreakWord } from '$styles/Text.css';
 import { useAlive } from '$hooks/useAlive';
+import { getMxIdServer } from '$utils/mxIdHelper';
 import { KnownMembership } from '$types/matrix-sdk';
 
 const SEARCH_OPTIONS: UseAsyncSearchOptions = {

src/app/components/message/modals/MessageForward.tsx

@@ -18,17 +18,15 @@ import {
 } from 'folds';
 import { useAtomValue, useSetAtom } from 'jotai';
 import type { MatrixEvent, Room } from '$types/matrix-sdk';
-import { JoinRule, EventType } from '$types/matrix-sdk';
 import { useEffect, useMemo, useState } from 'react';
 import { allRoomsAtom } from '$state/room-list/roomList';
 import { useAllJoinedRoomsSet, useGetRoom } from '$hooks/useGetRoom';
 import { factoryRoomIdByActivity } from '$utils/sort';
 import * as css from '$features/room/message/styles.css';
 import { sanitizeCustomHtml, sanitizeText } from '$utils/sanitize';
-import { getStateEvents } from '$utils/room';
-
 import { createDebugLogger } from '$utils/debugLogger';
 import * as Sentry from '@sentry/react';
+import { isRoomPrivate } from '$utils/roomVisibility';
 
 const debugLog = createDebugLogger('MessageForward');
 
@@ -112,28 +110,6 @@ export function MessageForwardInternal({
   const [isForwarding, setIsForwarding] = useState(false);
   const [forwardError, setForwardError] = useState<string | null>(null);
   const [targetRoomId, setTargetRoomId] = useState<string | null>(null);
-
-  // detect if it's a public room or not
-  const joinRule = room.getJoinRule() ?? JoinRule.Invite;
-
-  const parentSpaceIds = getStateEvents(room, EventType.SpaceParent)
-    .map((e) => e.getStateKey())
-    .filter((id): id is string => Boolean(id));
-
-  const isInPublicSpace = parentSpaceIds.some((spaceId) => {
-    const space = mx.getRoom(spaceId);
-    return Boolean(space?.isSpaceRoom()) && space?.getJoinRule() === JoinRule.Public;
-  });
-
-  // A room is private if its join rule is Invite (or other non-public/non-knock/non-restricted),
-  // or it's Restricted but NOT inside a public space.
-  const isPrivate =
-    joinRule === JoinRule.Invite ||
-    (joinRule === JoinRule.Restricted && !isInPublicSpace) ||
-    (joinRule !== JoinRule.Public &&
-      joinRule !== JoinRule.Knock &&
-      joinRule !== JoinRule.Restricted);
-
   const allRooms = useAtomValue(allRoomsAtom);
   const allJoinedRooms = useAllJoinedRoomsSet();
   const getRoom = useGetRoom(allJoinedRooms);
@@ -191,7 +167,7 @@ export function MessageForwardInternal({
         : undefined;
 
     const bodyModifText = `(Forwarded message from ${
-      isPrivate ? 'a private room' : (getRoom(room.roomId)?.name ?? 'a room')
+      isRoomPrivate(mx, room) ? 'a private room' : (getRoom(room.roomId)?.name ?? 'a room')
     })`;
 
     let newBodyPlain = '';
@@ -230,7 +206,7 @@ export function MessageForwardInternal({
     delete baseContent['com.beeper.per_message_profile']; // remove per-message profile as that could confuse clients in the target room
     let content;
     // handle privacy stuff
-    if (isPrivate) {
+    if (isRoomPrivate(mx, room)) {
       // if the message is from a private room, we should strip any media or mentions to avoid leaking information to the target room
       // we can still include the original message content in the body of the message, so we'll just use a fallback text/plain content with the original message body
       content = {
@@ -271,7 +247,7 @@ export function MessageForwardInternal({
       sourceRoomId: room.roomId,
       targetRoomId: targetRoom.roomId,
       msgtype,
-      isPrivate,
+      isPrivate: isRoomPrivate(mx, room),
     });
     Sentry.metrics.count('sable.message.forward.attempt', 1, { attributes: { msgtype } });
     mx.sendEvent(targetRoom.roomId, null, eventType, content as unknown as SendEventContent)

src/app/components/user-profile/UserChips.tsx

@@ -22,7 +22,6 @@ import {
   Avatar,
 } from 'folds';
 import { useMatrixClient } from '$hooks/useMatrixClient';
-import { getMxIdServer } from '$utils/matrix';
 import { useCloseUserRoomProfile } from '$state/hooks/userRoomProfile';
 import { stopPropagation } from '$utils/keyboard';
 import { copyToClipboard } from '$utils/dom';
@@ -43,6 +42,7 @@ import { useNickname, useSetNickname } from '$hooks/useNickname';
 import { CutoutCard } from '$components/cutout-card';
 import { SettingTile } from '$components/setting-tile';
 import { RoomAvatar, RoomIcon } from '$components/room-avatar';
+import { getMxIdServer } from '$utils/mxIdHelper';
 
 export function ServerChip({ server }: { server: string }) {
   const mx = useMatrixClient();

src/app/components/user-profile/UserRoomProfile.tsx

@@ -5,7 +5,7 @@ import { useNavigate } from 'react-router-dom';
 import { useAtomValue } from 'jotai';
 import type { Opts as LinkifyOpts } from 'linkifyjs';
 import type { HTMLReactParserOptions } from 'html-react-parser';
-import { getMxIdServer, mxcUrlToHttp } from '$utils/matrix';
+import { mxcUrlToHttp } from '$utils/matrix';
 import { getMemberAvatarMxc, getMemberDisplayName } from '$utils/room';
 import { useMatrixClient } from '$hooks/useMatrixClient';
 import { useMediaAuthentication } from '$hooks/useMediaAuthentication';
@@ -37,6 +37,7 @@ import { getSettings, settingsAtom } from '$state/settings';
 import { filterPronounsByLanguage } from '$utils/pronouns';
 import { useSetting } from '$state/hooks/settings';
 import { useSettingsLinkBaseUrl } from '$features/settings/useSettingsLinkBaseUrl';
+import { getMxIdServer } from '$utils/mxIdHelper';
 import { TextViewerContent } from '$components/text-viewer';
 import { CreatorChip } from './CreatorChip';
 import { UserInviteAlert, UserBanAlert, UserModeration, UserKickAlert } from './UserModeration';