chore: fix prettier formatting and TypeScript type error in test

Author: Just-Insane

src/client/slidingSync.test.ts

@@ -89,6 +89,7 @@ function makeMockMx(overrides: Record<string, unknown> = {}) {
     store: {
       setSyncData: vi.fn().mockResolvedValue(undefined),
       save: vi.fn().mockResolvedValue(undefined),
+      removeRoom: vi.fn(),
     },
     ...overrides,
   } as unknown as import('$types/matrix-sdk').MatrixClient;
@@ -169,6 +170,24 @@ describe('SlidingSyncManager — timeline pruning on unsubscribe', () => {
     expect(payload.rooms.join['!room:example.com'].timeline.limited).toBe(true);
   });
 
+  it('evicts room from store cache when persist fails', async () => {
+    const room = makeMockRoom(PRUNE_THRESHOLD + 1);
+    const mx = makeMockMx({ getRoom: vi.fn().mockReturnValue(room) });
+    // Make setSyncData reject to simulate an IndexedDB write failure.
+    (
+      mx as unknown as { store: { setSyncData: ReturnType<typeof vi.fn> } }
+    ).store.setSyncData.mockRejectedValue(new Error('IndexedDB write failed'));
+    const manager = makeManager(mx);
+
+    manager.unsubscribeFromRoom('!room:example.com');
+    await flushPromises();
+
+    const { store } = mx as unknown as {
+      store: { removeRoom: ReturnType<typeof vi.fn> };
+    };
+    expect(store.removeRoom).toHaveBeenCalledWith('!room:example.com');
+  });
+
   it('does not reset when event count equals the threshold exactly', () => {
     const room = makeMockRoom(PRUNE_THRESHOLD);
     const mx = makeMockMx({ getRoom: vi.fn().mockReturnValue(room) });
@@ -205,13 +224,16 @@ describe('SlidingSyncManager — membership leave auto-unsubscribe', () => {
     mx: ReturnType<typeof makeMockMx>,
     membership: string,
     roomId = '!room:example.com',
-    userId = '@user:example.com',
+    userId = '@user:example.com'
   ) {
     const onCall = (mx.on as ReturnType<typeof vi.fn>).mock.calls.find(
-      ([event]: [string]) => event === 'RoomMember.membership',
+      (args: unknown[]) => args[0] === 'RoomMember.membership'
     );
     if (!onCall) throw new Error('onMembershipLeave listener not registered');
-    const [, handler] = onCall as [string, (e: unknown, m: { userId: string; roomId: string; membership: string }) => void];
+    const [, handler] = onCall as [
+      string,
+      (e: unknown, m: { userId: string; roomId: string; membership: string }) => void,
+    ];
     handler(undefined, { userId, roomId, membership });
   }
 
@@ -275,4 +297,3 @@ describe('SlidingSyncManager — membership leave auto-unsubscribe', () => {
     expect(room._resetLiveTimeline).not.toHaveBeenCalled();
   });
 });
-

src/client/slidingSync.ts

@@ -258,7 +258,10 @@ export class SlidingSyncManager {
 
   private readonly onLifecycle: (state: SlidingSyncState, resp: unknown, err?: Error) => void;
 
-  private readonly onMembershipLeave: (event: unknown, member: { userId: string; roomId: string; membership?: string }) => void;
+  private readonly onMembershipLeave: (
+    event: unknown,
+    member: { userId: string; roomId: string; membership?: string }
+  ) => void;
 
   private presenceExtension!: ExtensionPresence;
 
@@ -430,7 +433,8 @@ export class SlidingSyncManager {
 
     this.onMembershipLeave = (_event, member) => {
       if (member.userId !== this.mx.getUserId()) return;
-      if (member.membership !== KnownMembership.Leave && member.membership !== KnownMembership.Ban) return;
+      if (member.membership !== KnownMembership.Leave && member.membership !== KnownMembership.Ban)
+        return;
       if (!this.activeRoomSubscriptions.has(member.roomId)) return;
       this.unsubscribeFromRoom(member.roomId);
     };
@@ -563,13 +567,18 @@ export class SlidingSyncManager {
     room.getUnfilteredTimelineSet().resetLiveTimeline();
 
     // Persist the tail of the timeline to IndexedDB asynchronously.
-    // If it fails, the events are still available from the server.
+    // On failure, evict the room from the store so the next open gets a clean
+    // server fetch rather than potentially stale cached data.
     this.persistRoomTimeline(
       roomId,
       events.map((e) => e.event as IRoomEvent),
       prevBatch
     ).catch((err: unknown) => {
-      debugLog.warn('timeline', 'Failed to persist pruned room timeline', { roomId, err });
+      debugLog.warn('timeline', 'Failed to persist pruned room timeline — evicting store cache', {
+        roomId,
+        err,
+      });
+      this.mx.store.removeRoom(roomId);
     });
 
     debugLog.info('timeline', 'Pruned room timeline from memory', {