fix: replace for...of with Array.from().forEach() to satisfy no-restricted-syntax

Author: Just-Insane

src/app/components/message/RenderBody.tsx

@@ -75,7 +75,11 @@ export function buildAbbrReplaceTextNode(
       <>
         {segments.map((seg) =>
           seg.termKey !== undefined ? (
-            <AbbreviationTerm key={seg.id} text={seg.text} definition={abbrMap.get(seg.termKey) ?? ''} />
+            <AbbreviationTerm
+              key={seg.id}
+              text={seg.text}
+              definition={abbrMap.get(seg.termKey) ?? ''}
+            />
           ) : (
             seg.text
           )
@@ -116,9 +120,7 @@ export function RenderBody({
           {segments.map((seg) => {
             if (seg.termKey !== undefined) {
               const definition = abbrMap.get(seg.termKey) ?? '';
-              return (
-                <AbbreviationTerm key={seg.id} text={seg.text} definition={definition} />
-              );
+              return <AbbreviationTerm key={seg.id} text={seg.text} definition={definition} />;
             }
             return (
               <Linkify key={seg.id} options={linkifyOpts}>

src/app/utils/abbreviations.test.ts

@@ -65,7 +65,9 @@ describe('splitByAbbreviations', () => {
   });
 
   it('returns a single plain segment when there are no matches', () => {
-    expect(splitByAbbreviations('hello world', map)).toEqual([{ id: 'txt-0', text: 'hello world' }]);
+    expect(splitByAbbreviations('hello world', map)).toEqual([
+      { id: 'txt-0', text: 'hello world' },
+    ]);
   });
 
   it('returns a single plain segment for an empty string', () => {
@@ -114,7 +116,9 @@ describe('splitByAbbreviations', () => {
   it('does not match a term that is a prefix of a longer word (word boundary)', () => {
     // OSS is in the map, but should not match inside FOSS because the F provides no boundary
     const ossOnlyMap = buildAbbreviationsMap([{ term: 'OSS', definition: 'Open Source Software' }]);
-    expect(splitByAbbreviations('FOSS rocks', ossOnlyMap)).toEqual([{ id: 'txt-0', text: 'FOSS rocks' }]);
+    expect(splitByAbbreviations('FOSS rocks', ossOnlyMap)).toEqual([
+      { id: 'txt-0', text: 'FOSS rocks' },
+    ]);
   });
 
   it('does not match a term embedded inside a longer word', () => {

src/app/utils/abbreviations.ts

@@ -44,14 +44,18 @@ export const splitByAbbreviations = (text: string, abbrMap: Map<string, string>)
   const segments: TextSegment[] = [];
   let lastIndex = 0;
 
-  for (const match of text.matchAll(pattern)) {
-    const matchIndex = match.index!;
+  Array.from(text.matchAll(pattern)).forEach((match) => {
+    const matchIndex = match.index;
     if (matchIndex > lastIndex) {
       segments.push({ id: `txt-${segments.length}`, text: text.slice(lastIndex, matchIndex) });
     }
-    segments.push({ id: `txt-${segments.length}`, text: match[0], termKey: match[0].toLowerCase() });
+    segments.push({
+      id: `txt-${segments.length}`,
+      text: match[0],
+      termKey: match[0].toLowerCase(),
+    });
     lastIndex = matchIndex + match[0].length;
-  }
+  });
 
   if (lastIndex < text.length) {
     segments.push({ id: `txt-${segments.length}`, text: text.slice(lastIndex) });