Merge pull request #160 from SafeExamBrowser/Remove-Home-And-Breadcrumb

Rad14nt · web-flow · commit a37997758f59 · 2026-06-15T13:34:08.000+02:00
Remove home and breadcrumb
diff --git a/client/src/components/layout/container/ContainerLayout.vue b/client/src/components/layout/container/ContainerLayout.vue
@@ -17,7 +17,6 @@
             :style="{ minHeight: 0 }"
         >
             <ContainerSidePanel
-                :home-route="homeRoute"
                 :is-navigation-overview-route="isNavigationOverviewRoute"
                 :links="mainNavigationLinks"
                 :navigation-overview-route="navigationOverviewRoute"
diff --git a/client/src/components/layout/container/ContainerSidePanel.vue b/client/src/components/layout/container/ContainerSidePanel.vue
@@ -15,9 +15,7 @@
             data-testid="layout-navOverview-toggle"
             :icon="isNavigationOverviewRoute ? 'mdi-close' : 'mdi-menu'"
             size="large"
-            :to="
-                isNavigationOverviewRoute ? homeRoute : navigationOverviewRoute
-            "
+            :to="navigationOverviewRoute"
             :variant="isNavigationOverviewRoute ? 'flat' : 'text'"
         />
 
@@ -57,7 +55,6 @@ defineProps<{
     links: BaseNavigationLink[];
     isNavigationOverviewRoute: boolean;
     navigationOverviewRoute: RouteLocationAsRelative;
-    homeRoute: RouteLocationAsRelative;
     ability: AbilityLike;
 }>();
 
diff --git a/client/src/components/layout/container/navigationLinks.ts b/client/src/components/layout/container/navigationLinks.ts
@@ -17,14 +17,6 @@ export function buildBaseNavigationLinks(
     i18n: I18nLike,
 ): BaseNavigationLink[] {
     const result: BaseNavigationLink[] = [];
-    if (ability.canView(GUIComponent.Home)) {
-        result.push({
-            title: i18n.t("titles.home"),
-            route: typedTo({ name: "/(app)/" }),
-            icon: "mdi-home",
-            testId: "layout-home-button",
-        });
-    }
 
     if (ability.canView(GUIComponent.Exams)) {
         result.push({
diff --git a/client/src/components/widgets/AddButton.vue b/client/src/components/widgets/AddButton.vue
@@ -9,10 +9,10 @@
             @click="handleClick"
         >
             <div class="d-flex align-center ga-2 pr-4 pl-2">
-                <v-icon size="25">mdi-plus</v-icon>
+                <v-icon size="25">{{ icon }}</v-icon>
 
                 <span class="text-title-medium" style="letter-spacing: normal">
-                    {{ $t("general.addButton") }}
+                    {{ label ?? $t("general.addButton") }}
                 </span>
             </div>
         </v-btn>
@@ -24,10 +24,20 @@ import { useRouter } from "vue-router";
 import type { RouteLocationAsRelative } from "vue-router";
 
 const router = useRouter();
-const props = defineProps<{
-    route?: RouteLocationAsRelative;
-    dataTestId?: string;
-}>();
+const props = withDefaults(
+    defineProps<{
+        route?: RouteLocationAsRelative;
+        dataTestId?: string;
+        label?: string;
+        icon?: string;
+    }>(),
+    {
+        route: undefined,
+        dataTestId: undefined,
+        label: undefined,
+        icon: "mdi-plus",
+    },
+);
 
 const emit = defineEmits<{
     (e: "click", event: MouseEvent): void;
diff --git a/client/src/components/widgets/breadCrumb/BreadCrumb.vue b/client/src/components/widgets/breadCrumb/BreadCrumb.vue
@@ -3,23 +3,13 @@
         aria-label="Breadcrumb"
         class="d-flex align-center flex-wrap ga-2 pl-5 text-body-medium"
     >
-        <v-hover v-slot="{ isHovering, props: hoverProps }">
-            <RouterLink
-                v-bind="hoverProps"
-                :to="{ name: '/(app)/' }"
-                :aria-label="$t('titles.home')"
-                class="d-inline-flex align-center text-decoration-none"
-                :class="isHovering ? 'text-primary' : 'text-medium-emphasis'"
-            >
-                <v-icon icon="mdi-home-outline" size="20" />
-            </RouterLink>
-        </v-hover>
-
         <template
             v-for="(item, index) in items"
             :key="`${item.label}-${index}`"
         >
-            <span aria-hidden="true" class="text-disabled">›</span>
+            <span v-if="index > 0" aria-hidden="true" class="text-disabled">
+                ›
+            </span>
 
             <v-hover
                 v-if="item.link"
diff --git a/client/src/components/widgets/homePageWidgets/HomePageInfo.vue b/client/src/components/widgets/homePageWidgets/HomePageInfo.vue
diff --git a/client/src/components/widgets/homePageWidgets/HomePageMain.vue b/client/src/components/widgets/homePageWidgets/HomePageMain.vue
diff --git a/client/src/i18n/locales/en.json b/client/src/i18n/locales/en.json
@@ -42,6 +42,7 @@
     "general": {
         "loadingText": "Loading... Please wait",
         "addButton": "Add",
+        "prepareButton": "Prepare",
         "cancelButton": "Cancel",
         "backButton": "Back",
         "nextButton": "Next",
@@ -2063,7 +2064,6 @@
         }
     },
     "titles": {
-        "home": "Home",
         "navigationOverview": "Navigation Overview",
         "exams": "Exams",
         "examsOverview": "Exams Overview",
diff --git a/client/src/pages/(app)/exam-template/index.vue b/client/src/pages/(app)/exam-template/index.vue
@@ -9,6 +9,13 @@
         :data-test-id="dataTestId"
         :panel-left-collapsed="!filtersOpen"
     >
+        <template #ActionButton>
+            <AddButton
+                :route="{ name: '/(app)/exam-template/create/' }"
+                :data-test-id="dataTestId"
+            />
+        </template>
+
         <template #PanelLeft>
             <SearchBar
                 v-model="list.searchInputValue"
@@ -73,6 +80,7 @@
 
 <script setup lang="ts">
 import BasicPage from "@/components/layout/pages/BasicPage.vue";
+import AddButton from "@/components/widgets/AddButton.vue";
 import SearchBar from "@/components/widgets/searches/SearchBar.vue";
 import EntityTable from "@/components/widgets/entity-table/EntityTable.vue";
 import FilterControlsRow from "@/components/widgets/filters/FilterControlsRow.vue";
diff --git a/client/src/pages/(app)/exam/index.vue b/client/src/pages/(app)/exam/index.vue
@@ -5,6 +5,15 @@
         :data-test-id="dataTestId"
         :panel-left-collapsed="!filtersOpen"
     >
+        <template #ActionButton>
+            <AddButton
+                :route="{ name: '/(app)/exam/create/' }"
+                :label="$t('general.prepareButton')"
+                icon="mdi-clipboard-edit-outline"
+                :data-test-id="dataTestId"
+            />
+        </template>
+
         <template #PanelLeft>
             <SearchBar
                 v-model="list.searchInputValue"
@@ -65,6 +74,7 @@
 
 <script setup lang="ts">
 import BasicPage from "@/components/layout/pages/BasicPage.vue";
+import AddButton from "@/components/widgets/AddButton.vue";
 import SearchBar from "@/components/widgets/searches/SearchBar.vue";
 import EntityTable from "@/components/widgets/entity-table/EntityTable.vue";
 import EnumChip from "@/components/widgets/EnumChip.vue";
diff --git a/client/src/pages/(app)/index.vue b/client/src/pages/(app)/index.vue
@@ -1,36 +1,20 @@
 <template>
-    <v-row data-testid="homepageContainer-page-container" class="w-100">
-        <v-col cols="12" data-testid="homepageContainer-root-col">
-            <!-- Infos -->
-            <v-row data-testid="homepageContainer-info-section">
-                <v-col cols="12" data-testid="homepageContainer-info-col">
-                    <HomePageInfo
-                        data-testid="homepageContainer-homePageInfo-component"
-                    />
-                </v-col>
-            </v-row>
-
-            <!-- Main -->
-            <v-row
-                class="mt-5 align-stretch"
-                data-testid="homepageContainer-main-section"
-            >
-                <HomePageMain
-                    data-testid="homepageContainer-homePageMain-component"
-                />
-            </v-row>
-        </v-col>
-    </v-row>
+    <div></div>
 </template>
 
 <script setup lang="ts">
-import HomePageInfo from "@/components/widgets/homePageWidgets/HomePageInfo.vue";
-import HomePageMain from "@/components/widgets/homePageWidgets/HomePageMain.vue";
+import { onBeforeMount } from "vue";
+import { useRouter } from "vue-router";
+import { useUserAccountStore } from "@/stores/authentication/userAccountStore.ts";
+import { getLandingRoute } from "@/router/getLandingRoute.ts";
+
+// The former home page is now a role-based landing redirect. The auth guard
+// has already hydrated the user account (and its roles) before this mounts.
+const router = useRouter();
+const userAccountStore = useUserAccountStore();
 
-definePage({
-    meta: {
-        titleKey: "titles.home",
-        pageTestId: "home-page",
-    },
+onBeforeMount(() => {
+    const userRoles = userAccountStore.userAccount?.userRoles ?? [];
+    void router.replace(getLandingRoute(userRoles));
 });
 </script>
diff --git a/client/src/router/getLandingRoute.ts b/client/src/router/getLandingRoute.ts
@@ -0,0 +1,28 @@
+import type { RouteLocationAsRelative } from "vue-router";
+import { typedTo } from "@/router/typedTo.ts";
+import { UserRoleEnum } from "@/models/userRoleEnum.ts";
+
+// Role-based landing after login. Highest role wins:
+// admins land on the navigation overview, exam admins on the exams list,
+// supervisors and teachers on monitoring.
+export function getLandingRoute(userRoles: string[]): RouteLocationAsRelative {
+    if (
+        userRoles.includes(UserRoleEnum.SEB_SERVER_ADMIN) ||
+        userRoles.includes(UserRoleEnum.INSTITUTIONAL_ADMIN)
+    ) {
+        return typedTo({ name: "/(app)/navigation-overview/" });
+    }
+
+    if (userRoles.includes(UserRoleEnum.EXAM_ADMIN)) {
+        return typedTo({ name: "/(app)/exam/" });
+    }
+
+    if (
+        userRoles.includes(UserRoleEnum.EXAM_SUPPORTER) ||
+        userRoles.includes(UserRoleEnum.TEACHER)
+    ) {
+        return typedTo({ name: "/(app)/monitoring/" });
+    }
+
+    return typedTo({ name: "/(app)/navigation-overview/" });
+}
diff --git a/github/deploy-auto-testing.sh b/github/deploy-auto-testing.sh
@@ -5,7 +5,7 @@ set -e
 # Go to repo root (parent of the github folder)
 cd "$(dirname "$0")/.."
 
-TAG_NAME="auto-testing-deploy"
+TAG_NAME="sprint-testing"
 
 echo "Deleting local tag..."
 git tag -d $TAG_NAME 2>/dev/null || true

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`:style="{ minHeight: 0 }"`
`18`	`18`	`>`
`19`	`19`	`<ContainerSidePanel`
`20`		`- :home-route="homeRoute"`
`21`	`20`	`:is-navigation-overview-route="isNavigationOverviewRoute"`
`22`	`21`	`:links="mainNavigationLinks"`
`23`	`22`	`:navigation-overview-route="navigationOverviewRoute"`