SEBWIN-686: Extended unit test coverage for runtime component.

Author: dbuechel

SafeExamBrowser.Runtime.UnitTests/Operations/Session/ServerOperationTests.cs

@@ -10,7 +10,9 @@
 using System.Collections.Generic;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Moq;
+using SafeExamBrowser.Communication.Contracts.Events;
 using SafeExamBrowser.Communication.Contracts.Hosts;
+using SafeExamBrowser.Communication.Contracts.Proxies;
 using SafeExamBrowser.Configuration.Contracts;
 using SafeExamBrowser.Configuration.Contracts.Cryptography;
 using SafeExamBrowser.Core.Contracts.OperationModel;
@@ -21,6 +23,7 @@
 using SafeExamBrowser.Server.Contracts;
 using SafeExamBrowser.Server.Contracts.Data;
 using SafeExamBrowser.Settings;
+using SafeExamBrowser.Settings.Security;
 using SafeExamBrowser.Settings.Server;
 using SafeExamBrowser.SystemComponents.Contracts;
 using SafeExamBrowser.UserInterface.Contracts;
@@ -33,9 +36,12 @@ namespace SafeExamBrowser.Runtime.UnitTests.Operations.Session
 	[TestClass]
 	public class ServerOperationTests
 	{
+		private Mock<ClientBridge> clientBridge;
+		private Mock<IClientProxy> clientProxy;
 		private RuntimeContext context;
 		private Mock<IFileSystem> fileSystem;
 		private Mock<IConfigurationRepository> repository;
+		private Mock<IRuntimeHost> runtimeHost;
 		private Mock<IServerProxy> server;
 		private Mock<IUserInterfaceFactory> uiFactory;
 
@@ -45,11 +51,15 @@ public class ServerOperationTests
 		public void Initialize()
 		{
 			context = new RuntimeContext();
+			clientProxy = new Mock<IClientProxy>();
 			fileSystem = new Mock<IFileSystem>();
 			repository = new Mock<IConfigurationRepository>();
+			runtimeHost = new Mock<IRuntimeHost>();
 			server = new Mock<IServerProxy>();
 			uiFactory = new Mock<IUserInterfaceFactory>();
+			clientBridge = new Mock<ClientBridge>(runtimeHost.Object, context);
 
+			context.ClientProxy = clientProxy.Object;
 			context.Current = new SessionConfiguration();
 			context.Current.AppConfig = new AppConfig();
 			context.Current.Settings = new AppSettings();
@@ -58,7 +68,7 @@ public void Initialize()
 			context.Next.Settings = new AppSettings();
 
 			var dependencies = new Dependencies(
-				new ClientBridge(Mock.Of<IRuntimeHost>(), context),
+				clientBridge.Object,
 				Mock.Of<ILogger>(),
 				Mock.Of<IMessageBox>(),
 				Mock.Of<IRuntimeWindow>(),
@@ -178,7 +188,7 @@ public void Perform_MustFailIfSettingsCouldNotBeLoaded()
 		}
 
 		[TestMethod]
-		public void Perform_MustCorrectlyAbort()
+		public void Perform_MustCorrectlyAbortWithReturnValue()
 		{
 			var connection = new ConnectionInfo { Api = "some API", ConnectionToken = "some token", Oauth2Token = "some OAuth2 token" };
 			var exam = new Exam { Id = "some id", LmsName = "some LMS", Name = "some name", Url = "some URL" };
@@ -215,6 +225,33 @@ public void Perform_MustCorrectlyAbort()
 			Assert.AreEqual(OperationResult.Aborted, result);
 		}
 
+		[TestMethod]
+		public void Perform_MustCorrectlyAbortWithoutReturnValue()
+		{
+			var messageShown = false;
+			var serverDialog = new Mock<IServerFailureDialog>();
+
+			context.Next.Settings.SessionMode = SessionMode.Server;
+			server.Setup(s => s.Connect()).Returns(new ServerResponse(false));
+			serverDialog
+				.Setup(d => d.Show(It.IsAny<IWindow>()))
+				.Returns(new ServerFailureDialogResult { Abort = true })
+				.Callback(() => messageShown = true);
+			uiFactory.Setup(f => f.CreateServerFailureDialog(It.IsAny<string>(), It.IsAny<bool>())).Returns(serverDialog.Object);
+
+			var result = sut.Perform();
+
+			fileSystem.Verify(f => f.Delete(It.IsAny<string>()), Times.Never);
+			server.Verify(s => s.Connect(), Times.Once);
+			server.Verify(s => s.Initialize(It.IsAny<ServerSettings>()), Times.Once);
+			server.Verify(s => s.GetAvailableExams(It.IsAny<string>()), Times.Never);
+			server.Verify(s => s.GetConfigurationFor(It.IsAny<Exam>()), Times.Never);
+			server.Verify(s => s.GetConnectionInfo(), Times.Never);
+
+			Assert.IsTrue(messageShown);
+			Assert.AreEqual(OperationResult.Aborted, result);
+		}
+
 		[TestMethod]
 		public void Perform_MustCorrectlyFallback()
 		{
@@ -254,6 +291,47 @@ public void Perform_MustCorrectlyFallback()
 			Assert.AreEqual(OperationResult.Success, result);
 		}
 
+		[TestMethod]
+		public void Perform_MustCorrectlyRetry()
+		{
+			const int RETRIES = 5;
+
+			var connection = new ConnectionInfo { Api = "some API", ConnectionToken = "some token", Oauth2Token = "some OAuth2 token" };
+			var count = 0;
+			var exam = new Exam { Id = "some id", LmsName = "some LMS", Name = "some name", Url = "some URL" };
+			var examDialog = new Mock<IExamSelectionDialog>();
+			var examSettings = new AppSettings();
+			var messageShown = false;
+			var serverDialog = new Mock<IServerFailureDialog>();
+
+			examDialog.Setup(d => d.Show(It.IsAny<IWindow>())).Returns(new ExamSelectionDialogResult { SelectedExam = exam, Success = true });
+			repository.Setup(c => c.TryLoadSettings(It.IsAny<Uri>(), out examSettings, It.IsAny<PasswordParameters>())).Returns(LoadStatus.Success);
+			context.Next.Settings.SessionMode = SessionMode.Server;
+			server.Setup(s => s.Connect()).Returns(new ServerResponse(true));
+			server.Setup(s => s.Initialize(It.IsAny<ServerSettings>()));
+			server.Setup(s => s.GetConnectionInfo()).Returns(connection);
+			server.Setup(s => s.GetAvailableExams(It.IsAny<string>())).Returns(new ServerResponse<IEnumerable<Exam>>(true, default));
+			server.Setup(s => s.GetConfigurationFor(It.IsAny<Exam>())).Returns(new ServerResponse<Uri>(false, default));
+			serverDialog
+				.Setup(d => d.Show(It.IsAny<IWindow>()))
+				.Returns(() => new ServerFailureDialogResult { Retry = ++count < RETRIES })
+				.Callback(() => messageShown = true);
+			uiFactory.Setup(f => f.CreateExamSelectionDialog(It.IsAny<IEnumerable<Exam>>())).Returns(examDialog.Object);
+			uiFactory.Setup(f => f.CreateServerFailureDialog(It.IsAny<string>(), It.IsAny<bool>())).Returns(serverDialog.Object);
+
+			var result = sut.Perform();
+
+			fileSystem.Verify(f => f.Delete(It.IsAny<string>()), Times.Never);
+			server.Verify(s => s.Connect(), Times.Once);
+			server.Verify(s => s.Initialize(It.IsAny<ServerSettings>()), Times.Once);
+			server.Verify(s => s.GetAvailableExams(It.IsAny<string>()), Times.Once);
+			server.Verify(s => s.GetConfigurationFor(It.Is<Exam>(e => e == exam)), Times.Exactly(RETRIES));
+			server.Verify(s => s.GetConnectionInfo(), Times.Never);
+
+			Assert.IsTrue(messageShown);
+			Assert.AreEqual(OperationResult.Aborted, result);
+		}
+
 		[TestMethod]
 		public void Perform_MustAutomaticallySelectExam()
 		{
@@ -341,7 +419,74 @@ public void Perform_MustSetCustomBrowserExamKey()
 
 			Assert.AreEqual(browserExamKey, context.Next.Settings.Browser.CustomBrowserExamKey);
 			Assert.AreEqual(OperationResult.Success, result);
+		}
+
+		[TestMethod]
+		public void Perform_MustUseClientBridgeForExamSelectionIfRequired()
+		{
+			var connection = new ConnectionInfo { Api = "some API", ConnectionToken = "some token", Oauth2Token = "some OAuth2 token" };
+			var examSettings = new AppSettings();
+
+			clientProxy
+				.Setup(p => p.RequestExamSelection(It.IsAny<IEnumerable<(string, string, string, string)>>(), It.IsAny<Guid>()))
+				.Returns(new CommunicationResult(true))
+				.Callback<IEnumerable<(string, string, string, string)>, Guid>((exams, id) =>
+				{
+					runtimeHost.Raise(r => r.ExamSelectionReceived += default, new ExamSelectionReplyEventArgs() { RequestId = id, Success = true });
+				});
+			context.Current.Settings.Security.KioskMode = KioskMode.CreateNewDesktop;
+			context.Next.Settings.SessionMode = SessionMode.Server;
+			repository.Setup(c => c.TryLoadSettings(It.IsAny<Uri>(), out examSettings, It.IsAny<PasswordParameters>())).Returns(LoadStatus.Success);
+			server.Setup(s => s.Connect()).Returns(new ServerResponse(true));
+			server.Setup(s => s.Initialize(It.IsAny<ServerSettings>()));
+			server.Setup(s => s.GetConnectionInfo()).Returns(connection);
+			server.Setup(s => s.GetAvailableExams(It.IsAny<string>())).Returns(new ServerResponse<IEnumerable<Exam>>(true, new[] { new Exam() }));
+			server.Setup(s => s.GetConfigurationFor(It.IsAny<Exam>())).Returns(new ServerResponse<Uri>(true, new Uri("file:///configuration.seb")));
+			server.Setup(s => s.SendSelectedExam(It.IsAny<Exam>())).Returns(new ServerResponse<string>(true, default));
+
+			var result = sut.Perform();
+
+			clientProxy.Verify(p => p.RequestExamSelection(It.IsAny<IEnumerable<(string, string, string, string)>>(), It.IsAny<Guid>()), Times.Once);
+			uiFactory.VerifyNoOtherCalls();
 
+			Assert.AreEqual(OperationResult.Success, result);
+		}
+
+		[TestMethod]
+		public void Perform_MustUseClientBridgeForFailureActionIfRequired()
+		{
+			var connection = new ConnectionInfo { Api = "some API", ConnectionToken = "some token", Oauth2Token = "some OAuth2 token" };
+			var examSettings = new AppSettings();
+
+			clientProxy
+				.Setup(p => p.RequestExamSelection(It.IsAny<IEnumerable<(string, string, string, string)>>(), It.IsAny<Guid>()))
+				.Returns(new CommunicationResult(true))
+				.Callback<IEnumerable<(string, string, string, string)>, Guid>((exams, id) =>
+				{
+					runtimeHost.Raise(r => r.ExamSelectionReceived += default, new ExamSelectionReplyEventArgs() { RequestId = id, Success = true });
+				});
+			clientProxy
+				.Setup(p => p.RequestServerFailureAction(It.IsAny<string>(), It.IsAny<bool>(), It.IsAny<Guid>()))
+				.Returns(new CommunicationResult(true))
+				.Callback<string, bool, Guid>((m, f, id) =>
+				{
+					runtimeHost.Raise(r => r.ServerFailureActionReceived += default, new ServerFailureActionReplyEventArgs() { RequestId = id, Fallback = true });
+				});
+			context.Current.Settings.Security.KioskMode = KioskMode.CreateNewDesktop;
+			context.Next.Settings.SessionMode = SessionMode.Server;
+			repository.Setup(c => c.TryLoadSettings(It.IsAny<Uri>(), out examSettings, It.IsAny<PasswordParameters>())).Returns(LoadStatus.Success);
+			server.Setup(s => s.Connect()).Returns(new ServerResponse(true));
+			server.Setup(s => s.Initialize(It.IsAny<ServerSettings>()));
+			server.Setup(s => s.GetConnectionInfo()).Returns(connection);
+			server.Setup(s => s.GetAvailableExams(It.IsAny<string>())).Returns(new ServerResponse<IEnumerable<Exam>>(true, new[] { new Exam() }));
+			server.Setup(s => s.GetConfigurationFor(It.IsAny<Exam>())).Returns(new ServerResponse<Uri>(false, default));
+
+			var result = sut.Perform();
+
+			clientProxy.Verify(p => p.RequestServerFailureAction(It.IsAny<string>(), It.IsAny<bool>(), It.IsAny<Guid>()), Times.Once);
+			uiFactory.VerifyNoOtherCalls();
+
+			Assert.AreEqual(OperationResult.Success, result);
 		}
 
 		[TestMethod]
@@ -414,6 +559,21 @@ public void Repeat_MustCorrectlyInitializeServerSession()
 			Assert.AreEqual(SessionMode.Server, context.Next.Settings.SessionMode);
 		}
 
+		[TestMethod]
+		public void Repeat_MustCorrectlyFinalizeServerSession()
+		{
+			context.Current.Settings.SessionMode = SessionMode.Server;
+			context.Next.Settings.SessionMode = SessionMode.Normal;
+			server.Setup(s => s.Disconnect()).Returns(new ServerResponse(true));
+
+			var result = sut.Repeat();
+
+			fileSystem.VerifyNoOtherCalls();
+			server.Verify(s => s.Disconnect(), Times.Once);
+
+			Assert.AreEqual(OperationResult.Success, result);
+		}
+
 		[TestMethod]
 		public void Repeat_MustFailIfSettingsCouldNotBeLoaded()
 		{

SafeExamBrowser.Runtime/Operations/Session/ServerOperation.cs

@@ -270,7 +270,7 @@ private void AskForServerFailureAction(string message, out bool abort, out bool
 				var dialog = uiFactory.CreateServerFailureDialog(message, showFallback);
 				var result = dialog.Show(RuntimeWindow);
 
-				abort = result.Abort;
+				abort = result.Abort || !result.Success;
 				fallback = result.Fallback;
 				retry = result.Retry;
 			}