Skip to content

Commit 4d850bb

Browse files
Sage HartSage Hart
authored andcommitted
fix(deps): better-sqlite3 11 → 12 (Node 26 install fix)
better-sqlite3@11 has no prebuilt binary for Node 26, so npm install fell back to a node-gyp compile that fails against Node 26's V8 (GetPrototype / GetIsolate / PropertyCallbackInfo::This removed). Users on current Node could not install the project at all. @12.11.1 ships prebuilt binaries for Node 20.x–26.x, so install just downloads the matching binary — no compiler, no failure. Verified: fresh clone + @12 passes the full 38-test suite on both Node 22 and Node 26. - package.json: better-sqlite3 ^11 → ^12 - ci.yml: add Node 24 to the matrix (now 20/22/24) - README: Node-version troubleshooting note - .nvmrc: pin recommended Node 22 LTS
1 parent 629973a commit 4d850bb

5 files changed

Lines changed: 15 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
strategy:
3232
fail-fast: false
3333
matrix:
34-
node-version: [20, 22]
34+
node-version: [20, 22, 24]
3535
steps:
3636
- uses: actions/checkout@v7
3737
- name: Use Node.js ${{ matrix.node-version }}

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
22

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ npm run dev # boot the server + dashboard on $PORT or 3000
6767

6868
Open `http://localhost:3000/`. With no key set, agents run in **simulation** — click **▶ Run demo** to watch a curated 5-agent scenario auto-play through real approval gates.
6969

70+
> **Node version:** requires Node 20+ (verified through Node 26). If `npm install`
71+
> fails while compiling `better-sqlite3` (a V8-API error from node-gyp), you're on
72+
> an unsupported Node — use Node 22 LTS. On supported versions the install uses a
73+
> prebuilt binary, so no compiler is needed.
74+
7075
### Live demo (one-click deploy)
7176

7277
No clone required — run the control plane in the cloud in simulation mode, then

package-lock.json

Lines changed: 7 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"test:watch": "vitest"
4343
},
4444
"dependencies": {
45-
"better-sqlite3": "^11.3.0",
45+
"better-sqlite3": "^12.11.1",
4646
"express": "^5.2.1",
4747
"nanoid": "^5.0.7",
4848
"ws": "^8.18.0",

0 commit comments

Comments
 (0)