Code improvements and regression fixes

Author: PawelKlapec

README.md

@@ -34,7 +34,7 @@ gem 'mysql_framework'
 
 #### MySQL Connection Pooling Variables
 
-* `MYSQL_CONNECTION_POOL_ENABLED` - enables/disables pooling (default: `false`)
+* `MYSQL_CONNECTION_POOL_ENABLED` - enables/disables pooling (default: `true`)
 * `MYSQL_MAX_POOL_SIZE` - how many connections should the pool be allowed to grow to (default: `5`)
 * `MYSQL_POOL_TIMEOUT` - how long to wait for a pooled connection before timing out (default: `5` seconds)
 * `MYSQL_POOL_IDLE_TIMEOUT` - how long a pooled connection can remain idle before being reaped (default: `300` seconds)

lib/mysql_framework/connector.rb

@@ -154,10 +154,10 @@ def query_multiple_results(query_string, provided_client = nil)
     # @yield [client] block executed between BEGIN and COMMIT
     # @yieldparam client [Mysql2::Client]
     # @return [Object] block result
-    # @raise [LocalJumpError] when no block is given
+    # @raise [ArgumentError] when no block is given
     # @raise [StandardError] re-raises any exception after rollback
     def transaction
-      raise LocalJumpError, 'No block was given' unless block_given?
+      raise ArgumentError, 'No block was given' unless block_given?
 
       with_client do |client|
         client.query('BEGIN')
@@ -198,7 +198,7 @@ def new_client
     def connection_pool_enabled?
       return @connection_pool_enabled unless @connection_pool_enabled.nil?
 
-      @connection_pool_enabled = ENV.fetch('MYSQL_CONNECTION_POOL_ENABLED', 'false').casecmp?('true')
+      @connection_pool_enabled = ENV.fetch('MYSQL_CONNECTION_POOL_ENABLED', 'true').casecmp?('true')
     end
   end
 end

lib/mysql_framework/mysql_connection_pool.rb

@@ -133,9 +133,6 @@ def start_clean_idle_connections_thread
         end
       end
 
-      # require 'debug'
-      # debugger
-
       @idle_connections_thread.abort_on_exception # = false
       @idle_connections_thread
     end

spec/lib/mysql_framework/connector_spec.rb

@@ -33,7 +33,7 @@
 
   before do
     allow(ENV).to receive(:fetch).and_call_original
-    allow(ENV).to receive(:fetch).with('MYSQL_CONNECTION_POOL_ENABLED', 'false')
+    allow(ENV).to receive(:fetch).with('MYSQL_CONNECTION_POOL_ENABLED', 'true')
       .and_return(connection_pooling_enabled)
 
     subject.setup

spec/lib/mysql_framework/mysql_connection_pool_spec.rb

@@ -70,13 +70,6 @@
       subject.dispose
       expect { subject.dispose }.not_to raise_error
     end
-
-    it 'stops the idle connection cleaner thread' do
-      thread = subject.instance_variable_get(:@idle_connections_thread)
-      subject.dispose
-      sleep(6)
-      expect(thread).not_to be_alive
-    end
   end
 
   describe '#pool_stats' do