Skip to content

Commit 492f8cb

Browse files
committed
Remove memory limit settings
1 parent d897054 commit 492f8cb

9 files changed

Lines changed: 0 additions & 79 deletions

File tree

app/src/main/java/io/nekohasekai/sfa/bg/BoxService.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ class BoxService(private val service: Service, private val platformInterface: Pl
131131
}
132132

133133
DefaultNetworkMonitor.start()
134-
Libbox.setMemoryLimit(!Settings.disableMemoryLimit)
135134

136135
try {
137136
commandServer.startOrReloadService(

app/src/main/java/io/nekohasekai/sfa/compose/screen/settings/ServiceSettingsScreen.kt

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -16,50 +16,37 @@ import androidx.compose.foundation.layout.fillMaxWidth
1616
import androidx.compose.foundation.layout.height
1717
import androidx.compose.foundation.layout.padding
1818
import androidx.compose.foundation.rememberScrollState
19-
import androidx.compose.foundation.shape.RoundedCornerShape
2019
import androidx.compose.foundation.verticalScroll
2120
import androidx.compose.material.icons.Icons
2221
import androidx.compose.material.icons.automirrored.filled.ArrowBack
2322
import androidx.compose.material.icons.outlined.BatteryChargingFull
24-
import androidx.compose.material.icons.outlined.Memory
2523
import androidx.compose.material3.Button
2624
import androidx.compose.material3.Card
2725
import androidx.compose.material3.CardDefaults
2826
import androidx.compose.material3.ExperimentalMaterial3Api
2927
import androidx.compose.material3.Icon
3028
import androidx.compose.material3.IconButton
31-
import androidx.compose.material3.ListItem
32-
import androidx.compose.material3.ListItemDefaults
3329
import androidx.compose.material3.MaterialTheme
3430
import androidx.compose.material3.OutlinedButton
35-
import androidx.compose.material3.Switch
3631
import androidx.compose.material3.Text
3732
import androidx.compose.material3.TopAppBar
3833
import androidx.compose.runtime.Composable
3934
import androidx.compose.runtime.LaunchedEffect
4035
import androidx.compose.runtime.getValue
4136
import androidx.compose.runtime.mutableStateOf
4237
import androidx.compose.runtime.remember
43-
import androidx.compose.runtime.rememberCoroutineScope
4438
import androidx.compose.runtime.setValue
4539
import androidx.compose.ui.Alignment
4640
import androidx.compose.ui.Modifier
47-
import androidx.compose.ui.draw.clip
48-
import androidx.compose.ui.graphics.Color
4941
import androidx.compose.ui.platform.LocalContext
5042
import androidx.compose.ui.res.stringResource
5143
import androidx.compose.ui.text.font.FontWeight
5244
import androidx.compose.ui.unit.dp
5345
import androidx.navigation.NavController
5446
import io.nekohasekai.sfa.R
5547
import io.nekohasekai.sfa.bg.ServiceConnection
56-
import io.nekohasekai.sfa.compose.base.GlobalEventBus
57-
import io.nekohasekai.sfa.compose.base.UiEvent
5848
import io.nekohasekai.sfa.compose.topbar.OverrideTopBar
59-
import io.nekohasekai.sfa.database.Settings
6049
import io.nekohasekai.sfa.ktx.launchCustomTab
61-
import kotlinx.coroutines.Dispatchers
62-
import kotlinx.coroutines.launch
6350

6451
@OptIn(ExperimentalMaterial3Api::class)
6552
@Composable
@@ -79,11 +66,8 @@ fun ServiceSettingsScreen(navController: NavController, serviceConnection: Servi
7966
}
8067

8168
val context = LocalContext.current
82-
val scope = rememberCoroutineScope()
8369
// Check battery optimization status
8470
var isBatteryOptimizationIgnored by remember { mutableStateOf(false) }
85-
var ignoreMemoryLimit by remember { mutableStateOf(Settings.disableMemoryLimit) }
86-
8771
// Activity result launcher for battery optimization permission
8872
val requestBatteryOptimizationLauncher =
8973
rememberLauncherForActivityResult(
@@ -187,56 +171,6 @@ fun ServiceSettingsScreen(navController: NavController, serviceConnection: Servi
187171
}
188172
}
189173

190-
// Options Section
191-
Card(
192-
modifier =
193-
Modifier
194-
.fillMaxWidth()
195-
.padding(horizontal = 16.dp),
196-
colors =
197-
CardDefaults.cardColors(
198-
containerColor = MaterialTheme.colorScheme.surfaceContainer,
199-
),
200-
) {
201-
ListItem(
202-
headlineContent = {
203-
Text(
204-
stringResource(R.string.ignore_memory_limit),
205-
style = MaterialTheme.typography.bodyLarge,
206-
)
207-
},
208-
supportingContent = {
209-
Text(
210-
stringResource(R.string.ignore_memory_limit_description),
211-
style = MaterialTheme.typography.bodyMedium,
212-
color = MaterialTheme.colorScheme.onSurfaceVariant,
213-
modifier = Modifier.padding(top = 4.dp),
214-
)
215-
},
216-
leadingContent = {
217-
Icon(
218-
imageVector = Icons.Outlined.Memory,
219-
contentDescription = null,
220-
tint = MaterialTheme.colorScheme.primary,
221-
)
222-
},
223-
trailingContent = {
224-
Switch(checked = ignoreMemoryLimit, onCheckedChange = { checked ->
225-
ignoreMemoryLimit = checked
226-
scope.launch(Dispatchers.IO) {
227-
Settings.disableMemoryLimit = checked
228-
GlobalEventBus.tryEmit(UiEvent.RestartToTakeEffect)
229-
}
230-
})
231-
},
232-
modifier = Modifier.clip(RoundedCornerShape(12.dp)),
233-
colors =
234-
ListItemDefaults.colors(
235-
containerColor = Color.Transparent,
236-
),
237-
)
238-
}
239-
240174
Spacer(modifier = Modifier.height(16.dp))
241175
}
242176
}

app/src/main/java/io/nekohasekai/sfa/constant/SettingsKey.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ object SettingsKey {
99
const val SILENT_INSTALL_ENABLED = "silent_install_enabled"
1010
const val SILENT_INSTALL_METHOD = "silent_install_method"
1111
const val AUTO_UPDATE_ENABLED = "auto_update_enabled"
12-
const val DISABLE_MEMORY_LIMIT = "disable_memory_limit"
1312
const val DYNAMIC_NOTIFICATION = "dynamic_notification"
1413
const val DISABLE_DEPRECATED_WARNINGS = "disable_deprecated_warnings"
1514

app/src/main/java/io/nekohasekai/sfa/database/Settings.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ object Settings {
6363
}
6464
}
6565
var autoUpdateEnabled by dataStore.boolean(SettingsKey.AUTO_UPDATE_ENABLED) { false }
66-
var disableMemoryLimit by dataStore.boolean(SettingsKey.DISABLE_MEMORY_LIMIT)
6766
var dynamicNotification by dataStore.boolean(SettingsKey.DYNAMIC_NOTIFICATION) { true }
6867
var disableDeprecatedWarnings by dataStore.boolean(SettingsKey.DISABLE_DEPRECATED_WARNINGS) { false }
6968

app/src/main/res/values-fa/strings.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@
199199
<string name="sponsor">حامی مالی</string>
200200
<string name="working_directory">پوشه کاری</string>
201201
<string name="disable_deprecated_warnings">غیرفعال‌کردن هشدارهای منسوخ</string>
202-
<string name="ignore_memory_limit">نادیده گرفتن محدودیت حافظه</string>
203-
<string name="ignore_memory_limit_description">محدودیت حافظه روی sing-box اعمال نشود.</string>
204202
<string name="notification_settings">اعلان‌ها</string>
205203
<string name="enable_notification">فعال‌کردن اعلان</string>
206204
<string name="dynamic_notification">نمایش سرعت بلادرنگ در اعلان</string>

app/src/main/res/values-ru-rRU/strings.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@
199199
<string name="sponsor">Поддержать</string>
200200
<string name="working_directory">Рабочая директория</string>
201201
<string name="disable_deprecated_warnings">Отключить предупреждения об устаревании</string>
202-
<string name="ignore_memory_limit">Игнорировать ограничение памяти</string>
203-
<string name="ignore_memory_limit_description">Не применять ограничения по памяти для sing-box.</string>
204202
<string name="notification_settings">Уведомления</string>
205203
<string name="enable_notification">Включить уведомления</string>
206204
<string name="dynamic_notification">Отображать скорость в реальном времени в уведомлении</string>

app/src/main/res/values-zh-rCN/strings.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@
199199
<string name="sponsor">赞助</string>
200200
<string name="working_directory">工作目录</string>
201201
<string name="disable_deprecated_warnings">禁用弃用警告</string>
202-
<string name="ignore_memory_limit">忽略内存限制</string>
203-
<string name="ignore_memory_limit_description">不对 sing-box 强制执行内存限制。</string>
204202
<string name="notification_settings">通知</string>
205203
<string name="enable_notification">启用通知</string>
206204
<string name="dynamic_notification">在通知中显示实时网速</string>

app/src/main/res/values-zh-rTW/strings.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@
199199
<string name="sponsor">贊助</string>
200200
<string name="working_directory">工作目錄</string>
201201
<string name="disable_deprecated_warnings">停用過時警告</string>
202-
<string name="ignore_memory_limit">忽略記憶體限制</string>
203-
<string name="ignore_memory_limit_description">不對 sing-box 強制執行記憶體限制。</string>
204202
<string name="notification_settings">通知</string>
205203
<string name="enable_notification">啟用通知</string>
206204
<string name="dynamic_notification">在通知中顯示即時網速</string>

app/src/main/res/values/strings.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,6 @@
199199
<string name="sponsor">Sponsor</string>
200200
<string name="working_directory">Working Directory</string>
201201
<string name="disable_deprecated_warnings">Disable Deprecated Warnings</string>
202-
<string name="ignore_memory_limit">Ignore Memory Limit</string>
203-
<string name="ignore_memory_limit_description">Do not enforce memory limits on sing-box.</string>
204202
<string name="notification_settings">Notification</string>
205203
<string name="enable_notification">Enable Notification</string>
206204
<string name="dynamic_notification">Display realtime speed in notification</string>

0 commit comments

Comments
 (0)