fix(vless): dereference packet_encoding in error message to avoid panic#4094
Open
Leadaxe wants to merge 67 commits into
Open
fix(vless): dereference packet_encoding in error message to avoid panic#4094Leadaxe wants to merge 67 commits into
Leadaxe wants to merge 67 commits into
Conversation
`SecTrustEvaluateWithError` is serial
This reverts commit 62cb06c.
nekohasekai
force-pushed
the
testing
branch
8 times, most recently
from
41d2e8c to
812a8fd
Compare
nekohasekai
force-pushed
the
testing
branch
4 times, most recently
from
4de2400 to
ba2d6c6
Compare
nekohasekai
force-pushed
the
testing
branch
2 times, most recently
from
83b7304 to
8a42af3
Compare
nekohasekai
force-pushed
the
testing
branch
12 times, most recently
from
8ea55ff to
a9fe3f3
Compare
nekohasekai
force-pushed
the
testing
branch
4 times, most recently
from
f7ca395 to
f27d0e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4093.
protocol/vless/outbound.go:86passedoptions.PacketEncoding(a*string) toE.New.common/format.ToStringhas no case for pointer types, so the call panicked instead of returning the intended error. Adding the dereference makes the path produce a normalFATAL initialize outbound[0]: unknown packet encoding: <value>, matching what the analogous VMess code atprotocol/vmess/outbound.go:81already emits (wherePacketEncodingis a plainstring).Verified locally: with the patch applied,
sing-box check -c <config-with-packet_encoding-none>returns the FATAL line and exits 1, instead ofpanic: unknown value+ stack trace.Diff is one character.