fix(vless): dereference packet_encoding in error message to avoid panic#4094
Open
Leadaxe wants to merge 1 commit intoSagerNet:testingfrom
Open
fix(vless): dereference packet_encoding in error message to avoid panic#4094Leadaxe wants to merge 1 commit intoSagerNet:testingfrom
Leadaxe wants to merge 1 commit intoSagerNet:testingfrom
Conversation
`*string` was passed to E.New without dereferencing. format.ToString
has no pointer case, so the intended error became a panic("unknown value"),
crashing the whole process when packet_encoding had an invalid value.
The switch one line above already dereferences; matching that here makes
the call return a normal error like the analogous VMess path does.
Fixes SagerNet#4093.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4093.
protocol/vless/outbound.go:86passedoptions.PacketEncoding(a*string) toE.New.common/format.ToStringhas no case for pointer types, so the call panicked instead of returning the intended error. Adding the dereference makes the path produce a normalFATAL initialize outbound[0]: unknown packet encoding: <value>, matching what the analogous VMess code atprotocol/vmess/outbound.go:81already emits (wherePacketEncodingis a plainstring).Verified locally: with the patch applied,
sing-box check -c <config-with-packet_encoding-none>returns the FATAL line and exits 1, instead ofpanic: unknown value+ stack trace.Diff is one character.