cmd/check: ignore checked config log options#4097
Open
ilachev wants to merge 1 commit intoSagerNet:testingfrom
Open
cmd/check: ignore checked config log options#4097ilachev wants to merge 1 commit intoSagerNet:testingfrom
ilachev wants to merge 1 commit intoSagerNet:testingfrom
Conversation
ilachev
force-pushed
the
fix/check-ignore-config-log-3927
branch
from
ee3d654 to
9da0746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3927
sing-box checkshould not applylogsettings from target config.Changes:
checkpath to use disabled runtime loggerValidation:
go test ./cmd/sing-boxlog.level=traceno longer prints shutdown trace lines duringcheck