selector: avoid nil deref when no outbound is selected#4102
Open
SAY-5 wants to merge 2 commits intoSagerNet:testingfrom
Open
selector: avoid nil deref when no outbound is selected#4102SAY-5 wants to merge 2 commits intoSagerNet:testingfrom
SAY-5 wants to merge 2 commits intoSagerNet:testingfrom
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
nekohasekai
force-pushed
the
testing
branch
2 times, most recently
from
8f15b13 to
9ee56ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3917.
Selector.DialContext/ListenPacket/NewConnection/NewPacketConnection/NewDirectRouteConnectionall calleds.selected.Load()and immediately dereferenced the result.Network()andNow()already nil-check; the connection-side methods didn't. After SFA disconnect+reconnect,selectedcan be nil and the next dial panics — guard each callsite.