fix(clashapi): prevent zip slip in external UI download#4121
Open
allanjoshuaf wants to merge 1 commit intoSagerNet:testingfrom
Open
fix(clashapi): prevent zip slip in external UI download#4121allanjoshuaf wants to merge 1 commit intoSagerNet:testingfrom
allanjoshuaf wants to merge 1 commit intoSagerNet:testingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a Zip Slip path traversal vulnerability in
downloadZIP()used by external UI downloads.The extracted file path is now validated to ensure it remains inside the configured output directory after path normalization.
Changes
filepath.CleanTesting
Added
TestDownloadZIPZipSlipwhich:../../../pwned.txt)downloadZIP()rejects the archiveRelated: #4117