Simplify commit comparison logic in show_selected by removing unnecessary checks. Update tests accordingly.

Author: Salanoid

lua/gitlogdiff/actions.lua

@@ -4,38 +4,16 @@ local function diffview_open(args)
   vim.cmd("DiffviewOpen " .. table.concat(args, " "))
 end
 
-local function diffview_history(args)
-  vim.cmd("DiffviewFileHistory " .. table.concat(args, " "))
-end
-
-function M.show_selected(hashes, indices)
+function M.show_selected(hashes, _)
   if #hashes == 0 then
     vim.notify("No commits selected", vim.log.levels.INFO)
     return
   end
 
-  local is_consecutive = true
-  if #indices > 1 then
-    for i = 2, #indices do
-      if indices[i] ~= indices[i - 1] + 1 then
-        is_consecutive = false
-        break
-      end
-    end
-  end
-
-  if is_consecutive then
-    if #hashes == 1 then
-      diffview_open({ hashes[1] .. "^.." .. hashes[1] })
-    else
-      diffview_open({ hashes[#hashes] .. "^.." .. hashes[1] })
-    end
+  if #hashes == 1 then
+    diffview_open({ hashes[1] .. "^.." .. hashes[1] })
   else
-    local args = { "--no-walk" }
-    for _, h in ipairs(hashes) do
-      table.insert(args, h)
-    end
-    diffview_history(args)
+    diffview_open({ hashes[#hashes] .. "^.." .. hashes[1] })
   end
 end
 

tests/test_init.lua

@@ -46,7 +46,7 @@ T["actions"]["show_selected() handles non-consecutive commits correctly"] = func
   end
 
   actions.show_selected({ "newer123", "older789" }, { 1, 3 })
-  MiniTest.expect.equality(cmds[1], "DiffviewFileHistory --no-walk newer123 older789")
+  MiniTest.expect.equality(cmds[1], "DiffviewOpen older789^..newer123")
 end
 
 T["log"] = MiniTest.new_set()