relax hydra-core pin from ==1.3 to >=1.3,<2#257
Open
korbonits wants to merge 1 commit into
Open
Conversation
The exact pin blocks co-installation with any package that requires hydra-core>=1.3.1 or >=1.3.2 (e.g. sam2, which needs >=1.3.2). The 1.3.x line has only patch releases; there are no breaking changes between 1.3.0 and 1.3.2. Using >=1.3,<2 allows resolver flexibility within the stable 1.x series without pulling in any hypothetical 2.0 that may have breaking changes.
|
Thanks for the contribution! Before we can merge this, we need @korbonits to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
Signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hydra-core==1.3→hydra-core>=1.3,<2inpyproject.tomlWhy
The exact
==1.3pin makes uni2ts incompatible with any package that requireshydra-core>=1.3.1or>=1.3.2. A concrete example:sam2(Meta's Segment Anything Model 2) requireshydra-core>=1.3.2, so the two packages cannot be installed in the same environment today.The 1.3.x series has only patch releases between 1.3.0 and 1.3.2. There are no breaking changes in those patches — they're bug fixes and minor improvements to the Hydra config system. Nothing in uni2ts should be affected.
What was changed
The
<2upper bound is conservative — it prevents any hypotheticalhydra-core 2.0from being pulled in before this project has been tested against it.Test plan
hydra-core==1.3.2installedpip install uni2ts sam2resolves without conflict after this change