Enforce sort-classes and unused-disable-directives as errors (#400)

clavery · web-flow · commit a51d82efe5be · 2026-05-05T20:37:05.000-04:00
perfectionist/sort-classes was warn-level and lint:agent passes --quiet,
so class-member order drift was silently fixable but never blocked CI.
Same for unused eslint-disable directives. Promote both to error and
apply the pending --fix output across commands and tests.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -52,7 +52,7 @@ export const oclifRules = {
   'perfectionist/sort-interfaces': 'off',
   'perfectionist/sort-named-exports': 'off',
   'perfectionist/sort-named-imports': 'off',
-  'perfectionist/sort-classes': 'warn',
+  'perfectionist/sort-classes': 'error',
   // Disable stylistic rules that conflict with our style
   '@stylistic/lines-between-class-members': 'off',
   '@stylistic/padding-line-between-statements': 'off',
diff --git a/packages/b2c-cli/eslint.config.mjs b/packages/b2c-cli/eslint.config.mjs
@@ -34,9 +34,7 @@ export default [
       header: headerPlugin,
     },
     linterOptions: {
-      // Downgrade to warn - import/namespace behaves inconsistently across environments
-      // when parsing CJS modules like marked-terminal
-      reportUnusedDisableDirectives: 'warn',
+      reportUnusedDisableDirectives: 'error',
     },
     rules: {
       'header/header': ['error', 'block', copyrightHeader],
diff --git a/packages/b2c-cli/src/commands/auth/client/index.ts b/packages/b2c-cli/src/commands/auth/client/index.ts
@@ -21,8 +21,6 @@ import {t} from '../../../i18n/index.js';
  * Use --renew to enable automatic token renewal for later use with `auth client renew`.
  */
 export default class AuthClient extends BaseCommand<typeof AuthClient> {
-  static hiddenAliases = ['client:auth'];
-
   static description = t('commands.auth.client.description', 'Authenticate an API client and save session');
 
   static examples = [
@@ -79,6 +77,8 @@ export default class AuthClient extends BaseCommand<typeof AuthClient> {
     }),
   };
 
+  static hiddenAliases = ['client:auth'];
+
   protected override loadConfiguration() {
     const scopes = this.flags['auth-scope'] as string[] | undefined;
     return loadConfig(
diff --git a/packages/b2c-cli/src/commands/auth/client/renew.ts b/packages/b2c-cli/src/commands/auth/client/renew.ts
@@ -19,8 +19,6 @@ import {t} from '../../../i18n/index.js';
  * to client_credentials grant using the stored base64-encoded client:secret.
  */
 export default class AuthClientRenew extends BaseCommand<typeof AuthClientRenew> {
-  static hiddenAliases = ['client:auth:renew'];
-
   static description = t('commands.auth.client.renew.description', 'Renew the client authentication token');
 
   static examples = ['<%= config.bin %> <%= command.id %>'];
@@ -34,6 +32,8 @@ export default class AuthClientRenew extends BaseCommand<typeof AuthClientRenew>
     }),
   };
 
+  static hiddenAliases = ['client:auth:renew'];
+
   protected override loadConfiguration() {
     return loadConfig(
       {accountManagerHost: this.flags['account-manager-host'] as string | undefined},
diff --git a/packages/b2c-cli/src/commands/auth/client/token.ts b/packages/b2c-cli/src/commands/auth/client/token.ts
@@ -25,8 +25,6 @@ interface AuthClientTokenOutput {
  * Mirrors sfcc-ci `client:auth:token` command behavior.
  */
 export default class AuthClientToken extends BaseCommand<typeof AuthClientToken> {
-  static hiddenAliases = ['client:auth:token'];
-
   static description = t(
     'commands.auth.client.token.description',
     'Return the current authentication token (stateful)',
@@ -36,6 +34,8 @@ export default class AuthClientToken extends BaseCommand<typeof AuthClientToken>
 
   static examples = ['<%= config.bin %> <%= command.id %>', '<%= config.bin %> <%= command.id %> --json'];
 
+  static hiddenAliases = ['client:auth:token'];
+
   async run(): Promise<AuthClientTokenOutput> {
     this.logger.debug('[StatefulAuth] Reading stored session from stateful store');
 
diff --git a/packages/b2c-cli/src/commands/auth/login.ts b/packages/b2c-cli/src/commands/auth/login.ts
@@ -15,8 +15,6 @@ import {t, withDocs} from '../../i18n/index.js';
  * until it expires or you run auth:logout.
  */
 export default class AuthLogin extends BaseCommand<typeof AuthLogin> {
-  static hiddenAliases = ['auth:login'];
-
   static args = {
     clientId: Args.string({
       description: 'Client ID for OAuth (falls back to SFCC_CLIENT_ID env var)',
@@ -48,6 +46,8 @@ export default class AuthLogin extends BaseCommand<typeof AuthLogin> {
     }),
   };
 
+  static hiddenAliases = ['auth:login'];
+
   protected override loadConfiguration() {
     const scopes = this.flags['auth-scope'] as string[] | undefined;
     return loadConfig(
diff --git a/packages/b2c-cli/src/commands/auth/logout.ts b/packages/b2c-cli/src/commands/auth/logout.ts
@@ -13,15 +13,15 @@ import {t, withDocs} from '../../i18n/index.js';
  * (client credentials or implicit) when configured.
  */
 export default class AuthLogout extends BaseCommand<typeof AuthLogout> {
-  static hiddenAliases = ['auth:logout'];
-
   static description = withDocs(
     t('commands.auth.logout.description', 'Clear stored session (stateful auth)'),
     '/cli/auth.html#b2c-auth-logout',
   );
 
   static examples = ['<%= config.bin %> <%= command.id %>'];
 
+  static hiddenAliases = ['auth:logout'];
+
   async run(): Promise<void> {
     clearStoredSession();
     this.log(t('commands.auth.logout.success', 'Logged out. Stored session cleared.'));
diff --git a/packages/b2c-cli/src/commands/cap/pull.ts b/packages/b2c-cli/src/commands/cap/pull.ts
@@ -14,18 +14,18 @@ import {
 import {t, withDocs} from '../../i18n/index.js';
 
 export default class CapPull extends JobCommand<typeof CapPull> {
-  static description = withDocs(
-    t('commands.cap.pull.description', 'Pull installed Commerce Apps from a B2C Commerce instance'),
-    '/cli/cap.html#b2c-cap-pull',
-  );
-
   static args = {
     appName: Args.string({
       description: 'Commerce App feature name to pull (e.g. avalara-tax). If omitted, pulls all registry apps.',
       required: false,
     }),
   };
 
+  static description = withDocs(
+    t('commands.cap.pull.description', 'Pull installed Commerce Apps from a B2C Commerce instance'),
+    '/cli/cap.html#b2c-cap-pull',
+  );
+
   static enableJsonFlag = true;
 
   static examples = [
diff --git a/packages/b2c-cli/src/commands/code/activate.ts b/packages/b2c-cli/src/commands/code/activate.ts
@@ -9,8 +9,6 @@ import {activateCodeVersion, reloadCodeVersion} from '@salesforce/b2c-tooling-sd
 import {t, withDocs} from '../../i18n/index.js';
 
 export default class CodeActivate extends InstanceCommand<typeof CodeActivate> {
-  static hiddenAliases = ['code:activate'];
-
   static args = {
     codeVersion: Args.string({
       description: 'Code version ID to activate',
@@ -39,6 +37,8 @@ export default class CodeActivate extends InstanceCommand<typeof CodeActivate> {
     }),
   };
 
+  static hiddenAliases = ['code:activate'];
+
   async run(): Promise<void> {
     this.requireOAuthCredentials();
 
diff --git a/packages/b2c-cli/src/commands/code/delete.ts b/packages/b2c-cli/src/commands/code/delete.ts
@@ -10,8 +10,6 @@ import {t, withDocs} from '../../i18n/index.js';
 import {confirm} from '../../prompts.js';
 
 export default class CodeDelete extends InstanceCommand<typeof CodeDelete> {
-  static hiddenAliases = ['code:delete'];
-
   static args = {
     codeVersion: Args.string({
       description: 'Code version ID to delete',
@@ -39,6 +37,8 @@ export default class CodeDelete extends InstanceCommand<typeof CodeDelete> {
     }),
   };
 
+  static hiddenAliases = ['code:delete'];
+
   protected operations = {
     confirm,
     deleteCodeVersion,
diff --git a/packages/b2c-cli/src/commands/code/deploy.ts b/packages/b2c-cli/src/commands/code/deploy.ts
@@ -16,8 +16,6 @@ import {CartridgeCommand} from '@salesforce/b2c-tooling-sdk/cli';
 import {t, withDocs} from '../../i18n/index.js';
 
 export default class CodeDeploy extends CartridgeCommand<typeof CodeDeploy> {
-  static hiddenAliases = ['code:deploy'];
-
   static args = {
     ...CartridgeCommand.baseArgs,
   };
@@ -61,6 +59,8 @@ export default class CodeDeploy extends CartridgeCommand<typeof CodeDeploy> {
     }),
   };
 
+  static hiddenAliases = ['code:deploy'];
+
   protected operations = {
     uploadCartridges,
     deleteCartridges,
diff --git a/packages/b2c-cli/src/commands/code/download.ts b/packages/b2c-cli/src/commands/code/download.ts
@@ -13,8 +13,6 @@ import {CartridgeCommand} from '@salesforce/b2c-tooling-sdk/cli';
 import {t, withDocs} from '../../i18n/index.js';
 
 export default class CodeDownload extends CartridgeCommand<typeof CodeDownload> {
-  static hiddenAliases = ['code:download'];
-
   static args = {
     ...CartridgeCommand.baseArgs,
   };
@@ -52,6 +50,8 @@ export default class CodeDownload extends CartridgeCommand<typeof CodeDownload>
     }),
   };
 
+  static hiddenAliases = ['code:download'];
+
   protected operations = {
     downloadCartridges,
     getActiveCodeVersion,
diff --git a/packages/b2c-cli/src/commands/code/list.ts b/packages/b2c-cli/src/commands/code/list.ts
@@ -34,8 +34,6 @@ const COLUMNS: Record<string, ColumnDef<CodeVersion>> = {
 const DEFAULT_COLUMNS = ['id', 'active', 'rollback', 'lastModified', 'cartridges'];
 
 export default class CodeList extends InstanceCommand<typeof CodeList> {
-  static hiddenAliases = ['code:list'];
-
   static description = withDocs(
     t('commands.code.list.description', 'List code versions on a B2C Commerce instance'),
     '/cli/code.html#b2c-code-list',
@@ -49,6 +47,8 @@ export default class CodeList extends InstanceCommand<typeof CodeList> {
     '<%= config.bin %> <%= command.id %> --json',
   ];
 
+  static hiddenAliases = ['code:list'];
+
   async run(): Promise<CodeVersionResult> {
     this.requireOAuthCredentials();
 
diff --git a/packages/b2c-cli/src/commands/job/run.ts b/packages/b2c-cli/src/commands/job/run.ts
@@ -14,8 +14,6 @@ import {
 import {t, withDocs} from '../../i18n/index.js';
 
 export default class JobRun extends JobCommand<typeof JobRun> {
-  static hiddenAliases = ['job:run'];
-
   static args = {
     jobId: Args.string({
       description: 'Job ID to execute',
@@ -76,6 +74,8 @@ export default class JobRun extends JobCommand<typeof JobRun> {
     }),
   };
 
+  static hiddenAliases = ['job:run'];
+
   protected operations = {
     executeJob,
     waitForJob,
diff --git a/packages/b2c-cli/src/commands/mrt/save-credentials.ts b/packages/b2c-cli/src/commands/mrt/save-credentials.ts
@@ -59,6 +59,11 @@ export default class MrtSaveCredentials extends BaseCommand<typeof MrtSaveCreden
     }),
   };
 
+  /** Wraps shared confirm for testability. */
+  protected async confirm(message: string): Promise<boolean> {
+    return confirm(message);
+  }
+
   async run(): Promise<MobifyConfigFile> {
     const {user, 'api-key': apiKey, 'cloud-origin': cloudOrigin, 'credentials-file': credentialsFile, yes} = this.flags;
 
@@ -98,11 +103,6 @@ export default class MrtSaveCredentials extends BaseCommand<typeof MrtSaveCreden
     return credentials;
   }
 
-  /** Wraps shared confirm for testability. */
-  protected async confirm(message: string): Promise<boolean> {
-    return confirm(message);
-  }
-
   private getMobifyPath(cloudOrigin?: string): string {
     if (cloudOrigin) {
       try {
diff --git a/packages/b2c-cli/src/commands/sites/cartridges/add.ts b/packages/b2c-cli/src/commands/sites/cartridges/add.ts
@@ -14,6 +14,13 @@ import {
 import {t, withDocs} from '../../../i18n/index.js';
 
 export default class SitesCartridgesAdd extends InstanceCommand<typeof SitesCartridgesAdd> {
+  static args = {
+    cartridge: Args.string({
+      description: t('args.cartridge.description', 'Cartridge name to add'),
+      required: true,
+    }),
+  };
+
   static description = withDocs(
     t('commands.sites.cartridges.add.description', "Add a cartridge to a site's cartridge path"),
     '/cli/sites.html#b2c-sites-cartridges-add',
@@ -28,15 +35,6 @@ export default class SitesCartridgesAdd extends InstanceCommand<typeof SitesCart
     '<%= config.bin %> sites cartridges add bm_extension --bm',
   ];
 
-  static hiddenAliases = ['sites:cartridge:add'];
-
-  static args = {
-    cartridge: Args.string({
-      description: t('args.cartridge.description', 'Cartridge name to add'),
-      required: true,
-    }),
-  };
-
   static flags = {
     'site-id': Flags.string({
       description: t('flags.siteId.description', 'Site ID (e.g. RefArch)'),
@@ -56,6 +54,8 @@ export default class SitesCartridgesAdd extends InstanceCommand<typeof SitesCart
     }),
   };
 
+  static hiddenAliases = ['sites:cartridge:add'];
+
   async run(): Promise<CartridgePathResult> {
     this.requireOAuthCredentials();
 
diff --git a/packages/b2c-cli/src/commands/sites/cartridges/list.ts b/packages/b2c-cli/src/commands/sites/cartridges/list.ts
@@ -22,8 +22,6 @@ export default class SitesCartridgesList extends InstanceCommand<typeof SitesCar
     '<%= config.bin %> sites cartridges list --site-id RefArch --json',
   ];
 
-  static hiddenAliases = ['sites:cartridge:list'];
-
   static flags = {
     'site-id': Flags.string({
       description: t('flags.siteId.description', 'Site ID (e.g. RefArch)'),
@@ -35,6 +33,8 @@ export default class SitesCartridgesList extends InstanceCommand<typeof SitesCar
     }),
   };
 
+  static hiddenAliases = ['sites:cartridge:list'];
+
   async run(): Promise<CartridgePathResult> {
     this.requireOAuthCredentials();
 
diff --git a/packages/b2c-cli/src/commands/sites/cartridges/remove.ts b/packages/b2c-cli/src/commands/sites/cartridges/remove.ts
@@ -9,6 +9,13 @@ import {type CartridgePathResult, BM_SITE_ID, removeCartridge} from '@salesforce
 import {t, withDocs} from '../../../i18n/index.js';
 
 export default class SitesCartridgesRemove extends InstanceCommand<typeof SitesCartridgesRemove> {
+  static args = {
+    cartridge: Args.string({
+      description: t('args.cartridge.description', 'Cartridge name to remove'),
+      required: true,
+    }),
+  };
+
   static description = withDocs(
     t('commands.sites.cartridges.remove.description', "Remove a cartridge from a site's cartridge path"),
     '/cli/sites.html#b2c-sites-cartridges-remove',
@@ -21,15 +28,6 @@ export default class SitesCartridgesRemove extends InstanceCommand<typeof SitesC
     '<%= config.bin %> sites cartridges remove bm_extension --bm',
   ];
 
-  static hiddenAliases = ['sites:cartridge:remove'];
-
-  static args = {
-    cartridge: Args.string({
-      description: t('args.cartridge.description', 'Cartridge name to remove'),
-      required: true,
-    }),
-  };
-
   static flags = {
     'site-id': Flags.string({
       description: t('flags.siteId.description', 'Site ID (e.g. RefArch)'),
@@ -41,6 +39,8 @@ export default class SitesCartridgesRemove extends InstanceCommand<typeof SitesC
     }),
   };
 
+  static hiddenAliases = ['sites:cartridge:remove'];
+
   async run(): Promise<CartridgePathResult> {
     this.assertDestructiveOperationAllowed('remove cartridge from site cartridge path');
     this.requireOAuthCredentials();
diff --git a/packages/b2c-cli/src/commands/sites/cartridges/set.ts b/packages/b2c-cli/src/commands/sites/cartridges/set.ts
diff --git a/packages/b2c-cli/src/commands/webdav/rm.ts b/packages/b2c-cli/src/commands/webdav/rm.ts
diff --git a/packages/b2c-tooling-sdk/test/operations/code/download.test.ts b/packages/b2c-tooling-sdk/test/operations/code/download.test.ts
diff --git a/packages/b2c-tooling-sdk/test/operations/debug/dap-adapter.test.ts b/packages/b2c-tooling-sdk/test/operations/debug/dap-adapter.test.ts
