Skip to content

Commit f3d2d9e

Browse files
claveryclavery
authored
fix(actions): forward full auth/config inputs to setup; clear Node 20 warning (#533)
High-level actions (code-deploy, data-import, job-run, webdav-upload) and the root action only forwarded a subset of auth inputs to setup, so passing account-manager-host, short-code, tenant-id, or staging mTLS credentials (certificate, certificate-passphrase, webdav-server, selfsigned) produced an "Unexpected input(s)" warning and silently dropped the value. - Declare and forward the full input set on each high-level action (job-run omits webdav-server since it is OAuth/OCAPI only). - Bump bundled setup-node to @v6 and template/README checkout to @v6 to clear the Node 20 deprecation warning. - Changeset targets @salesforce/b2c-dx-docs so the v1 actions tag advances.
1 parent 76643fa commit f3d2d9e

11 files changed

Lines changed: 136 additions & 7 deletions

File tree

‎.changeset/actions-forward-auth-inputs.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@salesforce/b2c-dx-docs': patch
3+
---
4+
5+
GitHub Actions: the high-level actions (`code-deploy`, `data-import`, `job-run`, `webdav-upload`) and the root action now forward the full set of auth/config inputs to `setup` — `account-manager-host`, `short-code`, `tenant-id`, `certificate`, `certificate-passphrase`, `selfsigned`, and `webdav-server` (where applicable). Previously these were silently dropped with an "Unexpected input(s)" warning, so a non-default Account Manager host or staging mTLS credentials had to be set via env vars or a separate `setup` step. Also bumped the bundled `setup-node`/`checkout` references to Node 24-capable majors to clear the Node 20 deprecation warning.

‎action.yml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,18 @@ inputs:
6060
account-manager-host:
6161
description: 'Account Manager hostname → SFCC_ACCOUNT_MANAGER_HOST'
6262
required: false
63+
webdav-server:
64+
description: 'Separate WebDAV hostname (used for staging cert. hostnames) → SFCC_WEBDAV_SERVER'
65+
required: false
66+
certificate:
67+
description: 'Path to PKCS12 client certificate for two-factor (mTLS) auth → SFCC_CERTIFICATE'
68+
required: false
69+
certificate-passphrase:
70+
description: 'Passphrase for the PKCS12 client certificate → SFCC_CERTIFICATE_PASSPHRASE'
71+
required: false
72+
selfsigned:
73+
description: 'Allow self-signed server certificates → SFCC_SELFSIGNED. Set to "true" to enable; omit otherwise.'
74+
required: false
6375

6476
outputs:
6577
cli-version:
@@ -93,6 +105,10 @@ runs:
93105
mrt-project: ${{ inputs.mrt-project }}
94106
mrt-environment: ${{ inputs.mrt-environment }}
95107
account-manager-host: ${{ inputs.account-manager-host }}
108+
webdav-server: ${{ inputs.webdav-server }}
109+
certificate: ${{ inputs.certificate }}
110+
certificate-passphrase: ${{ inputs.certificate-passphrase }}
111+
selfsigned: ${{ inputs.selfsigned }}
96112

97113
- name: Run command
98114
id: command

‎actions/README.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ GitHub Actions for automating Salesforce B2C Commerce operations with the [`@sal
2727
### One-step code deploy
2828

2929
```yaml
30-
- uses: actions/checkout@v4
30+
- uses: actions/checkout@v6
3131
- uses: SalesforceCommerceCloud/b2c-developer-tooling@v1
3232
with:
3333
client-id: ${{ secrets.SFCC_CLIENT_ID }}
@@ -40,7 +40,7 @@ GitHub Actions for automating Salesforce B2C Commerce operations with the [`@sal
4040
### High-level code deploy
4141
4242
```yaml
43-
- uses: actions/checkout@v4
43+
- uses: actions/checkout@v6
4444
- uses: SalesforceCommerceCloud/b2c-developer-tooling/actions/code-deploy@v1
4545
with:
4646
client-id: ${{ secrets.SFCC_CLIENT_ID }}
@@ -54,7 +54,7 @@ GitHub Actions for automating Salesforce B2C Commerce operations with the [`@sal
5454
### Data import
5555
5656
```yaml
57-
- uses: actions/checkout@v4
57+
- uses: actions/checkout@v6
5858
- uses: SalesforceCommerceCloud/b2c-developer-tooling/actions/data-import@v1
5959
with:
6060
client-id: ${{ secrets.SFCC_CLIENT_ID }}

‎actions/code-deploy/action.yml‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,27 @@ inputs:
4646
password:
4747
description: 'WebDAV password/access key (falls back to SFCC_PASSWORD env var)'
4848
required: false
49+
short-code:
50+
description: 'SCAPI short code (falls back to SFCC_SHORTCODE env var)'
51+
required: false
52+
tenant-id:
53+
description: 'Tenant ID (falls back to SFCC_TENANT_ID env var)'
54+
required: false
55+
account-manager-host:
56+
description: 'Account Manager hostname (falls back to SFCC_ACCOUNT_MANAGER_HOST env var)'
57+
required: false
58+
webdav-server:
59+
description: 'Separate WebDAV hostname for staging (falls back to SFCC_WEBDAV_SERVER env var)'
60+
required: false
61+
certificate:
62+
description: 'Path to PKCS12 client certificate for two-factor (mTLS) auth (falls back to SFCC_CERTIFICATE env var)'
63+
required: false
64+
certificate-passphrase:
65+
description: 'Passphrase for the PKCS12 client certificate (falls back to SFCC_CERTIFICATE_PASSPHRASE env var)'
66+
required: false
67+
selfsigned:
68+
description: 'Allow self-signed server certificates (falls back to SFCC_SELFSIGNED env var)'
69+
required: false
4970
# Setup inputs
5071
version:
5172
description: 'CLI version to install if not already set up'
@@ -80,6 +101,13 @@ runs:
80101
username: ${{ inputs.username }}
81102
password: ${{ inputs.password }}
82103
code-version: ${{ inputs.code-version }}
104+
short-code: ${{ inputs.short-code }}
105+
tenant-id: ${{ inputs.tenant-id }}
106+
account-manager-host: ${{ inputs.account-manager-host }}
107+
webdav-server: ${{ inputs.webdav-server }}
108+
certificate: ${{ inputs.certificate }}
109+
certificate-passphrase: ${{ inputs.certificate-passphrase }}
110+
selfsigned: ${{ inputs.selfsigned }}
83111

84112
- name: Build command
85113
id: build-cmd

‎actions/data-import/action.yml‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,27 @@ inputs:
3535
password:
3636
description: 'WebDAV password/access key (falls back to SFCC_PASSWORD env var)'
3737
required: false
38+
short-code:
39+
description: 'SCAPI short code (falls back to SFCC_SHORTCODE env var)'
40+
required: false
41+
tenant-id:
42+
description: 'Tenant ID (falls back to SFCC_TENANT_ID env var)'
43+
required: false
44+
account-manager-host:
45+
description: 'Account Manager hostname (falls back to SFCC_ACCOUNT_MANAGER_HOST env var)'
46+
required: false
47+
webdav-server:
48+
description: 'Separate WebDAV hostname for staging (falls back to SFCC_WEBDAV_SERVER env var)'
49+
required: false
50+
certificate:
51+
description: 'Path to PKCS12 client certificate for two-factor (mTLS) auth (falls back to SFCC_CERTIFICATE env var)'
52+
required: false
53+
certificate-passphrase:
54+
description: 'Passphrase for the PKCS12 client certificate (falls back to SFCC_CERTIFICATE_PASSPHRASE env var)'
55+
required: false
56+
selfsigned:
57+
description: 'Allow self-signed server certificates (falls back to SFCC_SELFSIGNED env var)'
58+
required: false
3859
# Setup inputs
3960
version:
4061
description: 'CLI version to install if not already set up'
@@ -68,6 +89,13 @@ runs:
6889
server: ${{ inputs.server }}
6990
username: ${{ inputs.username }}
7091
password: ${{ inputs.password }}
92+
short-code: ${{ inputs.short-code }}
93+
tenant-id: ${{ inputs.tenant-id }}
94+
account-manager-host: ${{ inputs.account-manager-host }}
95+
webdav-server: ${{ inputs.webdav-server }}
96+
certificate: ${{ inputs.certificate }}
97+
certificate-passphrase: ${{ inputs.certificate-passphrase }}
98+
selfsigned: ${{ inputs.selfsigned }}
7199

72100
- name: Build command
73101
id: build-cmd

‎actions/job-run/action.yml‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,24 @@ inputs:
3333
server:
3434
description: 'B2C instance hostname (falls back to SFCC_SERVER env var)'
3535
required: false
36+
short-code:
37+
description: 'SCAPI short code (falls back to SFCC_SHORTCODE env var)'
38+
required: false
39+
tenant-id:
40+
description: 'Tenant ID (falls back to SFCC_TENANT_ID env var)'
41+
required: false
42+
account-manager-host:
43+
description: 'Account Manager hostname (falls back to SFCC_ACCOUNT_MANAGER_HOST env var)'
44+
required: false
45+
certificate:
46+
description: 'Path to PKCS12 client certificate for two-factor (mTLS) auth (falls back to SFCC_CERTIFICATE env var)'
47+
required: false
48+
certificate-passphrase:
49+
description: 'Passphrase for the PKCS12 client certificate (falls back to SFCC_CERTIFICATE_PASSPHRASE env var)'
50+
required: false
51+
selfsigned:
52+
description: 'Allow self-signed server certificates (falls back to SFCC_SELFSIGNED env var)'
53+
required: false
3654
# Setup inputs
3755
version:
3856
description: 'CLI version to install if not already set up'
@@ -64,6 +82,12 @@ runs:
6482
client-id: ${{ inputs.client-id }}
6583
client-secret: ${{ inputs.client-secret }}
6684
server: ${{ inputs.server }}
85+
short-code: ${{ inputs.short-code }}
86+
tenant-id: ${{ inputs.tenant-id }}
87+
account-manager-host: ${{ inputs.account-manager-host }}
88+
certificate: ${{ inputs.certificate }}
89+
certificate-passphrase: ${{ inputs.certificate-passphrase }}
90+
selfsigned: ${{ inputs.selfsigned }}
6791

6892
- name: Build command
6993
id: build-cmd

‎actions/setup/action.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ runs:
8181
using: 'composite'
8282
steps:
8383
- name: Setup Node.js
84-
uses: actions/setup-node@v4
84+
uses: actions/setup-node@v6
8585
with:
8686
node-version: ${{ inputs.node-version }}
8787

‎actions/webdav-upload/action.yml‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,27 @@ inputs:
3131
password:
3232
description: 'WebDAV password/access key (falls back to SFCC_PASSWORD env var)'
3333
required: false
34+
short-code:
35+
description: 'SCAPI short code (falls back to SFCC_SHORTCODE env var)'
36+
required: false
37+
tenant-id:
38+
description: 'Tenant ID (falls back to SFCC_TENANT_ID env var)'
39+
required: false
40+
account-manager-host:
41+
description: 'Account Manager hostname (falls back to SFCC_ACCOUNT_MANAGER_HOST env var)'
42+
required: false
43+
webdav-server:
44+
description: 'Separate WebDAV hostname for staging (falls back to SFCC_WEBDAV_SERVER env var)'
45+
required: false
46+
certificate:
47+
description: 'Path to PKCS12 client certificate for two-factor (mTLS) auth (falls back to SFCC_CERTIFICATE env var)'
48+
required: false
49+
certificate-passphrase:
50+
description: 'Passphrase for the PKCS12 client certificate (falls back to SFCC_CERTIFICATE_PASSPHRASE env var)'
51+
required: false
52+
selfsigned:
53+
description: 'Allow self-signed server certificates (falls back to SFCC_SELFSIGNED env var)'
54+
required: false
3455
# Setup inputs
3556
version:
3657
description: 'CLI version to install if not already set up'
@@ -64,6 +85,13 @@ runs:
6485
server: ${{ inputs.server }}
6586
username: ${{ inputs.username }}
6687
password: ${{ inputs.password }}
88+
short-code: ${{ inputs.short-code }}
89+
tenant-id: ${{ inputs.tenant-id }}
90+
account-manager-host: ${{ inputs.account-manager-host }}
91+
webdav-server: ${{ inputs.webdav-server }}
92+
certificate: ${{ inputs.certificate }}
93+
certificate-passphrase: ${{ inputs.certificate-passphrase }}
94+
selfsigned: ${{ inputs.selfsigned }}
6795

6896
- name: Upload via WebDAV
6997
id: upload

‎actions/workflow-templates/b2c-code-deploy.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
deploy:
99
runs-on: ubuntu-latest
1010
steps:
11-
- uses: actions/checkout@v4
11+
- uses: actions/checkout@v6
1212

1313
- uses: SalesforceCommerceCloud/b2c-developer-tooling/actions/code-deploy@v1
1414
with:

‎actions/workflow-templates/b2c-data-import.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
import:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v6
1616

1717
- uses: SalesforceCommerceCloud/b2c-developer-tooling/actions/data-import@v1
1818
with:

0 commit comments

Comments
 (0)