Skip to content

fix(cap): remove root directory naming convention validation warning #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clavery merged 1 commit into from
Jun 4, 2026
+5 −8
Merged

fix(cap): remove root directory naming convention validation warning #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/remove-cap-root-dir-convention-warning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@salesforce/b2c-tooling-sdk': patch
---

Remove the CAP validation warning that flagged a root directory not matching the `{id}-v{version}` naming convention. This convention is no longer required, so the check has been dropped from `b2c cap validate` (and `b2c cap install`).
8 changes: 0 additions & 8 deletions packages/b2c-tooling-sdk/src/operations/cap/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,6 @@ export async function validateCap(target: string): Promise<CapValidationResult>
if (errors.filter((e) => e.startsWith('commerce-app.json:')).length === 0) {
manifest = raw as unknown as CommerceAppManifest;
}
// Check root dir naming convention
const dirName = path.basename(capDir);
if (manifest && dirName !== '.' && dirName !== tempDir) {
const expectedName = `${manifest.id}-v${manifest.version}`;
if (dirName !== expectedName) {
warnings.push(`Root directory "${dirName}" does not match expected convention "${expectedName}"`);
}
}
} catch {
errors.push('commerce-app.json: file exists but is not valid JSON');
}
Expand Down
Loading