Release v2.0.0 (@W-18482922@)#120
Merged
Merged
Conversation
alexvuong
approved these changes
Aug 14, 2025
vcua-mobify
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR release v2.0.0 of the
commerce-sdk-core. This is a major version release as we now URL encode path parameters by default.This PR also fixes a unit test that was using
proxyquireas it was no longer compatible with node 22 as it hasn't been actively updated in 6 years. The fix was to create a mock ofStaticClientto replicate the behavior. Ideally we use theStaticClientfile directly and mock out the fetch call, but unfortunately:fetchOptionspassed into the fetch call which is what we desirefetchimport frommake-fetch-happenwithout introducing another testing library likejestGiven these limitations I thought the best approach was just to simulate the behavior of
StaticClient.