-
Notifications
You must be signed in to change notification settings - Fork 35
@W-18557453 added build to update apis using a version map file #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| shopper-baskets-oas=1.9.0 | ||
| shopper-baskets-oas=2.1.0 | ||
| shopper-consents-oas=1.1.0 | ||
| shopper-context-oas=1.1.1 | ||
| shopper-customers-oas=1.1.1 | ||
| shopper-experience-oas=1.0.7 | ||
| shopper-gift-certificates-oas=1.0.26 | ||
| shopper-login-oas=1.39.41 | ||
| shopper-orders-oas=1.5.0 | ||
| shopper-products-oas=1.0.37 | ||
| shopper-promotions-oas=1.0.36 | ||
| shopper-search-oas=1.3.0 | ||
| shopper-seo-oas=1.0.13 | ||
| shopper-stores-oas=1.0.17 | ||
| shopper-payments-oas=1.2.0-master-b70 | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "main": "shopper-payments-oas-v1-public.yaml", | ||
| "name": "Shopper Payments OAS", | ||
| "groupId": "893f605e-10e2-423a-bdb4-f952f56eb6d8", | ||
| "assetId": "shopper-payments-oas", | ||
| "version": "1.2.0-master-b70", | ||
| "classifier": "oas", | ||
| "tags": [], | ||
| "descriptorVersion": "1.0.0", | ||
| "organizationId": "893f605e-10e2-423a-bdb4-f952f56eb6d8", | ||
| "apiVersion": "v1" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good solution that allows us to be precise in the versions that we release. In the past, we've had issues pulling untested versions and then having to roll back as those API OAS versions weren't ready to be released. My only concern with this approach is the overhead of tracking down these versions.
Who will be responsible for ensuring these API versions are pinned to the correct versions? The team who owns the SDK or the domain teams? I think we'll have to iron out this process to ensure no versions fall behind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of this PR was to improve developer experience by not requiring developers to manually API specs correct? But they'll have to run the
yarn updateApisWithVersionMapcommand right?Was there any exploration into adding the
yarn updateApisWithVersionMapcommand into the preview release CI?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked the commands a bit and update the https://github.com/SalesforceCommerceCloud/commerce-sdk-isomorphic/pull/241/files#diff-1246fcebc419eba2aaf5b810ef51db6ec5606f34da054746e1b31bdd7378405d with the instructions