Release/20260119 5.0.0 preview - for ECOM 26.2#266
Conversation
alexvuong
changed the title
alexvuong
changed the title
| { | ||
| "name": "commerce-sdk-isomorphic", | ||
| "version": "4.2.0", | ||
| "version": "5.0.0", |
There was a problem hiding this comment.
Keep the base at the new major version since all of these new apis are breaking change. Adding to preview won't automatically release to npm. We want to keep nightly release going with the base 5.0.0 moving forwards.
vcua-mobify
left a comment
vcua-mobify
left a comment
There was a problem hiding this comment.
Changes look fine to me.
@syadupathi-sf I have a question about a change you made in #235 . Is the slasHelper changes relating to a new functionality of the passwordless login api?
| lastName?: string; | ||
| email?: string; | ||
| firstName?: string; | ||
| phoneNumber?: string; |
There was a problem hiding this comment.
Let's update the javadoc to describe what these new parameters are for.
Specifically, it looks like authorizePasswordless is now able to register customers if the registerCustomer boolean is true? It looks like it's a new feature of the API itself and not us making several calls behind the scenes.
There was a problem hiding this comment.
Preview release LGTM, I confirmed that the API versions in the table align with what's in the directory
Moving forward, for the proper release, we should just be able to merge preview into main and create a github release assuming no changes need to be made from smoke testing correct?
| description: A three letter uppercase currency code conforming to the [ISO 4217](https://www.iso.org/iso-4217-currency-codes.html) standard. | ||
| example: USD | ||
| type: string | ||
| NoValue: |
There was a problem hiding this comment.
This is breaking but since we're bumping up a major version we're okay
* Release/20260119 5.0.0 preview - for ECOM 26.2 (#266) * update for 5.0.0 release * update docs * handle case for unique items --------- Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
3 participants
Preview preperation for 5.0.0-preview. List of api below are pulled that is matched with ECOM 26.2. See here
This PRs add some custom change to slasHelper.ts in this #235.