-
Notifications
You must be signed in to change notification settings - Fork 35
[feat] W@22204269 Release v5.2.0 - Add maintenance mode detection #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Copyright (c) 2025, Salesforce, Inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
| */ | ||
| import {Response} from 'node-fetch'; | ||
| import MaintenanceError from './maintenanceError'; | ||
|
|
||
| describe('MaintenanceError', () => { | ||
| test('creates error with system maintenance type', () => { | ||
| const response = new Response('{}', { | ||
| status: 200, | ||
| headers: {sfdc_maintenance: 'system'}, | ||
| }); | ||
|
|
||
| const error = new MaintenanceError(response, 'system'); | ||
|
|
||
| expect(error).toBeInstanceOf(Error); | ||
| expect(error).toBeInstanceOf(MaintenanceError); | ||
| expect(error.name).toBe('MaintenanceError'); | ||
| expect(error.message).toBe('Service unavailable due to system maintenance'); | ||
| expect(error.status).toBe(503); | ||
| expect(error.maintenanceType).toBe('system'); | ||
| expect(error.response).toBe(response); | ||
| }); | ||
|
|
||
| test('creates error with site maintenance type', () => { | ||
| const response = new Response('{}', { | ||
| status: 200, | ||
| headers: {sfdc_maintenance: 'site'}, | ||
| }); | ||
|
|
||
| const error = new MaintenanceError(response, 'site'); | ||
|
|
||
| expect(error).toBeInstanceOf(Error); | ||
| expect(error).toBeInstanceOf(MaintenanceError); | ||
| expect(error.name).toBe('MaintenanceError'); | ||
| expect(error.message).toBe('Service unavailable due to site maintenance'); | ||
| expect(error.status).toBe(503); | ||
| expect(error.maintenanceType).toBe('site'); | ||
| expect(error.response).toBe(response); | ||
| }); | ||
|
|
||
| test('error can be caught and properties accessed', () => { | ||
| const response = new Response('{}', {status: 200}); | ||
| const error = new MaintenanceError(response, 'system'); | ||
|
|
||
| try { | ||
| throw error; | ||
| } catch (caught) { | ||
| expect(caught).toBeInstanceOf(MaintenanceError); | ||
| if (caught instanceof MaintenanceError) { | ||
| expect(caught.status).toBe(503); | ||
| expect(caught.maintenanceType).toBe('system'); | ||
| expect(caught.response).toBe(response); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| test('error has correct property types', () => { | ||
| const response = new Response('{}', {status: 200}); | ||
| const error = new MaintenanceError(response, 'system'); | ||
|
|
||
| expect(error.status).toBe(503); | ||
| expect(typeof error.status).toBe('number'); | ||
| expect(error.maintenanceType).toBe('system'); | ||
| expect(['system', 'site']).toContain(error.maintenanceType); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use throwOnBadResponse flag instead of using new flag. when throwOnBadResponse=true, the current code already throws error. We can throw MaintenanceError in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually on purpose to maintain backward compatibility. One may just enable this option while not having exceptions for the other errors.