Skip to content

Commit 74961af

Browse files
committed
fix: add PHPStan type assertions to MCP config classes
Add inline @var assertions for non-falsy-string and array shape return types that PHPStan cannot infer through apply_filters().
1 parent d050a2b commit 74961af

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

src/MCP/Abilities/AbilityDefinitionFactory.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ private function normalize_args( $args ): array {
123123
* @return lowercase-string&non-falsy-string
124124
*/
125125
private function ability_name( string $tool_name ): string {
126+
/** @var lowercase-string&non-falsy-string */
126127
return strtolower( MCPConfig::get_ability_prefix() . str_replace( '_', '-', $tool_name ) );
127128
}
128129

src/MCP/MCPConfig.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@ class MCPConfig {
1515
*
1616
* Default: 'saltus-framework/v1'
1717
*
18-
* @return string
18+
* @return non-falsy-string
1919
*/
2020
public static function get_namespace(): string {
21+
/** @var non-falsy-string */
2122
return (string) \apply_filters(
2223
'saltus/framework/mcp/namespace',
2324
'saltus-framework/v1'
@@ -37,6 +38,7 @@ public static function get_namespace(): string {
3738
* @return array{id: string, label: string, description: string}
3839
*/
3940
public static function get_ability_category(): array {
41+
/** @var array{id: string, label: string, description: string} */
4042
return (array) \apply_filters(
4143
'saltus/framework/mcp/ability_category',
4244
[

0 commit comments

Comments
 (0)