fix: add PHPStan type assertions to REST controllers

Add local @var non-falsy-string assertions in register_routes() methods so PHPStan can verify register_rest_route namespace parameter type.

Author: LC43

src/Rest/DuplicateController.php

@@ -30,8 +30,10 @@ public function __construct( ?ModelRestPolicy $policy = null ) {
 	 * Register the REST route for post duplication.
 	 */
 	public function register_routes(): void {
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base . '/(?P<post_id>\d+)',
 			[
 				'methods'             => WP_REST_Server::CREATABLE,

src/Rest/ExportController.php

@@ -32,8 +32,10 @@ public function __construct( ?ModelRestPolicy $policy = null, ?SaltusSingleExpor
 	 * Register the REST route for post export.
 	 */
 	public function register_routes(): void {
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		\register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base . '/(?P<post_id>\d+)',
 			[
 				'methods'             => WP_REST_Server::READABLE,

src/Rest/HealthController.php

@@ -29,8 +29,10 @@ public function __construct( string $version, ?AuditLogger $audit_logger = null
 	 * Register the health route.
 	 */
 	public function register_routes(): void {
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base,
 			[
 				'methods'             => WP_REST_Server::READABLE,

src/Rest/MetaController.php

@@ -41,8 +41,10 @@ public function register_routes(): void {
 			return;
 		}
 
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base,
 			[
 				'methods'             => WP_REST_Server::READABLE,
@@ -52,7 +54,7 @@ public function register_routes(): void {
 		);
 
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base . '/(?P<post_type>[a-z0-9_-]+)',
 			[
 				'methods'             => WP_REST_Server::READABLE,
@@ -69,7 +71,7 @@ public function register_routes(): void {
 		);
 
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base . '/(?P<post_type>[a-z0-9_-]+)/(?P<post_id>\d+)',
 			[
 				'methods'             => WP_REST_Server::EDITABLE,

src/Rest/ModelsController.php

@@ -35,8 +35,10 @@ public function __construct( Modeler $modeler, ?ModelRestPolicy $policy = null )
 	 * Register the REST routes for listing and reading models.
 	 */
 	public function register_routes(): void {
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base,
 			[
 				'methods'             => WP_REST_Server::READABLE,
@@ -46,7 +48,7 @@ public function register_routes(): void {
 		);
 
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base . '/(?P<post_type>[a-z0-9_-]+)',
 			[
 				'methods'             => WP_REST_Server::READABLE,

src/Rest/ReorderController.php

@@ -33,8 +33,10 @@ public function __construct( ?ModelRestPolicy $policy = null, ?ReorderPostsServi
 	 * Register the REST route for reordering posts.
 	 */
 	public function register_routes(): void {
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base,
 			[
 				'methods'             => WP_REST_Server::CREATABLE,

src/Rest/SettingsController.php

@@ -33,8 +33,10 @@ public function __construct( ?ModelRestPolicy $policy = null, ?SettingsManager $
 	 * Register the REST routes for reading and updating settings.
 	 */
 	public function register_routes(): void {
+		/** @var non-falsy-string $namespace */
+		$namespace = $this->namespace;
 		register_rest_route(
-			$this->namespace,
+			$namespace,
 			'/' . $this->rest_base . '/(?P<post_type>[a-z0-9_-]+)',
 			[
 				[