chore(pr-template) Fix PR template (kroxylicious#3840)

* chore(pr-template) Fix PR template

Updated the PR checklist to clarify testing requirements.

Signed-off-by: Keith Wall <kwall@apache.org>

* address review comments

Signed-off-by: Keith Wall <kwall@apache.org>

---------

Signed-off-by: Keith Wall <kwall@apache.org>

Author: k-wall

.claude/rules/pull-requests.md

@@ -0,0 +1,11 @@
+# Pull Request Requirements
+
+## Template
+
+When creating pull requests, follow the checklist in [.github/PULL_REQUEST_TEMPLATE.md](../../.github/PULL_REQUEST_TEMPLATE.md).
+
+## Key Points for Claude
+
+- The template checklist is evaluated before merging, not necessarily before opening the PR
+- Always include `Assisted-by:` trailer in commits (see commit conventions)
+- For Sonarcloud warnings: either fix them or suppress with `@SuppressWarnings` plus justifying comment

.github/PULL_REQUEST_TEMPLATE.md

@@ -17,17 +17,13 @@ _Why are you making this pull request?_
 
 ### Checklist
 
-_Please go through this checklist and make sure all applicable tasks have been done_
-
-- [ ] PR raised from a fork of this repository and made from a branch rather than main. 
-- [ ] Write tests
-- [ ] Update documentation
-- [ ] Make sure all unit/integration tests pass
-- [ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
-- [ ] If applicable to the change, make sure system tests pass.
-- [ ] If applicable to the change, [trigger the performance test suite](../blob/main/PERFORMANCE.md#jenkins-pipeline-for-performance). Ensure that any degradations to performance numbers are understood and justified.
-- [ ] Ensure the PR references relevant issue(s) so they are closed on merging.
-- [ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).
+The checklist is used to help Committers judge a PR's readiness for merge.
+Contributors: please check off items you consider done.
+
+- [ ] New tests written (where applicable).
+- [ ] User facing documentation written/updated (where applicable).
+- [ ] Existing unit/integration/system tests passing.
+- [ ] Any Sonarcloud warnings are addressed (or suppressed with `@SuppressWarnings` and a justifying comment).
+- [ ] PR references related GitHub issue(s) so they are closed on merging.
 - [ ] If AI tools assisted with code changes, ensure commit messages include `Assisted-by:` trailer (see [DEV_GUIDE.md](../blob/main/DEV_GUIDE.md#ai-disclosure-requirement)).
-
-> **_NOTE:_**  You must be a member of `@kroxylicious/developers` to trigger the system test and performance test suites.  If you are not part of this group, comment on the PR requesting a trigger, tagging `@kroxylicious/developers`.
+- [ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

CLAUDE.md

@@ -31,6 +31,7 @@ When writing code, follow these prescriptive rules:
 - [Security](.claude/rules/security-patterns.md) - Security coding requirements
 - [Logging](.claude/rules/logging.md) - Logging conventions
 - [Documentation](.claude/rules/documentation-requirements.md) - When to write docs
+- [Pull Requests](.claude/rules/pull-requests.md) - PR checklist requirements
 
 ## Commit Conventions