Skip to content

Commit bbaa47e

Browse files
authored
chore(tests): AzureKeyVaultKmsTestKmsFacadeTest is missing its docker precondition (kroxylicious#3530)
why: our intention is the the test suite runs cleanly, even if external dependencies such as docker are not available. we are missing the precondition in this case Signed-off-by: Keith Wall <kwall@apache.org>
1 parent 6479e02 commit bbaa47e

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

kroxylicious-kms-providers/kroxylicious-kms-provider-azure-key-vault-kms-test-support/src/test/java/io/kroxylicious/kms/provider/azure/kms/AzureKeyVaultKmsTestKmsFacadeTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@
77
package io.kroxylicious.kms.provider.azure.kms;
88

99
import org.junit.jupiter.api.Test;
10+
import org.junit.jupiter.api.condition.EnabledIf;
11+
import org.testcontainers.DockerClientFactory;
1012

1113
import com.github.nagyesta.lowkeyvault.testcontainers.LowkeyVaultContainer;
1214

1315
import static org.assertj.core.api.Assertions.assertThat;
1416

17+
@EnabledIf(value = "isDockerAvailable", disabledReason = "docker unavailable")
1518
class AzureKeyVaultKmsTestKmsFacadeTest {
1619

1720
@Test
@@ -21,4 +24,7 @@ void lowKeyContainer() {
2124
}
2225
}
2326

27+
static boolean isDockerAvailable() {
28+
return DockerClientFactory.instance().isDockerAvailable();
29+
}
2430
}

0 commit comments

Comments
 (0)