🐛 fix(scripts): address prior PR Copilot review follow-ups

- Make profile Prompt implementations null-safe when command history is empty
- Add ShouldProcess support around New-gMSA Active Directory changes
- Update stale remoting catch messages after replacing Enter-PSSession usage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SamErde

Active Directory/Domain Services/DNSZonesRemote.ps1

@@ -48,7 +48,7 @@ foreach ($srv in $servers) {
             }
         }
     } Catch {
-        Write-Host -ForegroundColor DarkYellow "Failed to enter the PSSession for $server. Skipping."
+        Write-Host -ForegroundColor DarkYellow "Failed to create or use the PSSession for $server. Skipping."
         Continue
     } Finally {
         if ($session) {

Active Directory/Set DNS Server Zone Settings via Registry.ps1

@@ -55,7 +55,7 @@ foreach ($srv in $servers) {
             }
         }
     } Catch {
-        Write-Host "Failed to enter the PSSession for $server. Skipping." -ForegroundColor DarkYellow
+        Write-Host "Failed to create or use the PSSession for $server. Skipping." -ForegroundColor DarkYellow
         Continue
     } Finally {
         if ($session) {

Profile and Prompt/PSProfileBase.ps1

@@ -170,8 +170,10 @@ if ($IsPowerShellISE -or (-not (Get-Command -Name 'oh-my-posh' -ErrorAction Sile
     # Custom prompt function that shows admin status, command ID, command duration, and path.
     function Prompt {
         $LastCommand = Get-History -Count 1 -ErrorAction SilentlyContinue
+        $CommandId = if ($LastCommand) { $LastCommand.Id + 1 } else { 1 }
+        $DurationMilliseconds = if ($LastCommand) { [math]::Ceiling($LastCommand.Duration.TotalMilliseconds) } else { 0 }
         Write-Host "$AdminStatus " -ForegroundColor "$AdminStatusColor" -NoNewline
-        Write-Host "[$($LastCommand.Id +1)] $([math]::Ceiling($LastCommand.Duration.TotalMilliseconds))ms " -NoNewline -ForegroundColor White
+        Write-Host "[$CommandId] ${DurationMilliseconds}ms " -NoNewline -ForegroundColor White
         Write-Host "$FolderGlyph $($PWD.ToString() -ireplace [regex]::Escape($HOME),'~')" -ForegroundColor Yellow
         Write-Host '>' -NoNewline -ForegroundColor White
         return ' '
@@ -190,8 +192,10 @@ if ($IsPowerShellISE -or (-not (Get-Command -Name 'oh-my-posh' -ErrorAction Sile
 
     function Prompt {
         $LastCommand = Get-History -Count 1 -ErrorAction SilentlyContinue
+        $CommandId = if ($LastCommand) { $LastCommand.Id + 1 } else { 1 }
+        $DurationMilliseconds = if ($LastCommand) { [math]::Ceiling($LastCommand.Duration.TotalMilliseconds) } else { 0 }
         Write-Host "$AdminStatus " -ForegroundColor "$AdminStatusColor" -NoNewline
-        Write-Host "[$($LastCommand.Id +1)] $([math]::Ceiling($LastCommand.Duration.TotalMilliseconds))ms " -NoNewline -ForegroundColor White
+        Write-Host "[$CommandId] ${DurationMilliseconds}ms " -NoNewline -ForegroundColor White
         Write-Host "$FolderGlyph $($PWD.ToString() -ireplace [regex]::Escape($HOME),'~')" -ForegroundColor Yellow
         Write-Host '>' -NoNewline -ForegroundColor White
         return ' '

Windows/New-gMSA.ps1

@@ -37,6 +37,7 @@ Function New-gMSA {
     .OUTPUTS
         None
     #>
+    [CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'Medium')]
     param (
         [Parameter(Mandatory=$true)]
         [ValidateLength(1,15)]
@@ -65,7 +66,10 @@ Function New-gMSA {
     Import-Module ActiveDirectory
     $Group = "MSA " + $gMSA
     $DNS = "$gMSA.$DomainDnsName"
-    New-ADGroup -Name $Group -GroupScope Global -DisplayName $Group -Description "Permission group for $gMSA" -Path $GroupPath -Credential $Credential
-    Add-ADGroupMember -Identity $Group -Members ($Servers | ForEach-Object {Get-ADComputer -Identity $_ -Credential $Credential}) -Credential $Credential
-    New-ADServiceAccount -Name $gMSA -DNSHostName $DNS -PrincipalsAllowedToRetrieveManagedPassword $Group -Path $ServiceAccountPath -Credential $Credential
+
+    if ($PSCmdlet.ShouldProcess($gMSA, 'Create gMSA, retrieval group, and group membership')) {
+        New-ADGroup -Name $Group -GroupScope Global -DisplayName $Group -Description "Permission group for $gMSA" -Path $GroupPath -Credential $Credential
+        Add-ADGroupMember -Identity $Group -Members ($Servers | ForEach-Object {Get-ADComputer -Identity $_ -Credential $Credential}) -Credential $Credential
+        New-ADServiceAccount -Name $gMSA -DNSHostName $DNS -PrincipalsAllowedToRetrieveManagedPassword $Group -Path $ServiceAccountPath -Credential $Credential
+    }
 }