🐛 fix(scripts): address PR review findings

Resolve remaining PR review feedback for pipeline output, unused variables, progress preference restoration, preserved error records, DNS lookup API usage, SID comments, and PSSession cleanup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SamErde

Active Directory/Export-AllADUserTransitiveGroupMemberships.ps1

@@ -148,14 +148,17 @@ begin {
             }
 
             $CurrentProgressPreference = Get-Variable -Name ProgressPreference -ValueOnly
-            Set-Variable -Name ProgressPreference -Value 'SilentlyContinue' -Scope Global -Force -ErrorAction SilentlyContinue
-            # Check if the global catalog server is available on the specified port.
-            if (-not (Test-NetConnection -ComputerName $Server -Port $Port -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
-                if (-not (Test-NetConnection -ComputerName $Server -Port $AltPort -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
-                    throw "Unable to connect to the global catalog server '$Server' on port '$Port' or '$AltPort.'"
+            try {
+                Set-Variable -Name ProgressPreference -Value 'SilentlyContinue' -Scope Global -Force -ErrorAction SilentlyContinue
+                # Check if the global catalog server is available on the specified port.
+                if (-not (Test-NetConnection -ComputerName $Server -Port $Port -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
+                    if (-not (Test-NetConnection -ComputerName $Server -Port $AltPort -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
+                        throw "Unable to connect to the global catalog server '$Server' on port '$Port' or '$AltPort.'"
+                    }
                 }
+            } finally {
+                Set-Variable -Name ProgressPreference -Value $CurrentProgressPreference -Scope Global -Force -ErrorAction SilentlyContinue
             }
-            Set-Variable -Name ProgressPreference -Value $CurrentProgressPreference -Scope Global -Force -ErrorAction SilentlyContinue
         }
 
         process {

Active Directory/Get-ADObjectFromPipeline.ps1

@@ -15,7 +15,6 @@ function Get-ADObjectFromPipeline {
 
     begin {
         Import-Module ActiveDirectory
-        $GlobalCatalog = Get-ADDomainController -Discover -Service GlobalCatalog
     }
 
     process {
@@ -36,25 +35,15 @@ function Get-ADObjectFromPipeline {
         switch ($IdentityType) {
             'user' {
                 # Not Complete
-                $User = Get-ADUser -Identity $Identity -Properties PrimaryGroup,SidHistory
+                Get-ADUser -Identity $Identity -Properties PrimaryGroup,SidHistory
             }
             'computer' {
                 # Not Complete
-                $Computer = Get-ADComputer -Identity $Identity -Properties PrimaryGroup,SidHistory
+                Get-ADComputer -Identity $Identity -Properties PrimaryGroup,SidHistory
             }
             Default {
                 Write-Error "Identity type not supported."
             }
         }
     }
-
-    end {
-        # Do something and/or return the resulting object to the pipeline.
-        if ($User) {
-            $User
-        }
-        if ($Computer) {
-            $Computer
-        }
-    }
 }

Active Directory/Get-ADUserTransitiveGroupMembership.ps1

@@ -57,14 +57,17 @@ function Get-ADUserTransitiveGroupMembership {
         }
 
         $CurrentProgressPreference = Get-Variable -Name ProgressPreference -ValueOnly
-        Set-Variable -Name ProgressPreference -Value 'SilentlyContinue' -Force -Scope Global -ErrorAction SilentlyContinue
-        # Check if the global catalog server is available on the specified port.
-        if (-not (Test-NetConnection -ComputerName $Server -Port $Port -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
-            if (-not (Test-NetConnection -ComputerName $Server -Port $AltPort -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
-                throw "Unable to connect to the global catalog server '$Server' on port '$Port' or '$AltPort.'"
+        try {
+            Set-Variable -Name ProgressPreference -Value 'SilentlyContinue' -Force -Scope Global -ErrorAction SilentlyContinue
+            # Check if the global catalog server is available on the specified port.
+            if (-not (Test-NetConnection -ComputerName $Server -Port $Port -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
+                if (-not (Test-NetConnection -ComputerName $Server -Port $AltPort -InformationLevel Quiet -ErrorAction SilentlyContinue)) {
+                    throw "Unable to connect to the global catalog server '$Server' on port '$Port' or '$AltPort.'"
+                }
             }
+        } finally {
+            Set-Variable -Name ProgressPreference -Value $CurrentProgressPreference -Force -Scope Global -ErrorAction SilentlyContinue
         }
-        Set-Variable -Name ProgressPreference -Value $CurrentProgressPreference -Force -Scope Global -ErrorAction SilentlyContinue
     }
 
     process {

DDI/Get Hostnames from CSV IP Addresses.ps1

@@ -10,7 +10,7 @@ $IPAddressList | foreach-object {
         $_.Hostname = ([System.Net.Dns]::GetHostEntry($ip)).HostName
     }
     catch {
-        Write-Error $_ #.Exception.Message.Split(':')[1]
+        Write-Error -ErrorRecord $_ #.Exception.Message.Split(':')[1]
     }
 }
 # Write the data back to the CSV with the hostnames added.

Exchange/Parse-TransportLogs.ps1

@@ -56,7 +56,7 @@ foreach ($item in $TestSet) {
     $item.MessageID = $data
     $item.Subject = $subject
     try {
-        $item.Hostname = ([System.Net.DNS]::GetHostbyAddress($item.IPAddress)).Hostname
+        $item.Hostname = ([System.Net.DNS]::GetHostEntry($item.IPAddress)).HostName
     } catch {
         # Hostname not found for this IP; leave blank.
     }

Windows/Activate and Get License.ps1

@@ -22,8 +22,7 @@ $registryPath = 'HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\MfaRequiredI
 $registryValueName = 'Verify Multi-factor Authentication in ClipRenew'
 $registryValueData = 0  # DWORD value of 0
 $sid = New-Object System.Security.Principal.SecurityIdentifier('S-1-5-4')
-# SID for the Everyone group
-# or SID S-1-5-4 for the interactive group
+# SID S-1-5-4 is the Interactive group.
 
 # Check if the registry key already exists
 if (-not (Test-Path -Path $registryPath)) {
@@ -35,7 +34,7 @@ if (-not (Test-Path -Path $registryPath)) {
     Write-Output 'Registry key already exists. No changes made.'
 }
 
-# Add read permissions for SID (S-1-1-0, Everyone) to the registry key with inheritance
+# Add read permissions for the Interactive SID (S-1-5-4) to the registry key with inheritance
 $acl = Get-Acl -Path $registryPath
 $ruleSID = New-Object System.Security.AccessControl.RegistryAccessRule($sid, 'ReadKey', 'ContainerInherit,ObjectInherit', 'None', 'Allow')
 $acl.AddAccessRule($ruleSID)

Windows/Push-DNSClientServerAddresses.ps1

@@ -42,6 +42,6 @@ foreach ($server in $servers)
         Write-Output "Failed to change the DNS client server address on $serverName"
     }
     finally {
-        if ($s) { Remove-PSSession -Session $s }
+        if ($s) { Remove-PSSession -Session $s -ErrorAction SilentlyContinue }
     }
 } # End foreach server loop.