🐛 fix(scripts): third audit pass — string interpolation, obsolete API, and scope bugs

Active Directory/AD Users/Set User EmailAddress from PrimaryAddress.ps1

@@ -32,7 +32,7 @@ Write-Progress -Id 1 -Activity $MainScriptActivity -Status $MainScriptStatus -Pe
 foreach ($user in $users)
 {
     $i++
-    Write-Progress -Id 2 -Activity $UserLoopActivity -Status "$i of $userCount - $user.Name" -PercentComplete ($i / $userCount * 100) -ParentId 1
+    Write-Progress -Id 2 -Activity $UserLoopActivity -Status "$i of $userCount - $($user.Name)" -PercentComplete ($i / $userCount * 100) -ParentId 1
 
     $addresses = $user | Select-Object -ExpandProperty ProxyAddresses
     If ($addresses)

DDI/DNS Reverse Lookup from CSV and Add Column with Hostname.ps1

@@ -2,6 +2,6 @@ $file = ""
 $csv = Import-Csv $file
 foreach ($row in $csv) {
     $IP = $row.SourceIP
-    $row.SourceName = ([System.Net.DNS]::GetHostbyAddress($IP)).Hostname
+    $row.SourceName = ([System.Net.DNS]::GetHostEntry($IP)).Hostname
 }
 $csv | Export-Csv "results.csv" -NoTypeInformation

DDI/Resolve-IPs.ps1

@@ -14,11 +14,14 @@ $ResultList = @()
 
 
 foreach ($IP in $ListOfIPs) {
-    $ErrorActionPreference = 'silentlycontinue'
     $Result = $null
 
     Write-Host "Resolving $IP" -ForegroundColor Green
-    $result = [System.Net.Dns]::gethostentry($IP)
+    try {
+        $result = [System.Net.Dns]::gethostentry($IP)
+    } catch {
+        $result = $null
+    }
 
     If ($Result) {
         $ResultList += "$IP," + [string]$Result.HostName

Snippets/RemoteServerSessionLoop2.ps1

@@ -19,20 +19,20 @@ foreach ($server in $servers) {
 
     Try {
         Write-Information "Connecting to $server... " -InformationAction Continue
-        Enter-PSSession $session
+        # Enter-PSSession is interactive-only; use Invoke-Command to run code in the remote session.
+        Invoke-Command -Session $session -ScriptBlock {
+            <#
+                Code to be run on each remote server goes here.
+            #>
+            Write-Information 'Inner code.' -InformationAction Continue
+        }
     } Catch {
-        Write-Warning "Failed to enter the PSSession for $server. Skipping." -WarningAction Continue
+        Write-Warning "Failed to connect to $server. Skipping." -WarningAction Continue
         Continue
     }
     Write-Output $session.State
 
-    <#
-        Code to be run on each remote server go here.
-    #>
-    Write-Information 'Inner code.' -InformationAction Continue
-
     #Cleanup and then show the current PSSession state.
-    Exit-PSSession
     Remove-PSSession $session
-    Write-Information "$session.ComputerName $session.State `n`n" -InformationAction Continue
+    Write-Information "$($session.ComputerName) $($session.State) `n`n" -InformationAction Continue
 }

Windows/Disable-Poshv2.ps1

@@ -11,7 +11,7 @@ $exclusions = @('', '', '')
 #Filtering out production servers as well as any SQL, Exchange, SharePoint (SPS), Telephony, rinf* servers, and any servers in the "Non Windows" OU.
 $servers = (Get-ADComputer -Filter 'OperatingSystem -like "Windows Server*" -and Enabled -eq "True" -and Name -notlike "*sps*"' `
         -SearchBase 'DC=DOMAIN,DC=COM' -SearchScope Subtree).Name | Where-Object { $_ -notin $Exclusions } | Sort-Object
-Write-Information "$servers.Count servers found."
+Write-Information "$($servers.Count) servers found."
 
 foreach ($server in $servers) {
     if (Test-WSMan -ComputerName $server -ErrorAction Ignore) {