Skip to content

Commit e29aa63

Browse files
committed
Update test_s3.py
1 parent 83f1565 commit e29aa63

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

tests/integration/botocore/test_s3.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def clear_out_bucket(bucket, region, delete_bucket=False):
109109
for _ in range(5):
110110
try:
111111
s3.delete_bucket(Bucket=bucket)
112-
break
112+
return
113113
except s3.exceptions.NoSuchBucket:
114114
exists_waiter.wait(Bucket=bucket)
115115
except Exception as e:
@@ -121,9 +121,13 @@ def clear_out_bucket(bucket, region, delete_bucket=False):
121121
"delete_bucket() raised an exception: %s", e, exc_info=True
122122
)
123123
not_exists_waiter = s3.get_waiter('bucket_not_exists')
124-
not_exists_waiter.wait(Bucket=bucket)
125-
except WaiterError:
126-
continue
124+
try:
125+
not_exists_waiter.wait(Bucket=bucket)
126+
return
127+
except WaiterError:
128+
continue
129+
# If all attempts to delete the bucket fail, we still need to raise an error
130+
raise RuntimeError(f"Bucket {bucket} still exists after attempted deletion.")
127131

128132

129133
def teardown_module():

0 commit comments

Comments
 (0)