fix: Telegram Bot API client has no deadline, so startup and sends can hang forever#889
Open
sam-saffron-jarvis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NewBotAPIWithClientinstead of the library default unboundedhttp.Client.getMe, sends, edits,getFile) and a 70s deadline togetUpdates, preserving the existing 60s long-poll window with slack.Why this is high-value
Sam/Jarvis uses the Telegram surface routinely, and this client is on every
serve --telegramstartup, every long-poll request, and every reply/edit while streaming. Before this change, a stalled Telegram API/network call could block startup forever or wedge a per-chat stream while holding the session mutex, preventing later messages,/reset, and cleanup for that chat from making progress.Validation
go test ./internal/serve -run 'TestTelegramBotAPIClient' -count=1 -vgo build ./...go test ./...git diff --check