fix: Widget idle reaper can kill an active long-lived widget request#895
Open
sam-saffron-jarvis wants to merge 1 commit into
Open
fix: Widget idle reaper can kill an active long-lived widget request#895sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
inFlightcounter on each widget entry.lastReqon completion.Why this is high-value
Widgets are a visible Jarvis/web UI surface, and long-lived requests such as streams, long polls, or WebSocket-style proxied connections can legitimately stay open longer than the 10 minute idle timeout. Previously the reaper only considered request start time, so it could terminate the widget process and clear its proxy while a user-visible request was still active.
Validation
go test ./internal/widgetsgo build ./...go test ./...git diff --check