Remove try catch in key function addresses classes for X86 and Arm64

Author: ds5678

Cpp2IL.Core/Il2CppApiFunctions/NewArm64KeyFunctionAddresses.cs

@@ -1,10 +1,9 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Disarm;
 using Cpp2IL.Core.Logging;
 using Cpp2IL.Core.Utils;
-using Iced.Intel;
 using LibCpp2IL;
 using LibCpp2IL.Reflection;
 
@@ -105,23 +104,16 @@ protected override ulong FindFunctionThisIsAThunkOf(ulong thunkPtr, bool priorit
     {
         var instructions = NewArm64Utils.GetArm64MethodBodyAtVirtualAddress(thunkPtr, true);
 
-        try
-        {
-            var target = prioritiseCall ? Arm64Mnemonic.BL : Arm64Mnemonic.B;
-            var matchingCall = instructions.FirstOrDefault(i => i.Mnemonic == target);
-
-            if (matchingCall.Mnemonic == Arm64Mnemonic.INVALID)
-            {
-                target = target == Arm64Mnemonic.BL ? Arm64Mnemonic.B : Arm64Mnemonic.BL;
-                matchingCall = instructions.First(i => i.Mnemonic == target);
-            }
+        var target = prioritiseCall ? Arm64Mnemonic.BL : Arm64Mnemonic.B;
+        var matchingCall = instructions.FirstOrDefault(i => i.Mnemonic == target);
 
-            return matchingCall.BranchTarget;
-        }
-        catch (Exception)
+        if (matchingCall.Mnemonic == Arm64Mnemonic.INVALID)
         {
-            return 0;
+            target = target == Arm64Mnemonic.BL ? Arm64Mnemonic.B : Arm64Mnemonic.BL;
+            matchingCall = instructions.FirstOrDefault(i => i.Mnemonic == target);
         }
+
+        return matchingCall.Mnemonic != Arm64Mnemonic.INVALID ? matchingCall.BranchTarget : 0;
     }
 
     protected override int GetCallerCount(ulong toWhere)

Cpp2IL.Core/Il2CppApiFunctions/X86KeyFunctionAddresses.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Cpp2IL.Core.Logging;
@@ -112,23 +112,16 @@ protected override ulong FindFunctionThisIsAThunkOf(ulong thunkPtr, bool priorit
     {
         var instructions = X86Utils.GetMethodBodyAtVirtAddressNew(thunkPtr, true);
 
-        try
-        {
-            var target = prioritiseCall ? Mnemonic.Call : Mnemonic.Jmp;
-            var matchingCall = instructions.FirstOrDefault(i => i.Mnemonic == target);
-
-            if (matchingCall.Mnemonic == Mnemonic.INVALID)
-            {
-                target = target == Mnemonic.Call ? Mnemonic.Jmp : Mnemonic.Call;
-                matchingCall = instructions.First(i => i.Mnemonic == target);
-            }
+        var target = prioritiseCall ? Mnemonic.Call : Mnemonic.Jmp;
+        var matchingCall = instructions.FirstOrDefault(i => i.Mnemonic == target);
 
-            return matchingCall.NearBranchTarget;
-        }
-        catch (Exception)
+        if (matchingCall.Mnemonic == Mnemonic.INVALID)
         {
-            return 0;
+            target = target == Mnemonic.Call ? Mnemonic.Jmp : Mnemonic.Call;
+            matchingCall = instructions.FirstOrDefault(i => i.Mnemonic == target);
         }
+
+        return matchingCall.Mnemonic != Mnemonic.INVALID ? matchingCall.NearBranchTarget : 0;
     }
 
     protected override int GetCallerCount(ulong toWhere)