Remove static mutable state from LibCpp2IL 2: Electric Boogaloo#542
Draft
Xpl0itR wants to merge 1 commit intoSamboyCoding:developmentfrom
Draft
Remove static mutable state from LibCpp2IL 2: Electric Boogaloo#542Xpl0itR wants to merge 1 commit intoSamboyCoding:developmentfrom
Xpl0itR wants to merge 1 commit intoSamboyCoding:developmentfrom
Conversation
Coverage Report for CI Build 24214080939Coverage decreased (-0.1%) to 35.264%Details
Uncovered Changes
Coverage Regressions46 previously-covered lines in 8 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OwningBinary/OwningMetadata(viaReadableClassbase) instead of staticLibCpp2IlMainfieldsLibCpp2IlContextholds all state that was previously global: Binary, Metadata, MethodsByPtr, and global mapper collectionsIl2CppBinaryautomatically propagatesOwningBinary/OwningMetadatato anyReadableClassit reads viaOnReadableCreatedIl2CppMetadatasetsOwningMetadataon all structures at construction, and exposesSetOwningBinaryOnAllStructurescalled by the builderIl2CppBinaryas an explicit parameter instead of accessing staticsLibCpp2IlMainmarked[Obsolete]for backwards compatibility