Improve ARMv8 function calling#560
Open
iLillie wants to merge 3 commits into
Open
Conversation
Coverage Report for CI Build 27545063549Coverage decreased (-0.02%) to 35.332%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
SamboyCoding
requested changes
Jun 15, 2026
| break; | ||
|
|
||
| AddCall(context, GetReturnRegisterForContext(possibleMethods[0]), address, instruction.BranchTarget); | ||
| } |
Owner
There was a problem hiding this comment.
This will silently drop the call if it's to an unmanaged/API function, need to handle it in an else.
Contributor
Author
There was a problem hiding this comment.
I had previously else that defaulted to the "incorrect" behavior, but I can do some testing and figure out the cases where the else might be hit 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #557 there was a bug added that was not previously found, for BL instructions we want to find the target function and use the return registers for the target function, so calls with void are not set for calls that are supposed to have a return type.
Also logic for callParams did not take into account CallVoid OpCode.