Fix toggle mask compilation and evaluation with ored terms#1976
Open
60k41p wants to merge 1 commit into
Open
Conversation
60k41p
changed the title
ored terms
60k41p
force-pushed
the
or-toggle-fix
branch
2 times, most recently
from
18a2b09 to
c45afbd
Compare
Optimisation: - Compute or_fields once per evaluation (not per block) - Add or_fields to toggle context struct and use it to skip OR processing in the hot loop when there are no OR toggle terms (the common case) - When there are OR fields, search terms by field_index (only for those fields) Rebuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/633826290415435777/1477489163514286303