Skip to content

Commit b3681b9

Browse files
committed
don't continue execution if getWindowHandle failed
1 parent 345ab07 commit b3681b9

1 file changed

Lines changed: 16 additions & 16 deletions

File tree

test/UITest.ts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,26 +1163,26 @@ describe('User entrypoints', function() {
11631163
it('should finish loading', async function() {
11641164
this.timeout(1200000 * TIME_MODIFIER);
11651165
this.slow(15000);
1166-
await openTestPageURL(browserCapabilities);
1167-
await wait(15000 * TIME_MODIFIER);
11681166
try {
1167+
await openTestPageURL(browserCapabilities);
1168+
await wait(15000 * TIME_MODIFIER);
11691169
currentTestWindow = await driver.getWindowHandle();
1170-
} catch(e) {}
11711170

1172-
if (TEST_EXTENSION) {
1173-
await dummyTab.init();
1174-
}
1175-
await wait(500);
1176-
await switchToTestWindow();
1171+
if (TEST_EXTENSION) {
1172+
await dummyTab.init();
1173+
}
1174+
await wait(500);
1175+
await switchToTestWindow();
11771176

1178-
await waitFor(() => {
1179-
return driver.executeScript(inlineFn(() => {
1180-
return window.polymerElementsLoaded;
1181-
}));
1182-
}, 2500, 600000 * TIME_MODIFIER).then(() => {}, () => {
1183-
//About to time out
1184-
throw new Error('Failed to get elements loaded message, page load is failing');
1185-
});
1177+
await waitFor(() => {
1178+
return driver.executeScript(inlineFn(() => {
1179+
return window.polymerElementsLoaded;
1180+
}));
1181+
}, 2500, 600000 * TIME_MODIFIER).then(() => {}, () => {
1182+
//About to time out
1183+
throw new Error('Failed to get elements loaded message, page load is failing');
1184+
});
1185+
} catch(e) {}
11861186
});
11871187
});
11881188
describe('CheckboxOptions', function() {

0 commit comments

Comments
 (0)