Skip to content

bumps 1.1 source tree was rearranged#724

Merged
butlerpd merged 1 commit into
masterfrom
fix-bumps-reorganization
Jun 2, 2026
Merged

bumps 1.1 source tree was rearranged#724
butlerpd merged 1 commit into
masterfrom
fix-bumps-reorganization

Conversation

@pkienzle

@pkienzle pkienzle commented May 8, 2026

Copy link
Copy Markdown
Contributor

The bumps source tree is being reorganized for version 1.1, so some imports have moved to different locations.

This PR supports both the old and the new interfaces.

This only affects the python -m sasmodels.compare -edit MODELNAME invocation used to explore the parameter space of the model interactively.

Test that it works before and after using

uv pip install git+https://github.com/bumps/bumps.git@centralize-bumps-api-4
python -m sasmodels.compare -edit cylinder
uv pip install bumps==1.0.4
python -m sasmodels.compare -edit cylinder

@krzywon krzywon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Tested locally using the bumps branch and the latest stable release and both work as expected.

This doesn't need to be merged before the code freeze, but won't hurt anything if it is.

@butlerpd butlerpd merged commit c76514c into master Jun 2, 2026
26 checks passed
@butlerpd butlerpd deleted the fix-bumps-reorganization branch June 2, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants