Refactoring Branch#3006

Draft

lucas-wilkins wants to merge 434 commits into

mainfrom

refactor_24

This pull request is big! We're only showing the most recent 250 commits

Commits on Mar 10, 2026

Provide default group, and disable the option.

James Crake-Merani
authored and
DrPaulSharp
committed
Added a placeholder for the search box.

James Crake-Merani
authored and
DrPaulSharp
committed
Simulate having preferred options.

James Crake-Merani
authored and
DrPaulSharp
committed
Allow double clicking to select a unit.

James Crake-Merani
authored and
DrPaulSharp
committed
Have a dictionary for the files loaded.

James Crake-Merani
authored and
DrPaulSharp
committed
Get raw_csv based on filename.

James Crake-Merani
authored and
DrPaulSharp
committed
Added a filename chooser widget.

James Crake-Merani
authored and
DrPaulSharp
committed
Add an event for when the current file changes.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed when guesses are attempted.

James Crake-Merani
authored and
DrPaulSharp
committed
Track rows is included seperately for each file.

James Crake-Merani
authored and
DrPaulSharp
committed
New widget for unit preferences.

James Crake-Merani
authored and
DrPaulSharp
committed
Created a preference line widget.

James Crake-Merani
authored and
DrPaulSharp
committed
Add a line for each column.

James Crake-Merani
authored and
DrPaulSharp
committed
Forgot to set layout parent.

James Crake-Merani
authored and
DrPaulSharp
committed
Again forgot parent :P

James Crake-Merani
authored and
DrPaulSharp
committed
Put the preferences in a scroll area.

James Crake-Merani
authored and
DrPaulSharp
committed
Turn off the horizontal scroll.

James Crake-Merani
authored and
DrPaulSharp
committed
Added a selection menu widget.

James Crake-Merani
authored and
DrPaulSharp
committed
Got the context menu to work.

James Crake-Merani
authored and
DrPaulSharp
committed
Set the checkbox first then update the rest.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the new list in sasview rather than hardcoding

James Crake-Merani
authored and
DrPaulSharp
committed
Removed some unused imports.

James Crake-Merani
authored and
DrPaulSharp
committed
Don't enable the select button immediately.

James Crake-Merani
authored and
DrPaulSharp
committed
Unpinned pyside6.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed typo.

James Crake-Merani
authored and
DrPaulSharp
committed
Remvoed shabang.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed casing.

James Crake-Merani
authored and
DrPaulSharp
committed
Unsplit line.

James Crake-Merani
authored and
DrPaulSharp
committed
Split import into two lines.

James Crake-Merani
authored and
DrPaulSharp
committed
Looks like a few names didn't change automatically

James Crake-Merani
authored and
DrPaulSharp
committed
Double clicking a unit selects it.

James Crake-Merani
authored and
DrPaulSharp
committed
Added an unload button.

James Crake-Merani
authored and
DrPaulSharp
committed
Use a horizontal layout.

James Crake-Merani
authored and
DrPaulSharp
committed
Handle case where there are no more files.

James Crake-Merani
authored and
DrPaulSharp
committed
Disable table when there's no data.

James Crake-Merani
authored and
DrPaulSharp
committed
Handle a unicode decode error.

James Crake-Merani
authored and
DrPaulSharp
committed
Set filename label on update.

James Crake-Merani
authored and
DrPaulSharp
committed
Reset the label back to original after unload.

James Crake-Merani
authored and
DrPaulSharp
committed
For now, ignore the horizontal size hint.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed error that sometimes happens when selecting.

James Crake-Merani
authored and
DrPaulSharp
committed
Disable the button when there's none to unload.

James Crake-Merani
authored and
DrPaulSharp
committed
Set current filename to none when there is none.

James Crake-Merani
authored and
DrPaulSharp
committed
Give a window title.

James Crake-Merani
authored and
DrPaulSharp
committed
Added a done button.

James Crake-Merani
authored and
DrPaulSharp
committed
Get the column tuple.

James Crake-Merani
authored and
DrPaulSharp
committed
Make this a property.

James Crake-Merani
authored and
DrPaulSharp
committed
Added exclude lines to match param in dataclass.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed logic error.

James Crake-Merani
authored and
DrPaulSharp
committed
Hook up the done button to an event.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed slot connection.

James Crake-Merani
authored and
DrPaulSharp
committed
Ascii dialog is now a dialog not a widget.

James Crake-Merani
authored and
DrPaulSharp
committed
I don't think these comments are needed anymore.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed how the current unit is found.

James Crake-Merani
authored and
DrPaulSharp
committed
Include the selected unit in the options.

James Crake-Merani
authored and
DrPaulSharp
committed
Accept when clicking the done button.

James Crake-Merani
authored and
DrPaulSharp
committed
Need to call items in order to destructure.

James Crake-Merani
authored and
DrPaulSharp
committed
Just hard code the value.

James Crake-Merani
authored and
DrPaulSharp
committed
Fix excluded_lines.

James Crake-Merani
authored and
DrPaulSharp
committed
Keep track of the full path.

James Crake-Merani
authored and
DrPaulSharp
committed
Fix the params.

James Crake-Merani
authored and
DrPaulSharp
committed
Load the data instead of printing params only.

James Crake-Merani
authored and
DrPaulSharp
committed
Return the unit not the symbol.

James Crake-Merani
authored and
DrPaulSharp
committed
Send in an empty dict of metadata for now.

James Crake-Merani
authored and
DrPaulSharp
committed
Added an edit metadata button.

James Crake-Merani
authored and
DrPaulSharp
committed
Bring in the files for the metadata filename gui.

James Crake-Merani
authored and
DrPaulSharp
committed
Renamed file, and ade it a dialog.

James Crake-Merani
authored and
DrPaulSharp
committed
Forgot to commit new file.

James Crake-Merani
authored and
DrPaulSharp
committed
Added save button.

James Crake-Merani
authored and
DrPaulSharp
committed
Hook up the save button to an event.

James Crake-Merani
authored and
DrPaulSharp
committed
Print out the component metadata on success.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed imports.

James Crake-Merani
authored and
DrPaulSharp
committed
Add edit metadata button.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed import.

James Crake-Merani
authored and
DrPaulSharp
committed
Get filename from self.

James Crake-Merani
authored and
DrPaulSharp
committed
Created a property for the separator text.

James Crake-Merani
authored and
DrPaulSharp
committed
Added a dict for separators.

James Crake-Merani
authored and
DrPaulSharp
committed
Take in initial values for these.

James Crake-Merani
authored and
DrPaulSharp
committed
Set the separator field.

James Crake-Merani
authored and
DrPaulSharp
committed
Pass in previous metadata, using defaults.

James Crake-Merani
authored and
DrPaulSharp
committed
Selected components should persist.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the actual metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Add widget for custom metadata entry.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed name to be more consistent.

James Crake-Merani
authored and
DrPaulSharp
committed
Add a custom entry button to the layout.

James Crake-Merani
authored and
DrPaulSharp
committed
Use a signal for when the custom button is pressed

James Crake-Merani
authored and
DrPaulSharp
committed
Started with the selector widget.

James Crake-Merani
authored and
DrPaulSharp
committed
Hook up event handlers properly.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the generic selector widget.

James Crake-Merani
authored and
DrPaulSharp
committed
Init the base class.

James Crake-Merani
authored and
DrPaulSharp
committed
Forgot to pass self into layout.

James Crake-Merani
authored and
DrPaulSharp
committed
Handle when there is no new widget.

James Crake-Merani
authored and
DrPaulSharp
committed
Use isinstance.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed event handling.

James Crake-Merani
authored and
DrPaulSharp
committed
Layout not inited properly.

James Crake-Merani
authored and
DrPaulSharp
committed
Need to delete, and reassign selector widget.

James Crake-Merani
authored and
DrPaulSharp
committed
This line shouldn't be here.

James Crake-Merani
authored and
DrPaulSharp
committed
Set the title of the metadata dialog.

James Crake-Merani
authored and
DrPaulSharp
committed
Use separate functions for creating these widgets.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the new function.

James Crake-Merani
authored and
DrPaulSharp
committed
Removed comment that doesn't make sense anymore.

James Crake-Merani
authored and
DrPaulSharp
committed
Handle value changes.

James Crake-Merani
authored and
DrPaulSharp
committed
Pass in the new args.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed typos in comments.

James Crake-Merani
authored and
DrPaulSharp
committed
Choose default widget based on current option.

James Crake-Merani
authored and
DrPaulSharp
committed
Set the field from the already set metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Wrong control.

James Crake-Merani
authored and
DrPaulSharp
committed
Pass raw_metadata into params.

James Crake-Merani
authored and
DrPaulSharp
committed
This should be a TODO comment.

James Crake-Merani
authored and
DrPaulSharp
committed
Updated this map with a todo warning.

James Crake-Merani
authored and
DrPaulSharp
committed
Gonna try a different approach.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed bug where not editing metadata wouldn't work

James Crake-Merani
authored and
DrPaulSharp
committed
Strip all of the lines.

James Crake-Merani
authored and
DrPaulSharp
committed
First step towards a master metadata dictionary.

James Crake-Merani
authored and
DrPaulSharp
committed
Pass along the master metadata dict.

James Crake-Merani
authored and
DrPaulSharp
committed
Pass in the master metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed round a bunch of type hints.

James Crake-Merani
authored and
DrPaulSharp
committed
Master metadata should be the same for all files.

James Crake-Merani
authored and
DrPaulSharp
committed
Give the master metadata a default value.

James Crake-Merani
authored and
DrPaulSharp
committed
This should be type hinted.

James Crake-Merani
authored and
DrPaulSharp
committed
Remove the metadata dict param.

James Crake-Merani
authored and
DrPaulSharp
committed
I think these are the wrong way round.

James Crake-Merani
authored and
DrPaulSharp
committed
Give the master metadata to metadata filename.

James Crake-Merani
authored and
DrPaulSharp
committed
Create some classes for metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Remove unneeded import.

James Crake-Merani
authored and
DrPaulSharp
committed
Implemented get_metadata function.

James Crake-Merani
authored and
DrPaulSharp
committed
Update metadata function.

James Crake-Merani
authored and
DrPaulSharp
committed
Add defaults.

James Crake-Merani
authored and
DrPaulSharp
committed
Implemented add file function.

James Crake-Merani
authored and
DrPaulSharp
committed
Make default_categories not a method.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed the signature of get metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Start using the new internal metadata class.

James Crake-Merani
authored and
DrPaulSharp
committed
Need to use factory for defaults.

James Crake-Merani
authored and
DrPaulSharp
committed
Add a separator field.

James Crake-Merani
authored and
DrPaulSharp
committed
Don't need the separator argument anymore.

James Crake-Merani
authored and
DrPaulSharp
committed
Type hint to keep pyright happy.

James Crake-Merani
authored and
DrPaulSharp
committed
Some more argument fixes.

James Crake-Merani
authored and
DrPaulSharp
committed
Don't need the separator param.

James Crake-Merani
authored and
DrPaulSharp
committed
Implemented clear_metadata function.

James Crake-Merani
authored and
DrPaulSharp
committed
Component selector uses the new metadata class.

James Crake-Merani
authored and
DrPaulSharp
committed
Get the filename components in the class itself.

James Crake-Merani
authored and
DrPaulSharp
committed
Replicate the behaviour of the old system.

James Crake-Merani
authored and
DrPaulSharp
committed
Updated the clear metadata function.

James Crake-Merani
authored and
DrPaulSharp
committed
Update for internal metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Use new params.

James Crake-Merani
authored and
DrPaulSharp
committed
Make sure a separator is initialised.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the name load file.

James Crake-Merani
authored and
DrPaulSharp
committed
Need to add file to metadata when loaded.

James Crake-Merani
authored and
DrPaulSharp
committed
Forgot to add these :P

James Crake-Merani
authored and
DrPaulSharp
committed
Remove old draw options call.

James Crake-Merani
authored and
DrPaulSharp
committed
Missing else.

James Crake-Merani
authored and
DrPaulSharp
committed
Pull out the new internal metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Don't need this comment.

James Crake-Merani
authored and
DrPaulSharp
committed
Take into account this is now a list.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the replaced class from sasdata.

James Crake-Merani
authored and
DrPaulSharp
committed
Whoops forgot to save these files.

James Crake-Merani
authored and
DrPaulSharp
committed
Forgot to remove old import.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the new params.

James Crake-Merani
authored and
DrPaulSharp
committed
Send the full file path.

James Crake-Merani
authored and
DrPaulSharp
committed
Should only split in metadata class.

James Crake-Merani
authored and
DrPaulSharp
committed
Default separator should be set in dialog.py

James Crake-Merani
authored and
DrPaulSharp
committed
Load multiple files at the same time.

James Crake-Merani
authored and
DrPaulSharp
committed
Updated name to avoid conflict with QT function.

James Crake-Merani
authored and
DrPaulSharp
committed
Added type hints.

James Crake-Merani
authored and
DrPaulSharp
committed
Add unparasable lines to warning label.

James Crake-Merani
authored and
DrPaulSharp
committed
Take into account the startpos.

James Crake-Merani
authored and
DrPaulSharp
committed
Update warning label is a function.

James Crake-Merani
authored and
DrPaulSharp
committed
Call new function when its needed.

James Crake-Merani
authored and
DrPaulSharp
committed
Forgot to save :P

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed how lines are counted.

James Crake-Merani
authored and
DrPaulSharp
committed
Try an orange font for this.

James Crake-Merani
authored and
DrPaulSharp
committed
Type hint to stop pyright from complaining.

James Crake-Merani
authored and
DrPaulSharp
committed
Don't pass the CSV if there isn't one.

James Crake-Merani
authored and
DrPaulSharp
committed
Separate this into another file.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed a crash when we have > 1000 rows.

James Crake-Merani
authored and
DrPaulSharp
committed
Started implementing default units.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the new preferred units.

James Crake-Merani
authored and
DrPaulSharp
committed
Add some radios for choosing what to separate on.

James Crake-Merani
authored and
DrPaulSharp
committed
Default to using the character.

James Crake-Merani
authored and
DrPaulSharp
committed
Use a separate propety for the expression.

James Crake-Merani
authored and
DrPaulSharp
committed
Split on casing as well.

James Crake-Merani
authored and
DrPaulSharp
committed
Use new constant for casing regex.

James Crake-Merani
authored and
DrPaulSharp
committed
Try hooking up to this event.

James Crake-Merani
authored and
DrPaulSharp
committed
We should probably use our internal split function.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed regex.

James Crake-Merani
authored and
DrPaulSharp
committed
Was using the wrong event.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed where options is generated.

James Crake-Merani
authored and
DrPaulSharp
committed
Need to set this earlier to stop the event firing

James Crake-Merani
authored and
DrPaulSharp
committed
This shouldn't be here anymore.

James Crake-Merani
authored and
DrPaulSharp
committed
These functions aren't needed anymore.

James Crake-Merani
authored and
DrPaulSharp
committed
Update the separator before updating stuff.

James Crake-Merani
authored and
DrPaulSharp
committed
Call purge unreachable on separator update.

James Crake-Merani
authored and
DrPaulSharp
committed
Disable the separator box if casing is enabled.

James Crake-Merani
authored and
DrPaulSharp
committed
Return unformatted if we're using casing separation.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed error when there are no capital letters.

James Crake-Merani
authored and
DrPaulSharp
committed
Use a property for starting pos.

James Crake-Merani
authored and
DrPaulSharp
committed
Update warning on selection/deselection.

James Crake-Merani
authored and
DrPaulSharp
committed
Add a setter for the current unit.

James Crake-Merani
authored and
DrPaulSharp
committed
Make sure units match on uncertanties.

James Crake-Merani
authored and
DrPaulSharp
committed
Trigger column changed when the unit changes.

James Crake-Merani
authored and
DrPaulSharp
committed
Stop event triggering when unit is empty.

James Crake-Merani
authored and
DrPaulSharp
committed
Make sure ALL the columns are numbers.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the new init separator method for the metadata.

James Crake-Merani
authored and
DrPaulSharp
committed
Add dev menu

lucas-wilkins
authored and
DrPaulSharp
committed
Make menu show when config setting made

lucas-wilkins
authored and
DrPaulSharp
committed
Should just be using split line from the reader.

James Crake-Merani
authored and
DrPaulSharp
committed
Shouldn't be calling items here.

James Crake-Merani
authored and
DrPaulSharp
committed
Convert to list to make the interpreter happy.

James Crake-Merani
authored and
DrPaulSharp
committed
This isn't true anymore.

James Crake-Merani
authored and
DrPaulSharp
committed
Type hinting to stop linting from complaining.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed the params for the new order.

James Crake-Merani
authored and
DrPaulSharp
committed
Updated order again.

James Crake-Merani
authored and
DrPaulSharp
committed
Changed order yet again.

James Crake-Merani
authored and
DrPaulSharp
committed
Add logic from starting the ascii reader from dev.

jamescrake-merani
authored and
DrPaulSharp
committed
Don't use relative module paths.

jamescrake-merani
authored and
DrPaulSharp
committed
Got rid of filename label, and move edit metadata.

jamescrake-merani
authored and
DrPaulSharp
committed
Rename load file to select file.

jamescrake-merani
authored and
DrPaulSharp
committed
Add a cancel button.

jamescrake-merani
authored and
DrPaulSharp
committed
Disbale units when column is ignored.

jamescrake-merani
authored and
DrPaulSharp
committed
Centre the checkbox and remove label.

jamescrake-merani
authored and
DrPaulSharp
committed
Try this for clearer.

jamescrake-merani
authored and
DrPaulSharp
committed
Maybe lets just empty the message.

jamescrake-merani
authored and
DrPaulSharp
committed
Implement set checked method as well.

jamescrake-merani
authored and
DrPaulSharp
committed
Didn't call method properly.

jamescrake-merani
authored and
DrPaulSharp
committed
Add type hinting here.

jamescrake-merani
authored and
DrPaulSharp
committed
Try this for resetting the foreground color.

jamescrake-merani
authored and
DrPaulSharp
committed
Fixed import.

jamescrake-merani
authored and
DrPaulSharp
committed
Use Lucas' mode idea for the column count.

jamescrake-merani
authored and
DrPaulSharp
committed
Put unload, and the filename on same line.

jamescrake-merani
authored and
DrPaulSharp
committed
Changed the bottom row.

jamescrake-merani
authored and
DrPaulSharp
committed
Fixed indentation mistake in guess.

jamescrake-merani
authored and
DrPaulSharp
committed
Changed how symbols are ignored.

jamescrake-merani
authored and
DrPaulSharp
committed
Add pluses to the symbols.

jamescrake-merani
authored and
DrPaulSharp
committed
SasData should keep the metadata categories.

jamescrake-merani
authored and
DrPaulSharp
committed
Updated units.

James Crake-Merani
authored and
DrPaulSharp
committed
Remove this comment.

James Crake-Merani
authored and
DrPaulSharp
committed
Remove fixme comment.

James Crake-Merani
authored and
DrPaulSharp
committed
Try this?

James Crake-Merani
authored and
DrPaulSharp
committed
Making casing consistent.

James Crake-Merani
authored and
DrPaulSharp
committed
Remove guess from the SasView repository.

James Crake-Merani
authored and
DrPaulSharp
committed
Update import.

James Crake-Merani
authored and
DrPaulSharp
committed
Init should probably be at the top.

James Crake-Merani
authored and
DrPaulSharp
committed
Move this logic into SasData.

James Crake-Merani
authored and
DrPaulSharp
committed
Removed the old import.

James Crake-Merani
authored and
DrPaulSharp
committed
Import the right function.

James Crake-Merani
authored and
DrPaulSharp
committed
Handle ignored columns.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixed crashes when a filename just using casing.

James Crake-Merani
authored and
DrPaulSharp
committed
Removed unneeded emit call.

James Crake-Merani
authored and
DrPaulSharp
committed
Use the bidrectional pairings.

James Crake-Merani
authored and
DrPaulSharp
committed
Fixes linting errors
DrPaulSharp
committed
Fixes build
DrPaulSharp
committed