Skip to content

Don't include magnetism parameters in pure python models#3961

Open
pkienzle wants to merge 1 commit into
mainfrom
sasmodels-732-magnetism-error
Open

Don't include magnetism parameters in pure python models#3961
pkienzle wants to merge 1 commit into
mainfrom
sasmodels-732-magnetism-error

Conversation

@pkienzle
Copy link
Copy Markdown
Contributor

Description

Use the model info interpreter from sasmodels.modelinfo rather than calling the internal modelinfo.make_parameter_table directly.

Fixes sasmodels #732

How Has This Been Tested?

The new tetrahedron pure python model loads without magnetism support, and the exist cylinder model loads with magnetism support.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@pkienzle pkienzle requested a review from sara-mokhtari May 22, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 new pure python models not working on installer

1 participant