Use POSIX uname function instead of QSysInfo for BSD Unix#159
Open
Andreyogld3d wants to merge 1 commit intoSaschaWillems:masterfrom
Open
Use POSIX uname function instead of QSysInfo for BSD Unix#159Andreyogld3d wants to merge 1 commit intoSaschaWillems:masterfrom
Andreyogld3d wants to merge 1 commit intoSaschaWillems:masterfrom
Conversation
For GhostBSD we have OS "unknown" for Report. https://vulkan.gpuinfo.org/displayreport.php?id=11527 We should use POSIX uname function instead of QSysInfo for BSD Unix After fixing we have correct result: https://vulkan.gpuinfo.org/displayreport.php?id=11577 Also, see SaschaWillems#124
Author
|
@SaschaWillems could you appove this request ? |
Owner
|
Can you provide two reports for the same driver/gpu combo? One before and one after the change? Merging this might cause the database logic to flag existing reports as not yet present in the database, so I need to make sure that this won't have a negative effect. |
Author
Hi, I have no BSD Unix right now, may be AMD RX 7600 doesn't support yet. Later, I will provide you report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For GhostBSD we have OS "unknown" for Report.
https://vulkan.gpuinfo.org/displayreport.php?id=11527
We should use POSIX uname function instead of QSysInfo for BSD Unix
After fixing we have correct result:
https://vulkan.gpuinfo.org/displayreport.php?id=11577
Also, see #124