feat: Add response body or detail to errors

[DFEvans]

The error message shown for a ClientError or ServerError includes only the status code, excluding the usually verbose detail returned by the API.

Add the detail of a JSON response if it exists, or body of a string response, to the error message.

[DFEvans]

Thoughts on tackling the test issues welcome - hit the same locally on main, and seems #69 is also seeing the same

[c-wygoda]

fixed the catalog api builder issue. rebase and let's see some 🟢

[DFEvans]

TIL that ./scripts/test.sh doesn't run all of the tests...

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/satvu
auth.py	120	31	74%	17–18, 66–74, 77–87, 90–100, 133, 137, 140–141, 228, 233–234
sdk.py	69	1	99%	59
core.py	93	1	99%	132
src/satvu/http
urllib3_adapter.py	113	38	66%	10–11, 78–93, 100–101, 113–114, 125–126, 214–215, 250, 261–343
requests_adapter.py	84	26	69%	9–10, 74, 81–82, 94–95, 106–107, 186–187, 219, 230–290
httpx_adapter.py	82	25	70%	9–10, 73, 80–81, 95–96, 179–180, 222–292
__init__.py	31	9	71%	63–66, 71, 88–90, 93–95, 102
stdlib_adapter.py	122	29	76%	75, 83–85, 101–104, 111–112, 125–126, 137–138, 244, 253, 289–355
errors.py	169	6	96%	157–158, 236–237, 441–442
src/satvu/services
example_cache.py	38	12	68%	58–59, 64–67, 70–75, 117–118
src/satvu/services/catalog
api.py	331	129	61%	96, 102, 131, 137, 175, 207, 213, 251, 291, 320, 326, 356, 362, 436, 488–513, 554, 586–604, 672, 680, 733–758, 795, 825, 831, 899, 905, 958–983, 1020, 1050, 1056, 1125, 1133, 1186–1211, 1251, 1281, 1289, 1357, 1363, 1416–1441, 1478, 1508, 1514, 1567, 1573, 1615–1637, 1674, 1680, 1715–1734
test_schemas.py	25	9	64%	71591, 71623, 71651, 71656, 71669, 71674, 71679–71680, 71685
src/satvu/services/catalog/models
acquisition_feature_collection_type.py	5	1	80%	8
acquisition_item_collection.py	5	1	80%	8
acquisition_item_type.py	5	1	80%	8
generic_item_type.py	5	1	80%	8
geo_json_geometry_collection_type.py	5	1	80%	8
geo_json_line_string_type.py	5	1	80%	8
geo_json_multi_line_string_type.py	5	1	80%	8
geo_json_multi_point_type.py	5	1	80%	8
geo_json_multi_polygon_type.py	5	1	80%	8
geo_json_point_type.py	5	1	80%	8
geo_json_polygon_type.py	5	1	80%	8
is_between_predicate_op.py	5	1	80%	8
is_in_list_predicate_op.py	5	1	80%	8
is_like_predicate_op.py	5	1	80%	8
is_null_predicate_op.py	5	1	80%	8
not_expression_op.py	5	1	80%	8
primary_feature_collection_type.py	5	1	80%	8
primary_item_collection.py	5	1	80%	8
primary_item_type.py	5	1	80%	8
surface_brightness_temperature_feature_collection_type.py	5	1	80%	8
surface_brightness_temperature_item_collection.py	5	1	80%	8
surface_brightness_temperature_item_type.py	5	1	80%	8
visual_feature_collection_type.py	5	1	80%	8
visual_item_collection.py	5	1	80%	8
visual_item_type.py	5	1	80%	8
and_or_expression_op.py	6	1	83%	9
binary_comparison_predicate_op.py	10	1	90%	13
arithmetic_expression_op.py	11	1	91%	14
src/satvu/services/cos
test_schemas.py	25	9	64%	91875, 91907, 91935, 91940, 91953, 91958, 91963–91964, 91969
api.py	152	39	74%	81, 120, 153, 184–196, 235, 264, 293–304, 355–356, 359–361, 472–473, 476–478, 584
src/satvu/services/cos/models
method.py	6	1	83%	9
primary_format.py	6	1	83%	9
satvu_filter.py	6	1	83%	9
collection.py	7	1	86%	10
src/satvu/services/id
test_schemas.py	25	9	64%	39258, 39290, 39318, 39323, 39336, 39341, 39346–39347, 39352
api.py	144	27	81%	84, 112–129, 167, 202, 237, 277, 304, 312, 347, 382, 409, 417, 450, 483, 510, 516, 554
src/satvu/services/id/models
notification_category.py	5	1	80%	8
reseller_webhook_event.py	5	1	80%	8
webhook_event.py	5	1	80%	8
reseller_notification_category.py	6	1	83%	9
topic.py	6	1	83%	9
webhook_failure_title.py	7	1	86%	10
src/satvu/services/otm
test_schemas.py	25	9	64%	468433, 468465, 468493, 468498, 468511, 468516, 468521–468522, 468527
api.py	228	54	76%	110, 141–153, 201, 232, 296, 325, 383–384, 387–389, 473, 511, 542–554, 585, 614, 644, 687, 726, 771, 795, 826, 855–866
src/satvu/services/otm/models
sortable_field.py	5	1	80%	8
collection.py	6	1	83%	9
direction.py	6	1	83%	9
filter_.py	6	1	83%	9
full_well_capacitance.py	6	1	83%	9
primary_format.py	6	1	83%	9
readout_mode.py	6	1	83%	9
request_method.py	6	1	83%	9
collections.py	7	1	86%	10
day_night_mode.py	7	1	86%	10
feasibility_request_status.py	9	1	89%	12
order_status.py	12	1	92%	15
src/satvu/services/policy
test_schemas.py	25	9	64%	2016, 2048, 2076, 2081, 2094, 2099, 2104–2105, 2110
api.py	30	2	93%	79, 117
src/satvu/services/reseller
api.py	110	51	54%	72, 115, 143–160, 204, 233–250, 288, 317–334, 372, 401–418
test_schemas.py	25	9	64%	15622, 15654, 15682, 15687, 15700, 15705, 15710–15711, 15716
src/satvu/services/reseller/models
request_method.py	5	1	80%	8
company_search_fields.py	6	1	83%	9
match_type.py	6	1	83%	9
kyc_status.py	7	1	86%	10
user_search_fields.py	8	1	88%	11
country_code.py	239	1	99%	242
src/satvu/services/wallet
test_schemas.py	25	10	60%	658, 690, 695, 718, 723, 736, 741, 746–747, 752
api.py	27	3	89%	66, 94, 100
src/satvu/shared
parsing.py	40	6	85%	106, 131–136
TOTAL	5487	609	89%

Tests	Skipped	Failures	Errors	Time
429	0 💤	0 ❌	0 🔥	35.871s ⏱️

[c-wygoda]

is there a reason to use bash? and if so, it must be called through /usr/bin/env as it's location can be different between OS, while /bin/sh is pretty much guaranteed to be there.

[DFEvans]

set -eo pipefail is a bash command - none of the scripts were valid sh scripts and crashed immediately for me.

[DFEvans]

(do Macs ship with a custom/aliased sh meaning it supports bash semantics? I was surprised this hadn't been noticed before)

[c-wygoda]

so no way to override anymore, even if we wanted, and changing the exception semantics as shown by massaging the tests into the new shape?

[DFEvans]

What use case do you have in mind for modifying the message?

The alternative I initially tried was managing the message setting each time the error is raised (well, created and put into an Err), but there's many places to do that across four different client implementations, which didn't seem right for a unified "report the error message as well as error code" change.