Skip to content

⭐Bug Fix: Entire section of the heading "AEC LIBRARY", on click links to "index.html" , in "resource.html"#1476

Open
DefinitelyObsessed wants to merge 4 commits into
SauravMukherjee44:mainfrom
DefinitelyObsessed:resources
Open

⭐Bug Fix: Entire section of the heading "AEC LIBRARY", on click links to "index.html" , in "resource.html"#1476
DefinitelyObsessed wants to merge 4 commits into
SauravMukherjee44:mainfrom
DefinitelyObsessed:resources

Conversation

@DefinitelyObsessed

Copy link
Copy Markdown
Contributor

🛠️ Fixes Issue

Fixes #1469 by @DefinitelyObsessed

👨‍💻 Changes proposed

In resource.html Fixed :

  • On click, only heading "AEC LIBRARY" links to "index.html" ,
  • So only on hovering over heading "AEC LIBRARY", pointer is 'cursor pointer', instead of it's entire section, In "resource.html"

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📷 Screenshots

Before After
OpSo#6 before-img OpSo#6 after-img

… should link to 'index.html' instead of it's entire section, In resource.html
@netlify

netlify Bot commented Jul 30, 2023

Copy link
Copy Markdown

Deploy Preview for aec-library-wbsite ready!

Name Link
🔨 Latest commit 82cd04e
🔍 Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64d66bc5a2e78b000815de53
😎 Deploy Preview https://deploy-preview-1476--aec-library-wbsite.netlify.app/resource
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohanbabbar04 rohanbabbar04 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we already have Back to Home, we should remove the nav link from the header...

Also next time make sure you add smaller PR title(If you want to add description add it as a comment), PR title should be short and apt for what you have done.

@DefinitelyObsessed

Copy link
Copy Markdown
Contributor Author

Thank you for pointing it out @rohanbabbar04 , next time I will make sure to add smaller PR title .

@rohanbabbar04

Copy link
Copy Markdown
Collaborator

You have merge conflicts, do resolve..

@DefinitelyObsessed

Copy link
Copy Markdown
Contributor Author

I hope the merge conflict was resolved, @rohanbabbar04.
Thank you for pointing it out .

@AbdullahWins AbdullahWins left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⭐ Bug Report : Entire section of the heading "AEC LIBRARY", on clicking links to "index.html" , in "resource.html"

3 participants