Introduce PrometheusMetricAssert and update metrics ITs for name compatibility#1
Open
SavitarC wants to merge 1 commit into
Open
Introduce PrometheusMetricAssert and update metrics ITs for name compatibility#1SavitarC wants to merge 1 commit into
SavitarC wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_totalsuffix behavior).Description
PrometheusMetricAssertutility withMetricKindenum and logic to resolve legacy and new Prometheus-compatible names and to assert metric presence viaassertDubboMetricExposed.ProviderMetricsITandConsumerMetricsITwith aMetricExpectationholder and helper methodsaddGauge/addCounterto record raw metric names and expected kinds.PrometheusMetricAssert.assertDubboMetricExposedand log missingrawNameandkindfor clearer diagnostics.Testing
ProviderMetricsITandConsumerMetricsIT, which exercise the/metricsscrape parsing and compatible-name assertions, and both tests passed.Codex Task