Skip to content

feat: add YML and MD documentation for all macros (#374)#489

Open
pkumar-data wants to merge 3 commits into
mainfrom
feat/374-macro-yml-documentation
Open

feat: add YML and MD documentation for all macros (#374)#489
pkumar-data wants to merge 3 commits into
mainfrom
feat/374-macro-yml-documentation

Conversation

@pkumar-data

Copy link
Copy Markdown
Contributor

Add dbt schema documentation for all 19 parent macros (YML + MD with usage examples) and all 187 adapter-specific macro implementations (YML only) across 11 adapters: snowflake, bigquery, databricks, exasol, fabric, oracle, postgres, redshift, sqlserver, synapse, and trino.

Description

Please include a summary of the changes and the related issue and context.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Tests you ran

Test Configuration:

  • datavault4dbt-Version:
  • dbt-Version: cloud/core, version number
  • dbt-adapter-Version:

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation or included information that needs updates (e.g. in the Wiki)

Add dbt schema documentation for all 19 parent macros (YML + MD with
usage examples) and all 187 adapter-specific macro implementations
(YML only) across 11 adapters: snowflake, bigquery, databricks, exasol,
fabric, oracle, postgres, redshift, sqlserver, synapse, and trino.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds dbt “schema.yml”-style macro documentation and companion Markdown docs for the package’s macro surface area, including adapter-dispatched implementations across supported warehouses.

Changes:

  • Added Markdown docs ({% docs ... %}) with usage examples for the parent/entrypoint macros.
  • Added version: 2 YAML schema documentation for the parent macros and for each adapter-specific adapter.dispatch() implementation.
  • Added schema + Markdown documentation for the clean_up_pit post-hook macro.

Reviewed changes

Copilot reviewed 225 out of 225 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
macros/hooks/clean_up_pit.md Adds usage documentation for the clean_up_pit post-hook macro.
macros/hooks/clean_up_pit.yml Adds schema documentation for the clean_up_pit macro arguments.
macros/tables/control_snap_v0.md Adds usage documentation for control_snap_v0.
macros/tables/control_snap_v0.yml Adds schema documentation for control_snap_v0 arguments.
macros/tables/control_snap_v1.md Adds usage documentation for control_snap_v1.
macros/tables/control_snap_v1.yml Adds schema documentation for control_snap_v1 arguments.
macros/tables/eff_sat_v0.md Adds usage documentation for eff_sat_v0.
macros/tables/eff_sat_v0.yml Adds schema documentation for eff_sat_v0 arguments.
macros/tables/hub.md Adds usage documentation for hub.
macros/tables/hub.yml Adds schema documentation for hub arguments.
macros/tables/link.md Adds usage documentation for link.
macros/tables/link.yml Adds schema documentation for link arguments.
macros/tables/ma_sat_v0.md Adds usage documentation for ma_sat_v0.
macros/tables/ma_sat_v0.yml Adds schema documentation for ma_sat_v0 arguments.
macros/tables/ma_sat_v1.md Adds usage documentation for ma_sat_v1.
macros/tables/ma_sat_v1.yml Adds schema documentation for ma_sat_v1 arguments.
macros/tables/nh_link.md Adds usage documentation for nh_link.
macros/tables/nh_link.yml Adds schema documentation for nh_link arguments.
macros/tables/nh_sat.md Adds usage documentation for nh_sat.
macros/tables/nh_sat.yml Adds schema documentation for nh_sat arguments.
macros/tables/pit.md Adds usage documentation for pit.
macros/tables/pit.yml Adds schema documentation for pit arguments.
macros/tables/rec_track_sat.md Adds usage documentation for rec_track_sat.
macros/tables/rec_track_sat.yml Adds schema documentation for rec_track_sat arguments.
macros/tables/ref_hub.md Adds usage documentation for ref_hub.
macros/tables/ref_hub.yml Adds schema documentation for ref_hub arguments.
macros/tables/ref_sat_v0.md Adds usage documentation for ref_sat_v0.
macros/tables/ref_sat_v0.yml Adds schema documentation for ref_sat_v0 arguments.
macros/tables/ref_sat_v1.md Adds usage documentation for ref_sat_v1.
macros/tables/ref_sat_v1.yml Adds schema documentation for ref_sat_v1 arguments.
macros/tables/ref_table.md Adds usage documentation for ref_table.
macros/tables/ref_table.yml Adds schema documentation for ref_table arguments.
macros/tables/sat_v0.md Adds usage documentation for sat_v0.
macros/tables/sat_v0.yml Adds schema documentation for sat_v0 arguments.
macros/tables/sat_v1.md Adds usage documentation for sat_v1.
macros/tables/sat_v1.yml Adds schema documentation for sat_v1 arguments.
macros/tables/bigquery/control_snap_v0.yml Adds BigQuery adapter schema docs for control_snap_v0.
macros/tables/bigquery/control_snap_v1.yml Adds BigQuery adapter schema docs for control_snap_v1.
macros/tables/bigquery/eff_sat_v0.yml Adds BigQuery adapter schema docs for eff_sat_v0.
macros/tables/bigquery/hub.yml Adds BigQuery adapter schema docs for hub.
macros/tables/bigquery/link.yml Adds BigQuery adapter schema docs for link.
macros/tables/bigquery/ma_sat_v0.yml Adds BigQuery adapter schema docs for ma_sat_v0.
macros/tables/bigquery/ma_sat_v1.yml Adds BigQuery adapter schema docs for ma_sat_v1.
macros/tables/bigquery/nh_link.yml Adds BigQuery adapter schema docs for nh_link.
macros/tables/bigquery/nh_sat.yml Adds BigQuery adapter schema docs for nh_sat.
macros/tables/bigquery/pit.yml Adds BigQuery adapter schema docs for pit.
macros/tables/bigquery/rec_track_sat.yml Adds BigQuery adapter schema docs for rec_track_sat.
macros/tables/bigquery/ref_hub.yml Adds BigQuery adapter schema docs for ref_hub.
macros/tables/bigquery/ref_sat_v0.yml Adds BigQuery adapter schema docs for ref_sat_v0.
macros/tables/bigquery/ref_sat_v1.yml Adds BigQuery adapter schema docs for ref_sat_v1.
macros/tables/bigquery/ref_table.yml Adds BigQuery adapter schema docs for ref_table.
macros/tables/bigquery/sat_v0.yml Adds BigQuery adapter schema docs for sat_v0.
macros/tables/bigquery/sat_v1.yml Adds BigQuery adapter schema docs for sat_v1.
macros/tables/databricks/control_snap_v0.yml Adds Databricks adapter schema docs for control_snap_v0.
macros/tables/databricks/control_snap_v1.yml Adds Databricks adapter schema docs for control_snap_v1.
macros/tables/databricks/eff_sat_v0.yml Adds Databricks adapter schema docs for eff_sat_v0.
macros/tables/databricks/hub.yml Adds Databricks adapter schema docs for hub.
macros/tables/databricks/link.yml Adds Databricks adapter schema docs for link.
macros/tables/databricks/ma_sat_v0.yml Adds Databricks adapter schema docs for ma_sat_v0.
macros/tables/databricks/ma_sat_v1.yml Adds Databricks adapter schema docs for ma_sat_v1.
macros/tables/databricks/nh_link.yml Adds Databricks adapter schema docs for nh_link.
macros/tables/databricks/nh_sat.yml Adds Databricks adapter schema docs for nh_sat.
macros/tables/databricks/pit.yml Adds Databricks adapter schema docs for pit.
macros/tables/databricks/rec_track_sat.yml Adds Databricks adapter schema docs for rec_track_sat.
macros/tables/databricks/ref_hub.yml Adds Databricks adapter schema docs for ref_hub.
macros/tables/databricks/ref_sat_v0.yml Adds Databricks adapter schema docs for ref_sat_v0.
macros/tables/databricks/ref_sat_v1.yml Adds Databricks adapter schema docs for ref_sat_v1.
macros/tables/databricks/ref_table.yml Adds Databricks adapter schema docs for ref_table.
macros/tables/databricks/sat_v0.yml Adds Databricks adapter schema docs for sat_v0.
macros/tables/databricks/sat_v1.yml Adds Databricks adapter schema docs for sat_v1.
macros/tables/exasol/control_snap_v0.yml Adds Exasol adapter schema docs for control_snap_v0.
macros/tables/exasol/control_snap_v1.yml Adds Exasol adapter schema docs for control_snap_v1.
macros/tables/exasol/eff_sat_v0.yml Adds Exasol adapter schema docs for eff_sat_v0.
macros/tables/exasol/hub.yml Adds Exasol adapter schema docs for hub.
macros/tables/exasol/link.yml Adds Exasol adapter schema docs for link.
macros/tables/exasol/ma_sat_v0.yml Adds Exasol adapter schema docs for ma_sat_v0.
macros/tables/exasol/ma_sat_v1.yml Adds Exasol adapter schema docs for ma_sat_v1.
macros/tables/exasol/nh_link.yml Adds Exasol adapter schema docs for nh_link.
macros/tables/exasol/nh_sat.yml Adds Exasol adapter schema docs for nh_sat.
macros/tables/exasol/pit.yml Adds Exasol adapter schema docs for pit.
macros/tables/exasol/rec_track_sat.yml Adds Exasol adapter schema docs for rec_track_sat.
macros/tables/exasol/ref_hub.yml Adds Exasol adapter schema docs for ref_hub.
macros/tables/exasol/ref_sat_v0.yml Adds Exasol adapter schema docs for ref_sat_v0.
macros/tables/exasol/ref_sat_v1.yml Adds Exasol adapter schema docs for ref_sat_v1.
macros/tables/exasol/ref_table.yml Adds Exasol adapter schema docs for ref_table.
macros/tables/exasol/sat_v0.yml Adds Exasol adapter schema docs for sat_v0.
macros/tables/exasol/sat_v1.yml Adds Exasol adapter schema docs for sat_v1.
macros/tables/fabric/control_snap_v0.yml Adds Fabric adapter schema docs for control_snap_v0.
macros/tables/fabric/control_snap_v1.yml Adds Fabric adapter schema docs for control_snap_v1.
macros/tables/fabric/eff_sat_v0.yml Adds Fabric adapter schema docs for eff_sat_v0.
macros/tables/fabric/hub.yml Adds Fabric adapter schema docs for hub.
macros/tables/fabric/link.yml Adds Fabric adapter schema docs for link.
macros/tables/fabric/ma_sat_v0.yml Adds Fabric adapter schema docs for ma_sat_v0.
macros/tables/fabric/ma_sat_v1.yml Adds Fabric adapter schema docs for ma_sat_v1.
macros/tables/fabric/nh_link.yml Adds Fabric adapter schema docs for nh_link.
macros/tables/fabric/nh_sat.yml Adds Fabric adapter schema docs for nh_sat.
macros/tables/fabric/pit.yml Adds Fabric adapter schema docs for pit.
macros/tables/fabric/rec_track_sat.yml Adds Fabric adapter schema docs for rec_track_sat.
macros/tables/fabric/ref_hub.yml Adds Fabric adapter schema docs for ref_hub.
macros/tables/fabric/ref_sat_v0.yml Adds Fabric adapter schema docs for ref_sat_v0.
macros/tables/fabric/ref_sat_v1.yml Adds Fabric adapter schema docs for ref_sat_v1.
macros/tables/fabric/ref_table.yml Adds Fabric adapter schema docs for ref_table.
macros/tables/fabric/sat_v0.yml Adds Fabric adapter schema docs for sat_v0.
macros/tables/fabric/sat_v1.yml Adds Fabric adapter schema docs for sat_v1.
macros/tables/oracle/control_snap_v0.yml Adds Oracle adapter schema docs for control_snap_v0.
macros/tables/oracle/control_snap_v1.yml Adds Oracle adapter schema docs for control_snap_v1.
macros/tables/oracle/eff_sat_v0.yml Adds Oracle adapter schema docs for eff_sat_v0.
macros/tables/oracle/hub.yml Adds Oracle adapter schema docs for hub.
macros/tables/oracle/link.yml Adds Oracle adapter schema docs for link.
macros/tables/oracle/ma_sat_v0.yml Adds Oracle adapter schema docs for ma_sat_v0.
macros/tables/oracle/ma_sat_v1.yml Adds Oracle adapter schema docs for ma_sat_v1.
macros/tables/oracle/nh_link.yml Adds Oracle adapter schema docs for nh_link.
macros/tables/oracle/nh_sat.yml Adds Oracle adapter schema docs for nh_sat.
macros/tables/oracle/pit.yml Adds Oracle adapter schema docs for pit.
macros/tables/oracle/rec_track_sat.yml Adds Oracle adapter schema docs for rec_track_sat.
macros/tables/oracle/ref_hub.yml Adds Oracle adapter schema docs for ref_hub.
macros/tables/oracle/ref_sat_v0.yml Adds Oracle adapter schema docs for ref_sat_v0.
macros/tables/oracle/ref_sat_v1.yml Adds Oracle adapter schema docs for ref_sat_v1.
macros/tables/oracle/ref_table.yml Adds Oracle adapter schema docs for ref_table.
macros/tables/oracle/sat_v0.yml Adds Oracle adapter schema docs for sat_v0.
macros/tables/oracle/sat_v1.yml Adds Oracle adapter schema docs for sat_v1.
macros/tables/postgres/control_snap_v0.yml Adds Postgres adapter schema docs for control_snap_v0.
macros/tables/postgres/control_snap_v1.yml Adds Postgres adapter schema docs for control_snap_v1.
macros/tables/postgres/eff_sat_v0.yml Adds Postgres adapter schema docs for eff_sat_v0.
macros/tables/postgres/hub.yml Adds Postgres adapter schema docs for hub.
macros/tables/postgres/link.yml Adds Postgres adapter schema docs for link.
macros/tables/postgres/ma_sat_v0.yml Adds Postgres adapter schema docs for ma_sat_v0.
macros/tables/postgres/ma_sat_v1.yml Adds Postgres adapter schema docs for ma_sat_v1.
macros/tables/postgres/nh_link.yml Adds Postgres adapter schema docs for nh_link.
macros/tables/postgres/nh_sat.yml Adds Postgres adapter schema docs for nh_sat.
macros/tables/postgres/pit.yml Adds Postgres adapter schema docs for pit.
macros/tables/postgres/rec_track_sat.yml Adds Postgres adapter schema docs for rec_track_sat.
macros/tables/postgres/ref_hub.yml Adds Postgres adapter schema docs for ref_hub.
macros/tables/postgres/ref_sat_v0.yml Adds Postgres adapter schema docs for ref_sat_v0.
macros/tables/postgres/ref_sat_v1.yml Adds Postgres adapter schema docs for ref_sat_v1.
macros/tables/postgres/ref_table.yml Adds Postgres adapter schema docs for ref_table.
macros/tables/postgres/sat_v0.yml Adds Postgres adapter schema docs for sat_v0.
macros/tables/postgres/sat_v1.yml Adds Postgres adapter schema docs for sat_v1.
macros/tables/redshift/control_snap_v0.yml Adds Redshift adapter schema docs for control_snap_v0.
macros/tables/redshift/control_snap_v1.yml Adds Redshift adapter schema docs for control_snap_v1.
macros/tables/redshift/eff_sat_v0.yml Adds Redshift adapter schema docs for eff_sat_v0.
macros/tables/redshift/hub.yml Adds Redshift adapter schema docs for hub.
macros/tables/redshift/link.yml Adds Redshift adapter schema docs for link.
macros/tables/redshift/ma_sat_v0.yml Adds Redshift adapter schema docs for ma_sat_v0.
macros/tables/redshift/ma_sat_v1.yml Adds Redshift adapter schema docs for ma_sat_v1.
macros/tables/redshift/nh_link.yml Adds Redshift adapter schema docs for nh_link.
macros/tables/redshift/nh_sat.yml Adds Redshift adapter schema docs for nh_sat.
macros/tables/redshift/pit.yml Adds Redshift adapter schema docs for pit.
macros/tables/redshift/rec_track_sat.yml Adds Redshift adapter schema docs for rec_track_sat.
macros/tables/redshift/ref_hub.yml Adds Redshift adapter schema docs for ref_hub.
macros/tables/redshift/ref_sat_v0.yml Adds Redshift adapter schema docs for ref_sat_v0.
macros/tables/redshift/ref_sat_v1.yml Adds Redshift adapter schema docs for ref_sat_v1.
macros/tables/redshift/ref_table.yml Adds Redshift adapter schema docs for ref_table.
macros/tables/redshift/sat_v0.yml Adds Redshift adapter schema docs for sat_v0.
macros/tables/redshift/sat_v1.yml Adds Redshift adapter schema docs for sat_v1.
macros/tables/snowflake/control_snap_v0.yml Adds Snowflake adapter schema docs for control_snap_v0.
macros/tables/snowflake/control_snap_v1.yml Adds Snowflake adapter schema docs for control_snap_v1.
macros/tables/snowflake/eff_sat_v0.yml Adds Snowflake adapter schema docs for eff_sat_v0.
macros/tables/snowflake/hub.yml Adds Snowflake adapter schema docs for hub.
macros/tables/snowflake/link.yml Adds Snowflake adapter schema docs for link.
macros/tables/snowflake/ma_sat_v0.yml Adds Snowflake adapter schema docs for ma_sat_v0.
macros/tables/snowflake/ma_sat_v1.yml Adds Snowflake adapter schema docs for ma_sat_v1.
macros/tables/snowflake/nh_link.yml Adds Snowflake adapter schema docs for nh_link.
macros/tables/snowflake/nh_sat.yml Adds Snowflake adapter schema docs for nh_sat.
macros/tables/snowflake/pit.yml Adds Snowflake adapter schema docs for pit.
macros/tables/snowflake/rec_track_sat.yml Adds Snowflake adapter schema docs for rec_track_sat.
macros/tables/snowflake/ref_hub.yml Adds Snowflake adapter schema docs for ref_hub.
macros/tables/snowflake/ref_sat_v0.yml Adds Snowflake adapter schema docs for ref_sat_v0.
macros/tables/snowflake/ref_sat_v1.yml Adds Snowflake adapter schema docs for ref_sat_v1.
macros/tables/snowflake/ref_table.yml Adds Snowflake adapter schema docs for ref_table.
macros/tables/snowflake/sat_v0.yml Adds Snowflake adapter schema docs for sat_v0.
macros/tables/snowflake/sat_v1.yml Adds Snowflake adapter schema docs for sat_v1.
macros/tables/sqlserver/control_snap_v0.yml Adds SQL Server adapter schema docs for control_snap_v0.
macros/tables/sqlserver/control_snap_v1.yml Adds SQL Server adapter schema docs for control_snap_v1.
macros/tables/sqlserver/eff_sat_v0.yml Adds SQL Server adapter schema docs for eff_sat_v0.
macros/tables/sqlserver/hub.yml Adds SQL Server adapter schema docs for hub.
macros/tables/sqlserver/link.yml Adds SQL Server adapter schema docs for link.
macros/tables/sqlserver/ma_sat_v0.yml Adds SQL Server adapter schema docs for ma_sat_v0.
macros/tables/sqlserver/ma_sat_v1.yml Adds SQL Server adapter schema docs for ma_sat_v1.
macros/tables/sqlserver/nh_link.yml Adds SQL Server adapter schema docs for nh_link.
macros/tables/sqlserver/nh_sat.yml Adds SQL Server adapter schema docs for nh_sat.
macros/tables/sqlserver/pit.yml Adds SQL Server adapter schema docs for pit.
macros/tables/sqlserver/rec_track_sat.yml Adds SQL Server adapter schema docs for rec_track_sat.
macros/tables/sqlserver/ref_hub.yml Adds SQL Server adapter schema docs for ref_hub.
macros/tables/sqlserver/ref_sat_v0.yml Adds SQL Server adapter schema docs for ref_sat_v0.
macros/tables/sqlserver/ref_sat_v1.yml Adds SQL Server adapter schema docs for ref_sat_v1.
macros/tables/sqlserver/ref_table.yml Adds SQL Server adapter schema docs for ref_table.
macros/tables/sqlserver/sat_v0.yml Adds SQL Server adapter schema docs for sat_v0.
macros/tables/sqlserver/sat_v1.yml Adds SQL Server adapter schema docs for sat_v1.
macros/tables/synapse/control_snap_v0.yml Adds Synapse adapter schema docs for control_snap_v0.
macros/tables/synapse/control_snap_v1.yml Adds Synapse adapter schema docs for control_snap_v1.
macros/tables/synapse/eff_sat_v0.yml Adds Synapse adapter schema docs for eff_sat_v0.
macros/tables/synapse/hub.yml Adds Synapse adapter schema docs for hub.
macros/tables/synapse/link.yml Adds Synapse adapter schema docs for link.
macros/tables/synapse/ma_sat_v0.yml Adds Synapse adapter schema docs for ma_sat_v0.
macros/tables/synapse/ma_sat_v1.yml Adds Synapse adapter schema docs for ma_sat_v1.
macros/tables/synapse/nh_link.yml Adds Synapse adapter schema docs for nh_link.
macros/tables/synapse/nh_sat.yml Adds Synapse adapter schema docs for nh_sat.
macros/tables/synapse/pit.yml Adds Synapse adapter schema docs for pit.
macros/tables/synapse/rec_track_sat.yml Adds Synapse adapter schema docs for rec_track_sat.
macros/tables/synapse/ref_hub.yml Adds Synapse adapter schema docs for ref_hub.
macros/tables/synapse/ref_sat_v0.yml Adds Synapse adapter schema docs for ref_sat_v0.
macros/tables/synapse/ref_sat_v1.yml Adds Synapse adapter schema docs for ref_sat_v1.
macros/tables/synapse/ref_table.yml Adds Synapse adapter schema docs for ref_table.
macros/tables/synapse/sat_v0.yml Adds Synapse adapter schema docs for sat_v0.
macros/tables/synapse/sat_v1.yml Adds Synapse adapter schema docs for sat_v1.
macros/tables/trino/control_snap_v0.yml Adds Trino adapter schema docs for control_snap_v0.
macros/tables/trino/control_snap_v1.yml Adds Trino adapter schema docs for control_snap_v1.
macros/tables/trino/eff_sat_v0.yml Adds Trino adapter schema docs for eff_sat_v0.
macros/tables/trino/hub.yml Adds Trino adapter schema docs for hub.
macros/tables/trino/link.yml Adds Trino adapter schema docs for link.
macros/tables/trino/ma_sat_v0.yml Adds Trino adapter schema docs for ma_sat_v0.
macros/tables/trino/ma_sat_v1.yml Adds Trino adapter schema docs for ma_sat_v1.
macros/tables/trino/nh_link.yml Adds Trino adapter schema docs for nh_link.
macros/tables/trino/nh_sat.yml Adds Trino adapter schema docs for nh_sat.
macros/tables/trino/pit.yml Adds Trino adapter schema docs for pit.
macros/tables/trino/rec_track_sat.yml Adds Trino adapter schema docs for rec_track_sat.
macros/tables/trino/ref_hub.yml Adds Trino adapter schema docs for ref_hub.
macros/tables/trino/ref_sat_v0.yml Adds Trino adapter schema docs for ref_sat_v0.
macros/tables/trino/ref_sat_v1.yml Adds Trino adapter schema docs for ref_sat_v1.
macros/tables/trino/ref_table.yml Adds Trino adapter schema docs for ref_table.
macros/tables/trino/sat_v0.yml Adds Trino adapter schema docs for sat_v0.
macros/tables/trino/sat_v1.yml Adds Trino adapter schema docs for sat_v1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread macros/tables/ref_hub.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 225 out of 225 changed files in this pull request and generated 15 comments.

Comment thread macros/tables/bigquery/hub.yml Outdated
Comment thread macros/tables/bigquery/link.yml Outdated
Comment thread macros/tables/bigquery/sat_v0.yml Outdated
Comment thread macros/tables/bigquery/sat_v1.yml Outdated
Comment thread macros/tables/bigquery/eff_sat_v0.yml Outdated
Comment thread macros/tables/bigquery/nh_sat.yml Outdated
Comment thread macros/tables/bigquery/nh_link.yml Outdated
Comment thread macros/tables/bigquery/ma_sat_v0.yml Outdated
Comment thread macros/tables/bigquery/ma_sat_v1.yml Outdated
Comment thread macros/tables/bigquery/control_snap_v0.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 225 out of 225 changed files in this pull request and generated no new comments.

@tkiehn tkiehn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread macros/staging/stage.md
derived_columns={
'country_isocode': {'value': '!GER', 'datatype': 'STRING'}
}
) }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is technically possible our de-facto standard uses yaml syntax like here.
Please adjust the examples accordingly.
(Posting this once, valid for all occurrences of this syntax)

We could add this kind of macro invocation to the examples as well, but this is out-of-scope for this PR imho.

Comment thread macros/staging/stage.md
### Metadata block usage

```jinja
{{ datavault4dbt.stage(yaml_metadata=meta) }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing context: What is meta, where and how is it defined?
(Posting this once, valid for all occurrences)

type: string
description: Name of the snapshot date timestamp column. Optional, defaults to 'datavault4dbt.sdts_alias'.
- name: end_date
type: timestamp

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it passed as a dbt-native timestamp type?

type: timestamp
description: Earliest timestamp for the snapshot table. Time part must be '00:00:00'.
- name: daily_snapshot_time
type: time

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it passed as a dbt-native time type?

documentation.
arguments:
- name: start_date
type: timestamp

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it passed as a dbt-native timestamp type?

@tkiehn tkiehn added the waiting-on-response Waiting on a response from the author or others, except maintainers. label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-response Waiting on a response from the author or others, except maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants