Feature/publish abc clinical demand forecast 4.0.0#5671
Merged
hyperupcall merged 1 commit intoMay 13, 2026
Merged
Conversation
Contributor
|
Merge conflicts |
- Added abc-clinical-demand-forecast-4.0.0.json schema file - Updated catalog.json to include version 4.0.0 and set as default - Updated schema-validation.jsonc with validation configuration - Added positive test case for version 4.0.0 - Copied negative test cases from version 3.0.0 Key changes in version 4.0.0: - Added optional enrollmentStartOffset property in two object definitions (one for child-region defaults, one for actual-value-with-inherit). Type: integer or null. Minimum: 0. Default: 0. Represents months from site activation until first enrollment (First Patient In lead time). Null means inherit from parent; the default-for-child-regions variant defaults to 0 if no ancestor sets a value. - The property is NOT in any required array, so existing 3.0.0 data validates against 4.0.0 unchanged. The major-version designation reflects that the new property meaningfully changes lead-time behavior for downstream consumers even though the schema permits omitting it. Testing: - Validated schema-specific: node ./cli.js check --schema-name=abc-clinical-demand-forecast-4.0.0.json (PASS) - Validated full test suite: node ./cli.js check (PASS, all 806 tested schemas) - Re-ran node ./cli.js check after rebasing onto current origin/master and after folding in pre-commit.ci auto-fix formatting: PASS, no errors or failures. Rebase note: this branch was rebased onto origin/master to resolve merge conflicts. The original 2.0.0 and 3.0.0 commits on this branch were dropped because those versions were already merged upstream via PR SchemaStore#5670. The pre-commit.ci auto-fix commit's formatting changes for the 4.0.0 schema (compact enum arrays, AUTO-GENERATED header comment) were folded into this commit so the rebased branch matches what the bot would otherwise re-push. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mosofsky
force-pushed
the
feature/publish-abc-clinical-demand-forecast-4.0.0
branch
from
b587b85 to
e12316b
Compare
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added schema abc-clinical-demand-forecast-4.0.0.json
Key changes in version 4.0.0:
(one for child-region defaults, one for actual-value-with-inherit).
Type: integer or null. Minimum: 0. Default: 0. Represents months from
site activation until first enrollment (First Patient In lead time).
Null means inherit from parent; the default-for-child-regions variant
defaults to 0 if no ancestor sets a value.
validates against 4.0.0 unchanged. The major-version designation
reflects that the new property meaningfully changes lead-time behavior
for downstream consumers even though the schema permits omitting it.
Testing: