Skip to content

Add deployment key property to environment in github-workflow schema#5481

Closed
salmanmkc wants to merge 1 commit intoSchemaStore:masterfrom
salmanmkc:add-deployment-key
Closed

Add deployment key property to environment in github-workflow schema#5481
salmanmkc wants to merge 1 commit intoSchemaStore:masterfrom
salmanmkc:add-deployment-key

Conversation

@salmanmkc
Copy link
Copy Markdown
Contributor

@salmanmkc salmanmkc commented Mar 21, 2026

Summary

Hey, I recently finished this feature, so just adding it to scheme store.

Adds the deployment boolean property to the environment object in the GitHub Actions workflow schema.

GitHub recently introduced the ability to use environments without creating a deployment record, controlled via the deployment key.

Documentation

Changes

  • Added deployment boolean property to the environment object (jobs.<job_id>.environment)
  • Includes $comment with link to official GitHub docs
  • Defaults to true when omitted

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@madskristensen
Copy link
Copy Markdown
Contributor

There are merge conflicts

@salmanmkc salmanmkc force-pushed the add-deployment-key branch from 5b5d592 to 6dde57c Compare March 21, 2026 23:34
@salmanmkc
Copy link
Copy Markdown
Contributor Author

salmanmkc commented Mar 21, 2026

There are merge conflicts

I've fixed it, I'm trying to align with our changes on our languageservice: https://github.com/actions/languageservices/blob/83de320ba99ee2bdbb14a2869462a8033714cd96/workflow-parser/src/workflow-v1.0.json#L2085

I held off making this PR until we got the blog post and announcements out.

Seems like someone else made a pr which differs that got merged in 5 hours ago, causing the merge conflicts

@hyperupcall
Copy link
Copy Markdown
Member

Thanks, closing this in favor of the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants