Add deployment key property to environment in github-workflow schema#5481
Closed
salmanmkc wants to merge 1 commit intoSchemaStore:masterfrom
Closed
Add deployment key property to environment in github-workflow schema#5481salmanmkc wants to merge 1 commit intoSchemaStore:masterfrom
salmanmkc wants to merge 1 commit intoSchemaStore:masterfrom
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Contributor
|
There are merge conflicts |
5b5d592 to
6dde57c
Compare
Contributor
Author
I've fixed it, I'm trying to align with our changes on our languageservice: https://github.com/actions/languageservices/blob/83de320ba99ee2bdbb14a2869462a8033714cd96/workflow-parser/src/workflow-v1.0.json#L2085 I held off making this PR until we got the blog post and announcements out. Seems like someone else made a pr which differs that got merged in 5 hours ago, causing the merge conflicts |
Member
|
Thanks, closing this in favor of the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hey, I recently finished this feature, so just adding it to scheme store.
Adds the
deploymentboolean property to theenvironmentobject in the GitHub Actions workflow schema.GitHub recently introduced the ability to use environments without creating a deployment record, controlled via the
deploymentkey.Documentation
Changes
deploymentboolean property to theenvironmentobject (jobs.<job_id>.environment)$commentwith link to official GitHub docstruewhen omitted